From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 8ArrD07kN2HluwAAgWs5BA (envelope-from ) for ; Wed, 08 Sep 2021 00:14:38 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id YIh1C07kN2HQeQAAbx9fmQ (envelope-from ) for ; Tue, 07 Sep 2021 22:14:38 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 10C4014099 for ; Wed, 8 Sep 2021 00:14:37 +0200 (CEST) Received: from localhost ([::1]:59588 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mNjMR-00063C-W5 for larch@yhetil.org; Tue, 07 Sep 2021 18:14:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37004) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mNjCE-0001hO-VV for guix-patches@gnu.org; Tue, 07 Sep 2021 18:04:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:46433) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mNjCE-0007SL-K7 for guix-patches@gnu.org; Tue, 07 Sep 2021 18:04:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mNjCE-0005gf-6u for guix-patches@gnu.org; Tue, 07 Sep 2021 18:04:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49868] [PATCH 0/2] guix: dune-build-system: Add a profile parameter. Resent-From: Julien Lepiller Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 07 Sep 2021 22:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49868 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: pukkamustard Cc: 49868@debbugs.gnu.org Received: via spool by 49868-submit@debbugs.gnu.org id=B49868.163105221221820 (code B ref 49868); Tue, 07 Sep 2021 22:04:02 +0000 Received: (at 49868) by debbugs.gnu.org; 7 Sep 2021 22:03:32 +0000 Received: from localhost ([127.0.0.1]:57979 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mNjBk-0005fs-GM for submit@debbugs.gnu.org; Tue, 07 Sep 2021 18:03:32 -0400 Received: from lepiller.eu ([89.234.186.109]:57528) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mNjBh-0005fh-OX for 49868@debbugs.gnu.org; Tue, 07 Sep 2021 18:03:31 -0400 Received: from lepiller.eu (localhost [127.0.0.1]) by lepiller.eu (OpenSMTPD) with ESMTP id dab6c63d; Tue, 7 Sep 2021 22:03:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lepiller.eu; h=date:from :to:cc:subject:message-id:in-reply-to:references:mime-version :content-type:content-transfer-encoding; s=dkim; bh=enj+pVjsCZU/ Kd4cH5iieZjkcx+F+C58X9sYCFmcXsY=; b=T/J7GjbDTdptKpcg+zhQm6l5LAru mnXs33fsU6I2mYxHPvlNMPTtt3ssqbcLIQTv9DddRlliCUFQYhk87MasRWfSaDZ1 sWdqFtVGoBwC3IMlD5o9Cp5Rf/YT7YCJv2Z2f+fAJ5DhwappimkHRTAsxl9aofq9 DfLs/YTY6Eb/VPUL+RN3wd+5Ox/ulr9WqVujrDL50oHWKjQFEv1Adv15Ve1D7FyI sHirM4iZCkuRl3mwdOIC9dOAclufCWZLNS0enLpoXQePymYZW8JXrYMir3yBnmzd AzA2rdHiSCZ33q18sQkjDAdyv98/CpCBWi0u4BIUrEeHOdQ0r93kcAhy+Q== Received: by lepiller.eu (OpenSMTPD) with ESMTPSA id bf486cfb (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Tue, 7 Sep 2021 22:03:27 +0000 (UTC) Date: Wed, 8 Sep 2021 00:03:21 +0200 From: Julien Lepiller Message-ID: <20210908000321.662876ee@tachikoma.lepiller.eu> In-Reply-To: <86lf48xifn.fsf@posteo.net> References: <20210804080423.3533-1-pukkamustard@posteo.net> <20210821000926.00deacf3@tachikoma.lepiller.eu> <868s0r72rb.fsf@posteo.net> <865yvv71sw.fsf@posteo.net> <86zgt75lhe.fsf@posteo.net> <86y288yavn.fsf@posteo.net> <36A316B4-720C-4753-AFFC-DBC68DBE5EF4@lepiller.eu> <86pmtky4yu.fsf@posteo.net> <20210907150330.31124799@tachikoma.lepiller.eu> <86lf48xifn.fsf@posteo.net> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1631052878; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=WB8ZTPiSnhHY0K2i9CFGdlxFatmFgjnfAj33jDB9rZ4=; b=DyRpjxwuSSbeUByvzcjlXBmTC0BT72g9PcTlooSlLkWTRszQkDPGASjwBJ3YBeu1qJEzM+ PdqpNEKtOEAjxaRehCd54MSCbF2ROG7reTVYFbjPiqKdrYbv59yW9dgJETfl+tKx9p1Ls5 dXKh2d36YQw1zDRzgxTaN2HddZTPW0EC1w6NDkdU+iwjk+1Ppgf6OADru0qRPgrE9gXRtQ 1iQqpRQaRs6WvSrr90pKIPI+06sR7ygEzruaMRrhM0VyfzOPfp37r3e9vxHs4NVXfnCtmM f4rAca45vz2TQzVOvrqjMM6wb7yBBT/wVqv2I7Z96de11tU1qz+jJ4r6i0IG6Q== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1631052878; a=rsa-sha256; cv=none; b=a6hvZ+kjU7wCm0zzjL6ebxRqoOEqbuLgieeeOr5o2OPqWsVwKrfbZqJy4ZY9lBZt4n8SHV uLsIjDMPJnt/vVwsX0M9mmd98Un4K6LdYlLcvdjdp0w9RUvXmWEdn4OwRBNGfLCImy6HGy K/7IgiqkoC13/L0BxmoidOWiDIThKGY2jEs5QzTeYQ+7HAJvcAb3aGOIutDWCfbzlysHYt ykgHdevA7UqzMLRzVfiota8Ul4sLbe7BQqdeU3HdGxfDqbdVh5Y/dhYolCeTdVBE2IXxSg Uql9z4/IsO1EHR0bzOFDrfjnsO6bJOdKuWcEi9v13q87YPqzD/dolWn4awGPCQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lepiller.eu header.s=dkim header.b="T/J7GjbD"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=lepiller.eu (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: 0.19 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lepiller.eu header.s=dkim header.b="T/J7GjbD"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=lepiller.eu (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 10C4014099 X-Spam-Score: 0.19 X-Migadu-Scanner: scn0.migadu.com X-TUID: DGWvyBuYAO87 Le Tue, 07 Sep 2021 18:11:24 +0000, pukkamustard a =C3=A9crit : > Julien Lepiller writes: >=20 > > Unfortunately, this is breaking our ocaml4.07-* packages, because > > the --release flag doesn't exist in the version we use for > > ocaml4.07-dune. =20 >=20 > Whoops. Seems like the --release flag was only added in dune 2.5.0 > (https://github.com/ocaml/dune/blob/main/CHANGES.md#250-09042020; > ocaml4.07-dune is at 1.11.3). >=20 > > I think the easiest would be to add a flag #:release? and set it to > > #f in package-with-ocaml4.07. =20 >=20 > That would work. But I think it would be better if we built everything > in release mode. >=20 > Unfortunately the way to do that with old dune is by expclity with '-p > PACKAGE1,PACKAGE2'. That means we need to rename the #:package > argument to #:packages, allow it to take a list and add explicit > packages to all OCaml4.07 packages. >=20 > Another way would be to write-out the flags for which -p and --release > are short-hand for. Unfortunately this is different in dune 2.9.0 and > 1.11.3 (taken from the --help): >=20 > 2.9.0: > --8<---------------cut here---------------start------------->8--- > --root . --ignore-promoted-rules --no-config --profile release > --always-show-command-line --promote-install-files --default-target > @install > --8<---------------cut here---------------end--------------->8--- >=20 > 1.11.3: > --8<---------------cut here---------------start------------->8--- > --root . --ignore-promoted-rules --no-config ----profile release > --8<---------------cut here---------------end--------------->8--- I suppose these additional flags are not available in dune 1.11? >=20 > Can we check the version of dune in dune-build-system and either use > --release or the set of 1.11.3 flags? >=20 > I just tried doing this in (guix build dune-build-system). Didn't work > as I couldn't use (guix package). After reading up, I guess this needs > to be done in (guix build-system dune) and lowered down as an > argument - maybe as 'dune-release-flags'? Would that be ok? Yeah, that sounds good. Another solution would be to get rid of ocaml4.07, but that's our future bootstrap path (as this is the only bootstrapped version currently), so we will need it anyway...