[bug#49533] [PATCH] gnu: Add omins-lv2.

[Thorsten Wilms <t_w_@freenet.de>]

On Wed, 01 Sep 2021 23:29:18 +0200
Ludovic Courtès <ludo@gnu.org> wrote:

> Did you have a chance to look into this?

Hi Ludovic, I missed to notice your earlier email. Thanks for it and
this reminder!


> > Please consider passing it through ./etc/indent-code.el:
> >
> >   https://guix.gnu.org/manual/en/html_node/Formatting-Code.html

I assumed Emacs would do the right thing as is. My guix-installed Emacs
does not offer a guix-devel-mode. There’s also no ./etc/indent-code.el
on this foreign distro.


> > Please check out
> > <https://guix.gnu.org/manual/en/html_node/Version-Numbers.html> on
> > how to compute version numbers in such cases.

Done. Assuming the very last example shows the pattern to use, I
suspect that there are a lot of packages that should, but do not use
it. At least in audio.scm.


> >> +   (native-search-paths
> >> +    (list (search-path-specification
> >> +           (variable "LV2_PATH")
> >> +           (files '("lib/lv2")))))
> >
> > I’m surprised this is here (in the plugin) rather than in the
> > package that loads this plugin.  There are other LV2 plugins doing
> > that though. Ricardo, WDYT?

I mean to recall that this was necessary for the first lv2 package I
wrote, but from then on, I may have been cargo-culting. Since my
lilv and sord are still broken, no lv2-host will run. So I can’t even
test this now.


> >> +   (license (list license:gpl2+ license:gpl2+))))
> >
> > (license license:gpl2+) should be enough.  :-)

Sheesh, I did it again!

New patch version follows in separate email.


Thanks!

-- 
Thorsten Wilms <t_w_@freenet.de>