* [bug#50325] [PATCH] gnu: Add fatrace.
@ 2021-09-01 19:04 Raphaël Mélotte
2021-09-01 20:10 ` Xinglu Chen
2021-09-01 20:43 ` [bug#50325] [PATCH v2] " Raphaël Mélotte
0 siblings, 2 replies; 6+ messages in thread
From: Raphaël Mélotte @ 2021-09-01 19:04 UTC (permalink / raw)
To: 50325; +Cc: Raphaël Mélotte
* gnu/packages/monitoring.scm (fatrace): New variable.
---
gnu/packages/monitoring.scm | 28 ++++++++++++++++++++++++++++
1 file changed, 28 insertions(+)
diff --git a/gnu/packages/monitoring.scm b/gnu/packages/monitoring.scm
index d2aef0eaab..87df0fa634 100644
--- a/gnu/packages/monitoring.scm
+++ b/gnu/packages/monitoring.scm
@@ -9,6 +9,7 @@
;;; Copyright © 2020 Lars-Dominik Braun <ldb@leibniz-psychology.org>
;;; Copyright © 2021 Marius Bakke <marius@gnu.org>
;;; Copyright © 2021 Stefan Reichör <stefan@xsteve.at>
+;;; Copyright © 2021 Raphaël Mélotte <raphael.melotte@mind.be>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -650,3 +651,30 @@ LAN, if wanted, and clients can switch between multiple hosts on the network.
Hostscope features a bridge to Influx DB. So Grafana can be used to visualize
the recorded data over time.")
(license license:gpl3+)))
+
+(define-public fatrace
+ (package
+ (name "fatrace")
+ (version "0.16.3")
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/martinpitt/fatrace")
+ (commit version)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "1bxz6v1z0icp716jnv3knjyqp8bv6xnkz8gqd8z3g2b6yxj5xff3"))))
+ (build-system gnu-build-system)
+ (arguments
+ `(#:phases (modify-phases %standard-phases
+ (delete 'configure)
+ ;; there are no tests to execute:
+ (delete 'check))
+ #:make-flags
+ (list (string-append "CC=" ,(cc-for-target))
+ (string-append "PREFIX=" %output))))
+ (synopsis "File access events monitor")
+ (description "Utility to report system wide file access events.")
+ (home-page "https://github.com/martinpitt/fatrace")
+ (license license:gpl3+)))
--
2.32.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* [bug#50325] [PATCH] gnu: Add fatrace.
2021-09-01 19:04 [bug#50325] [PATCH] gnu: Add fatrace Raphaël Mélotte
@ 2021-09-01 20:10 ` Xinglu Chen
2021-09-01 20:34 ` Raphaël Mélotte
2021-09-01 20:43 ` [bug#50325] [PATCH v2] " Raphaël Mélotte
1 sibling, 1 reply; 6+ messages in thread
From: Xinglu Chen @ 2021-09-01 20:10 UTC (permalink / raw)
To: Raphaël Mélotte, 50325; +Cc: Raphaël Mélotte
[-- Attachment #1: Type: text/plain, Size: 2581 bytes --]
On Wed, Sep 01 2021, Raphaël Mélotte wrote:
> * gnu/packages/monitoring.scm (fatrace): New variable.
> ---
> gnu/packages/monitoring.scm | 28 ++++++++++++++++++++++++++++
> 1 file changed, 28 insertions(+)
>
> diff --git a/gnu/packages/monitoring.scm b/gnu/packages/monitoring.scm
> index d2aef0eaab..87df0fa634 100644
> --- a/gnu/packages/monitoring.scm
> +++ b/gnu/packages/monitoring.scm
> @@ -9,6 +9,7 @@
> ;;; Copyright © 2020 Lars-Dominik Braun <ldb@leibniz-psychology.org>
> ;;; Copyright © 2021 Marius Bakke <marius@gnu.org>
> ;;; Copyright © 2021 Stefan Reichör <stefan@xsteve.at>
> +;;; Copyright © 2021 Raphaël Mélotte <raphael.melotte@mind.be>
> ;;;
> ;;; This file is part of GNU Guix.
> ;;;
> @@ -650,3 +651,30 @@ LAN, if wanted, and clients can switch between multiple hosts on the network.
> Hostscope features a bridge to Influx DB. So Grafana can be used to visualize
> the recorded data over time.")
> (license license:gpl3+)))
> +
> +(define-public fatrace
> + (package
> + (name "fatrace")
> + (version "0.16.3")
> + (source (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/martinpitt/fatrace")
> + (commit version)))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32
> + "1bxz6v1z0icp716jnv3knjyqp8bv6xnkz8gqd8z3g2b6yxj5xff3"))))
> + (build-system gnu-build-system)
> + (arguments
> + `(#:phases (modify-phases %standard-phases
Nit: The ‘modify-phases’ form is usually on a separate line:
(arguments
`(#:phases
(modify-phases %standard-phases
...)))
> + (delete 'configure)
> + ;; there are no tests to execute:
> + (delete 'check))
Are you sure about that? There is a test/ directory in the Git repo.
> + #:make-flags
> + (list (string-append "CC=" ,(cc-for-target))
> + (string-append "PREFIX=" %output))))
> + (synopsis "File access events monitor")
> + (description "Utility to report system wide file access events.")
The description should be a complete sentence; maybe (based on the README)
This package provides a utility to report system wide file access
events from all running processes. Its main purpose is to find
processes which keep waking up the disk unnecessarily and thus prevent
some power saving.
The package builds fine. :-)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* [bug#50325] [PATCH] gnu: Add fatrace.
2021-09-01 20:10 ` Xinglu Chen
@ 2021-09-01 20:34 ` Raphaël Mélotte
0 siblings, 0 replies; 6+ messages in thread
From: Raphaël Mélotte @ 2021-09-01 20:34 UTC (permalink / raw)
To: Xinglu Chen, 50325
Thanks for the review!
On 9/1/21 10:10 PM, Xinglu Chen wrote:
> On Wed, Sep 01 2021, Raphaël Mélotte wrote:
>
>> * gnu/packages/monitoring.scm (fatrace): New variable.
>> ---
>> gnu/packages/monitoring.scm | 28 ++++++++++++++++++++++++++++
>> 1 file changed, 28 insertions(+)
>>
>> diff --git a/gnu/packages/monitoring.scm b/gnu/packages/monitoring.scm
>> index d2aef0eaab..87df0fa634 100644
>> --- a/gnu/packages/monitoring.scm
>> +++ b/gnu/packages/monitoring.scm
>> @@ -9,6 +9,7 @@
>> ;;; Copyright © 2020 Lars-Dominik Braun <ldb@leibniz-psychology.org>
>> ;;; Copyright © 2021 Marius Bakke <marius@gnu.org>
>> ;;; Copyright © 2021 Stefan Reichör <stefan@xsteve.at>
>> +;;; Copyright © 2021 Raphaël Mélotte <raphael.melotte@mind.be>
>> ;;;
>> ;;; This file is part of GNU Guix.
>> ;;;
>> @@ -650,3 +651,30 @@ LAN, if wanted, and clients can switch between multiple hosts on the network.
>> Hostscope features a bridge to Influx DB. So Grafana can be used to visualize
>> the recorded data over time.")
>> (license license:gpl3+)))
>> +
>> +(define-public fatrace
>> + (package
>> + (name "fatrace")
>> + (version "0.16.3")
>> + (source (origin
>> + (method git-fetch)
>> + (uri (git-reference
>> + (url "https://github.com/martinpitt/fatrace")
>> + (commit version)))
>> + (file-name (git-file-name name version))
>> + (sha256
>> + (base32
>> + "1bxz6v1z0icp716jnv3knjyqp8bv6xnkz8gqd8z3g2b6yxj5xff3"))))
>> + (build-system gnu-build-system)
>> + (arguments
>> + `(#:phases (modify-phases %standard-phases
>
> Nit: The ‘modify-phases’ form is usually on a separate line:
>
> (arguments
> `(#:phases
> (modify-phases %standard-phases
> ...)))
>
Ok, I'll change it.
>> + (delete 'configure)
>> + ;; there are no tests to execute:
>> + (delete 'check))
>
> Are you sure about that? There is a test/ directory in the Git repo.
Indeed, the comment is incorrect.
That said the tests need to run as root, have no make target, and need write
access to /etc so I think we can't run them anyway (at least not as-is).
>
>> + #:make-flags
>> + (list (string-append "CC=" ,(cc-for-target))
>> + (string-append "PREFIX=" %output))))
>> + (synopsis "File access events monitor")
>> + (description "Utility to report system wide file access events.")
>
> The description should be a complete sentence; maybe (based on the README)
>
> This package provides a utility to report system wide file access
> events from all running processes. Its main purpose is to find
> processes which keep waking up the disk unnecessarily and thus prevent
> some power saving.
>
Ok, I'll update it.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [bug#50325] [PATCH v2] gnu: Add fatrace.
2021-09-01 19:04 [bug#50325] [PATCH] gnu: Add fatrace Raphaël Mélotte
2021-09-01 20:10 ` Xinglu Chen
@ 2021-09-01 20:43 ` Raphaël Mélotte
2021-09-02 20:02 ` Xinglu Chen
2021-09-03 20:17 ` bug#50325: [PATCH] " Ludovic Courtès
1 sibling, 2 replies; 6+ messages in thread
From: Raphaël Mélotte @ 2021-09-01 20:43 UTC (permalink / raw)
To: 50325; +Cc: Raphaël Mélotte
* gnu/packages/monitoring.scm (fatrace): New variable.
---
Changes v1 -> v2 (all suggested by Xinglu Chen):
- put modify-phases on its own line.
- update the description.
- fix the comment for the check phase.
gnu/packages/monitoring.scm | 33 +++++++++++++++++++++++++++++++++
1 file changed, 33 insertions(+)
diff --git a/gnu/packages/monitoring.scm b/gnu/packages/monitoring.scm
index d2aef0eaab..46dea5eeb8 100644
--- a/gnu/packages/monitoring.scm
+++ b/gnu/packages/monitoring.scm
@@ -9,6 +9,7 @@
;;; Copyright © 2020 Lars-Dominik Braun <ldb@leibniz-psychology.org>
;;; Copyright © 2021 Marius Bakke <marius@gnu.org>
;;; Copyright © 2021 Stefan Reichör <stefan@xsteve.at>
+;;; Copyright © 2021 Raphaël Mélotte <raphael.melotte@mind.be>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -650,3 +651,35 @@ LAN, if wanted, and clients can switch between multiple hosts on the network.
Hostscope features a bridge to Influx DB. So Grafana can be used to visualize
the recorded data over time.")
(license license:gpl3+)))
+
+(define-public fatrace
+ (package
+ (name "fatrace")
+ (version "0.16.3")
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/martinpitt/fatrace")
+ (commit version)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "1bxz6v1z0icp716jnv3knjyqp8bv6xnkz8gqd8z3g2b6yxj5xff3"))))
+ (build-system gnu-build-system)
+ (arguments
+ `(#:phases
+ (modify-phases %standard-phases
+ (delete 'configure)
+ ;; tests need root to run as root,
+ ;; and there is no make target for them:
+ (delete 'check))
+ #:make-flags
+ (list (string-append "CC=" ,(cc-for-target))
+ (string-append "PREFIX=" %output))))
+ (synopsis "File access events monitor")
+ (description "This package provides a utility to report system wide file
+access events from all running processes. Its main purpose is to find
+processes which keep waking up the disk unnecessarily and thus prevent some
+power saving.")
+ (home-page "https://github.com/martinpitt/fatrace")
+ (license license:gpl3+)))
--
2.32.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* [bug#50325] [PATCH v2] gnu: Add fatrace.
2021-09-01 20:43 ` [bug#50325] [PATCH v2] " Raphaël Mélotte
@ 2021-09-02 20:02 ` Xinglu Chen
2021-09-03 20:17 ` bug#50325: [PATCH] " Ludovic Courtès
1 sibling, 0 replies; 6+ messages in thread
From: Xinglu Chen @ 2021-09-02 20:02 UTC (permalink / raw)
To: Raphaël Mélotte, 50325; +Cc: Raphaël Mélotte
[-- Attachment #1: Type: text/plain, Size: 330 bytes --]
On Wed, Sep 01 2021, Raphaël Mélotte wrote:
> * gnu/packages/monitoring.scm (fatrace): New variable.
> ---
> Changes v1 -> v2 (all suggested by Xinglu Chen):
> - put modify-phases on its own line.
> - update the description.
> - fix the comment for the check phase.
LGTM! I don’t have commit access though.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#50325: [PATCH] gnu: Add fatrace.
2021-09-01 20:43 ` [bug#50325] [PATCH v2] " Raphaël Mélotte
2021-09-02 20:02 ` Xinglu Chen
@ 2021-09-03 20:17 ` Ludovic Courtès
1 sibling, 0 replies; 6+ messages in thread
From: Ludovic Courtès @ 2021-09-03 20:17 UTC (permalink / raw)
To: Raphaël Mélotte; +Cc: 50325-done, Xinglu Chen
Hi,
Raphaël Mélotte <raphael.melotte@mind.be> skribis:
> * gnu/packages/monitoring.scm (fatrace): New variable.
Applied.
Thank you, and thanks Xinglu for the review!
Ludo’.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-09-03 20:21 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-09-01 19:04 [bug#50325] [PATCH] gnu: Add fatrace Raphaël Mélotte
2021-09-01 20:10 ` Xinglu Chen
2021-09-01 20:34 ` Raphaël Mélotte
2021-09-01 20:43 ` [bug#50325] [PATCH v2] " Raphaël Mélotte
2021-09-02 20:02 ` Xinglu Chen
2021-09-03 20:17 ` bug#50325: [PATCH] " Ludovic Courtès
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).