unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#50117] [PATCH 0/2] go-github-com-aswinkarthik-csvdiff package updates
@ 2021-08-19  7:17 BonfaceKilz
  2021-08-19  7:21 ` BonfaceKilz
  2021-12-10 11:17 ` [bug#50117] [PATCH 0/1] " BonfaceKilz
  0 siblings, 2 replies; 15+ messages in thread
From: BonfaceKilz @ 2021-08-19  7:17 UTC (permalink / raw)
  To: 50117; +Cc: BonfaceKilz, arunisaac, iskarian

Hi all. Find attached the updated package definition of csv diff which addresses the following issues that were kindly pointed out by Sarah:

--8<---------------cut here---------------start------------->8---
Typically end-user Go packages will want inputs/native-inputs rather
than propagated inputs unless the input provides a binary used at
runtime, so user profiles are not cluttered (go-build-system needs
source from all transitive dependencies).  Also, a more friendly name
("csvdiff" is available) might be better for end-user packages like
this.
--8<---------------cut here---------------end--------------->8---


BonfaceKilz (2):
  gnu: go-github-com-aswinkarthik-csvdiff: Rename name to "csvdiff".
  gnu: go-github-com-aswinkarthik-csvdiff: Make inputs native.

 gnu/packages/golang.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.31.1





^ permalink raw reply	[flat|nested] 15+ messages in thread

* [bug#50117] [PATCH 0/2] go-github-com-aswinkarthik-csvdiff package updates
  2021-08-19  7:17 [bug#50117] [PATCH 0/2] go-github-com-aswinkarthik-csvdiff package updates BonfaceKilz
@ 2021-08-19  7:21 ` BonfaceKilz
  2021-08-19  7:21   ` [bug#50117] [PATCH 1/2] gnu: go-github-com-aswinkarthik-csvdiff: Rename name to "csvdiff" BonfaceKilz
                     ` (2 more replies)
  2021-12-10 11:17 ` [bug#50117] [PATCH 0/1] " BonfaceKilz
  1 sibling, 3 replies; 15+ messages in thread
From: BonfaceKilz @ 2021-08-19  7:21 UTC (permalink / raw)
  To: 50117; +Cc: BonfaceKilz, arunisaac, iskarian

Hi all. Find attached the updated package definition of csv diff which addresses the following issues that were kindly pointed out by Sarah:

--8<---------------cut here---------------start------------->8---
Typically end-user Go packages will want inputs/native-inputs rather
than propagated inputs unless the input provides a binary used at
runtime, so user profiles are not cluttered (go-build-system needs
source from all transitive dependencies).  Also, a more friendly name
("csvdiff" is available) might be better for end-user packages like
this.
--8<---------------cut here---------------end--------------->8---


BonfaceKilz (2):
  gnu: go-github-com-aswinkarthik-csvdiff: Rename name to "csvdiff".
  gnu: go-github-com-aswinkarthik-csvdiff: Make inputs native.

 gnu/packages/golang.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.31.1





^ permalink raw reply	[flat|nested] 15+ messages in thread

* [bug#50117] [PATCH 1/2] gnu: go-github-com-aswinkarthik-csvdiff: Rename name to "csvdiff".
  2021-08-19  7:21 ` BonfaceKilz
@ 2021-08-19  7:21   ` BonfaceKilz
  2021-08-19  7:21   ` [bug#50117] [PATCH 2/2] gnu: go-github-com-aswinkarthik-csvdiff: Make inputs native BonfaceKilz
  2021-08-19 19:47   ` [bug#50117] [PATCH 0/2] go-github-com-aswinkarthik-csvdiff package updates Arun Isaac
  2 siblings, 0 replies; 15+ messages in thread
From: BonfaceKilz @ 2021-08-19  7:21 UTC (permalink / raw)
  To: 50117; +Cc: BonfaceKilz, arunisaac, iskarian

* gnu/packages/golang.scm (go-github-com-aswinkarthik-csvdiff)[name]: Rename
to "csvdiff" which is more user-friendly.
---
 gnu/packages/golang.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index 72579d6bd2..8a8830a6f6 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -8424,7 +8424,7 @@ non-cryptographic hash algorithm, working at speeds close to RAM limits.")
 
 (define-public go-github-com-aswinkarthik-csvdiff
   (package
-    (name "go-github-com-aswinkarthik-csvdiff")
+    (name "csvdiff")
     (version "1.4.0")
     (source
       (origin
-- 
2.31.1





^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [bug#50117] [PATCH 2/2] gnu: go-github-com-aswinkarthik-csvdiff: Make inputs native.
  2021-08-19  7:21 ` BonfaceKilz
  2021-08-19  7:21   ` [bug#50117] [PATCH 1/2] gnu: go-github-com-aswinkarthik-csvdiff: Rename name to "csvdiff" BonfaceKilz
@ 2021-08-19  7:21   ` BonfaceKilz
  2021-08-19 19:47   ` [bug#50117] [PATCH 0/2] go-github-com-aswinkarthik-csvdiff package updates Arun Isaac
  2 siblings, 0 replies; 15+ messages in thread
From: BonfaceKilz @ 2021-08-19  7:21 UTC (permalink / raw)
  To: 50117; +Cc: BonfaceKilz, arunisaac, iskarian

* gnu/packages/golang.scm (go-github-com-aswinkarthik-csvdiff)
[propagated-inputs]: Make these inputs native. Typically end-user Go packages
will want inputs/native-inputs rather than propagated inputs unless the input
provides a binary used at runtime, so user profiles are not
cluttered (go-build-system needs source from all transitive dependencies).
---
 gnu/packages/golang.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index 8a8830a6f6..7b151a03e3 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -8439,7 +8439,7 @@ non-cryptographic hash algorithm, working at speeds close to RAM limits.")
     (build-system go-build-system)
     (arguments
      '(#:import-path "github.com/aswinkarthik/csvdiff"))
-    (propagated-inputs
+    (native-inputs
      `(("go-golang-org-x-sys" ,go-golang-org-x-sys)
        ("go-github-com-stretchr-testify" ,go-github-com-stretchr-testify)
        ("go-github-com-spf13-cobra" ,go-github-com-spf13-cobra)
-- 
2.31.1





^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [bug#50117] [PATCH 0/2] go-github-com-aswinkarthik-csvdiff package updates
  2021-08-19  7:21 ` BonfaceKilz
  2021-08-19  7:21   ` [bug#50117] [PATCH 1/2] gnu: go-github-com-aswinkarthik-csvdiff: Rename name to "csvdiff" BonfaceKilz
  2021-08-19  7:21   ` [bug#50117] [PATCH 2/2] gnu: go-github-com-aswinkarthik-csvdiff: Make inputs native BonfaceKilz
@ 2021-08-19 19:47   ` Arun Isaac
  2021-12-09 10:35     ` Arun Isaac
  2 siblings, 1 reply; 15+ messages in thread
From: Arun Isaac @ 2021-08-19 19:47 UTC (permalink / raw)
  To: BonfaceKilz, 50117; +Cc: BonfaceKilz, iskarian

[-- Attachment #1: Type: text/plain, Size: 849 bytes --]


Hi Bonface,

Thanks for the patches! Some feedback follows.

1. I think we can combine the two commits into one since this is
logically just a single change.

2. We should retain the old package as a deprecated package. We should
add something like the snippet below.

--8<---------------cut here---------------start------------->8---
(define-public go-github-com-aswinkarthik-csvdiff
  (deprecated-package "go-github-com-aswinkarthik-csvdiff" csvdiff))
--8<---------------cut here---------------end--------------->8---

>  (define-public go-github-com-aswinkarthik-csvdiff

3. We should rename the variable name as well.

>    (package
> -    (name "go-github-com-aswinkarthik-csvdiff")
> +    (name "csvdiff")

3. We should also move the package to some file other than
golang.scm. How about textutils.scm?

Thank you for your patience! :-)
Arun

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 524 bytes --]

^ permalink raw reply	[flat|nested] 15+ messages in thread

* [bug#50117] [PATCH 0/2] go-github-com-aswinkarthik-csvdiff package updates
  2021-08-19 19:47   ` [bug#50117] [PATCH 0/2] go-github-com-aswinkarthik-csvdiff package updates Arun Isaac
@ 2021-12-09 10:35     ` Arun Isaac
  2021-12-09 14:02       ` Bonface M. K
  0 siblings, 1 reply; 15+ messages in thread
From: Arun Isaac @ 2021-12-09 10:35 UTC (permalink / raw)
  To: BonfaceKilz, 50117; +Cc: iskarian

[-- Attachment #1: Type: text/plain, Size: 70 bytes --]


Hi Bonface,

Any progress on this? Just a gentle ping.

Thanks,
Arun

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 524 bytes --]

^ permalink raw reply	[flat|nested] 15+ messages in thread

* [bug#50117] [PATCH 0/2] go-github-com-aswinkarthik-csvdiff package updates
  2021-12-09 10:35     ` Arun Isaac
@ 2021-12-09 14:02       ` Bonface M. K
  2021-12-10  3:30         ` Arun Isaac
  0 siblings, 1 reply; 15+ messages in thread
From: Bonface M. K @ 2021-12-09 14:02 UTC (permalink / raw)
  To: Arun Isaac, 50117; +Cc: iskarian

[-- Attachment #1: Type: text/plain, Size: 489 bytes --]

Arun Isaac <arunisaac@systemreboot.net> anaandika:

> Hi Bonface,
>
> Any progress on this? Just a gentle ping.
>
> Thanks,
> Arun

Hi!  Lemme have a look at this once my classes are
done.  Somehow this got lost in my To-Do tasks!
Thanks for the reminder.

-- 
Bonface M. K.
D4F09EB110177E03C28E2FE1F5BBAE1E0392253F (hkp://keys.gnupg.net)
Free Software Activist
Humble GNU Emacs User | Bearer of scheme-y parens
Curator: <https://upbookclub.com> | Twitter: @BonfaceKilz

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 865 bytes --]

^ permalink raw reply	[flat|nested] 15+ messages in thread

* [bug#50117] [PATCH 0/2] go-github-com-aswinkarthik-csvdiff package updates
  2021-12-09 14:02       ` Bonface M. K
@ 2021-12-10  3:30         ` Arun Isaac
  0 siblings, 0 replies; 15+ messages in thread
From: Arun Isaac @ 2021-12-10  3:30 UTC (permalink / raw)
  To: Bonface M. K, 50117; +Cc: iskarian

[-- Attachment #1: Type: text/plain, Size: 154 bytes --]


> Hi!  Lemme have a look at this once my classes are done.  Somehow this
> got lost in my To-Do tasks!  Thanks for the reminder.

Sure, Bonface, thanks!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 524 bytes --]

^ permalink raw reply	[flat|nested] 15+ messages in thread

* [bug#50117] [PATCH 0/1] go-github-com-aswinkarthik-csvdiff package updates
  2021-08-19  7:17 [bug#50117] [PATCH 0/2] go-github-com-aswinkarthik-csvdiff package updates BonfaceKilz
  2021-08-19  7:21 ` BonfaceKilz
@ 2021-12-10 11:17 ` BonfaceKilz
  2021-12-10 11:17   ` [bug#50117] [PATCH 1/1] gnu: Move csvdiff to (gnu packages textutils) BonfaceKilz
  2021-12-13  6:08   ` [bug#50117] [PATCH 0/1] go-github-com-aswinkarthik-csvdiff package updates Arun Isaac
  1 sibling, 2 replies; 15+ messages in thread
From: BonfaceKilz @ 2021-12-10 11:17 UTC (permalink / raw)
  To: 50117; +Cc: BonfaceKilz, arunisaac

Hi all!  Find below updated patches from a review from a while back.  @Arun, I
have moved csvdiff to textutils(it makes more semantic sense).  I see no need
of defining it as a deprecated-package since there's no package dependent on
it ATM.  Let me know if I need to change anything.  Thanks for being patient
with this!

BonfaceKilz (1):
  gnu: Move csvdiff to (gnu packages textutils).

 gnu/packages/golang.scm    | 44 ------------------------------------
 gnu/packages/textutils.scm | 46 ++++++++++++++++++++++++++++++++++++++
 2 files changed, 46 insertions(+), 44 deletions(-)

-- 
2.31.1





^ permalink raw reply	[flat|nested] 15+ messages in thread

* [bug#50117] [PATCH 1/1] gnu: Move csvdiff to (gnu packages textutils).
  2021-12-10 11:17 ` [bug#50117] [PATCH 0/1] " BonfaceKilz
@ 2021-12-10 11:17   ` BonfaceKilz
  2021-12-13  6:08   ` [bug#50117] [PATCH 0/1] go-github-com-aswinkarthik-csvdiff package updates Arun Isaac
  1 sibling, 0 replies; 15+ messages in thread
From: BonfaceKilz @ 2021-12-10 11:17 UTC (permalink / raw)
  To: 50117; +Cc: BonfaceKilz, arunisaac

See <http://issues.guix.gnu.org/50117>.

* gnu/packages/golang.scm (go-github-com-aswinkarthik-csvdiff): Move from here
* gnu/packages/textutils (go-github-com-aswinkarthik-csvdiff): to here.
---
 gnu/packages/golang.scm    | 44 ------------------------------------
 gnu/packages/textutils.scm | 46 ++++++++++++++++++++++++++++++++++++++
 2 files changed, 46 insertions(+), 44 deletions(-)

diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index d555a92579..49c124a415 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -8788,50 +8788,6 @@ zero round-trip encryption, and other advanced features.")
 non-cryptographic hash algorithm, working at speeds close to RAM limits.")
     (license license:asl2.0)))
 
-(define-public go-github-com-aswinkarthik-csvdiff
-  (package
-    (name "go-github-com-aswinkarthik-csvdiff")
-    (version "1.4.0")
-    (source
-      (origin
-        (method git-fetch)
-        (uri (git-reference
-               (url "https://github.com/aswinkarthik/csvdiff")
-               (commit (string-append "v" version))))
-        (file-name (git-file-name name version))
-        (sha256
-         (base32
-          "0cd1ikxsypjqisfnmr7zix3g7x8p892w77086465chyd39gpk97b"))))
-    (build-system go-build-system)
-    (arguments
-     '(#:import-path "github.com/aswinkarthik/csvdiff"))
-    (propagated-inputs
-     `(("go-golang-org-x-sys" ,go-golang-org-x-sys)
-       ("go-github-com-stretchr-testify" ,go-github-com-stretchr-testify)
-       ("go-github-com-spf13-cobra" ,go-github-com-spf13-cobra)
-       ("go-github-com-spf13-afero" ,go-github-com-spf13-afero)
-       ("go-github-com-spaolacci-murmur3" ,go-github-com-spaolacci-murmur3)
-       ("go-github-com-mattn-go-colorable" ,go-github-com-mattn-go-colorable)
-       ("go-github-com-fatih-color" ,go-github-com-fatih-color)
-       ("go-github-com-cespare-xxhash" ,go-github-com-cespare-xxhash)
-       ("go-github-com-oneofone-xxhash" ,go-github-com-oneofone-xxhash)))
-    (home-page "https://github.com/aswinkarthik/csvdiff")
-    (synopsis "Fast diff tool for comparing CSV files")
-    (description "@code{csvdiff} is a diff tool to compute changes between two
-CSV files.  It can compare CSV files with a million records in under 2
-seconds.  It is specifically suited for comparing CSV files dumped from
-database tables.  GNU Diff is orders of magnitude faster for comparing line by
-line.  @code{csvdiff} supports
-
-@itemize
-@item Selective comparison of fields in a row
-@item Specifying group of columns as primary-key to uniquely identify a row
-@item Ignoring columns
-@item Several output formats including colored git style output or
-JSON for post-processing
-@end itemize")
-    (license license:expat)))
-
 (define-public go-gopkg-in-djherbis-times-v1
   (package
     (name "go-gopkg-in-djherbis-times-v1")
diff --git a/gnu/packages/textutils.scm b/gnu/packages/textutils.scm
index 7e7293ac16..9a8b9ae1e8 100644
--- a/gnu/packages/textutils.scm
+++ b/gnu/packages/textutils.scm
@@ -22,6 +22,7 @@
 ;;; Copyright © 2020 Maxim Cournoyer <maxim.cournoyer@gmail.com>
 ;;; Copyright © 2021 Jean-Baptiste Volatier <jbv@pm.me>
 ;;; Copyright © 2021 Simon Tournier <zimon.toutoune@gmail.com>
+;;; Copyright © 2021 Bonface Munyoki Kilyungi <me@bonfacemunyoki.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -64,6 +65,7 @@
   #:use-module (gnu packages python)
   #:use-module (gnu packages python-build)
   #:use-module (gnu packages python-xyz)
+  #:use-module (gnu packages syncthing)
   #:use-module (gnu packages readline)
   #:use-module (gnu packages ruby)
   #:use-module (gnu packages slang)
@@ -1347,3 +1349,47 @@ languages such as HTML, Markdown, Asciidoc, and reStructuredText.  The community
 around it also has a list of style guides implemented with Vale in
 @url{https://github.com/errata-ai/styles, their styles repo}.")
     (license license:expat)))
+
+(define-public go-github-com-aswinkarthik-csvdiff
+  (package
+    (name "csvdiff")
+    (version "1.4.0")
+    (source
+      (origin
+        (method git-fetch)
+        (uri (git-reference
+               (url "https://github.com/aswinkarthik/csvdiff")
+               (commit (string-append "v" version))))
+        (file-name (git-file-name name version))
+        (sha256
+         (base32
+          "0cd1ikxsypjqisfnmr7zix3g7x8p892w77086465chyd39gpk97b"))))
+    (build-system go-build-system)
+    (arguments
+     '(#:import-path "github.com/aswinkarthik/csvdiff"))
+    (propagated-inputs
+     `(("go-golang-org-x-sys" ,go-golang-org-x-sys)
+       ("go-github-com-stretchr-testify" ,go-github-com-stretchr-testify)
+       ("go-github-com-spf13-cobra" ,go-github-com-spf13-cobra)
+       ("go-github-com-spf13-afero" ,go-github-com-spf13-afero)
+       ("go-github-com-spaolacci-murmur3" ,go-github-com-spaolacci-murmur3)
+       ("go-github-com-mattn-go-colorable" ,go-github-com-mattn-go-colorable)
+       ("go-github-com-fatih-color" ,go-github-com-fatih-color)
+       ("go-github-com-cespare-xxhash" ,go-github-com-cespare-xxhash)
+       ("go-github-com-oneofone-xxhash" ,go-github-com-oneofone-xxhash)))
+    (home-page "https://github.com/aswinkarthik/csvdiff")
+    (synopsis "Fast diff tool for comparing CSV files")
+    (description "@code{csvdiff} is a diff tool to compute changes between two
+CSV files.  It can compare CSV files with a million records in under 2
+seconds.  It is specifically suited for comparing CSV files dumped from
+database tables.  GNU Diff is orders of magnitude faster for comparing line by
+line.  @code{csvdiff} supports
+
+@itemize
+@item Selective comparison of fields in a row
+@item Specifying group of columns as primary-key to uniquely identify a row
+@item Ignoring columns
+@item Several output formats including colored git style output or
+JSON for post-processing
+@end itemize")
+    (license license:expat)))
-- 
2.31.1





^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [bug#50117] [PATCH 0/1] go-github-com-aswinkarthik-csvdiff package updates
  2021-12-10 11:17 ` [bug#50117] [PATCH 0/1] " BonfaceKilz
  2021-12-10 11:17   ` [bug#50117] [PATCH 1/1] gnu: Move csvdiff to (gnu packages textutils) BonfaceKilz
@ 2021-12-13  6:08   ` Arun Isaac
  2021-12-13  6:50     ` Bonface M. K
  2021-12-13 20:51     ` Bonface M. K
  1 sibling, 2 replies; 15+ messages in thread
From: Arun Isaac @ 2021-12-13  6:08 UTC (permalink / raw)
  To: BonfaceKilz; +Cc: 50117

[-- Attachment #1: Type: text/plain, Size: 443 bytes --]


Hi Bonface,

> Hi all!  Find below updated patches from a review from a while back.  @Arun, I
> have moved csvdiff to textutils(it makes more semantic sense).

Sounds good.

> I see no need of defining it as a deprecated-package since there's no
> package dependent on it ATM.

Users might have installed csvdiff into their profiles. So, I think we
still need to define a deprecated-package. Could you send an updated
patchset?

Thanks!
Arun

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 524 bytes --]

^ permalink raw reply	[flat|nested] 15+ messages in thread

* [bug#50117] [PATCH 0/1] go-github-com-aswinkarthik-csvdiff package updates
  2021-12-13  6:08   ` [bug#50117] [PATCH 0/1] go-github-com-aswinkarthik-csvdiff package updates Arun Isaac
@ 2021-12-13  6:50     ` Bonface M. K
  2021-12-13 20:51     ` Bonface M. K
  1 sibling, 0 replies; 15+ messages in thread
From: Bonface M. K @ 2021-12-13  6:50 UTC (permalink / raw)
  To: Arun Isaac; +Cc: 50117

[-- Attachment #1: Type: text/plain, Size: 807 bytes --]

Arun Isaac <arunisaac@systemreboot.net> anaandika:

> Hi Bonface,
>
>> Hi all!  Find below updated patches from a review from a while back.  @Arun, I
>> have moved csvdiff to textutils(it makes more semantic sense).
>
> Sounds good.
>
>> I see no need of defining it as a deprecated-package since there's no
>> package dependent on it ATM.
>
> Users might have installed csvdiff into their profiles. So, I think we
> still need to define a deprecated-package. Could you send an updated
> patchset?
>

Sure.  Let me do that later during the day...

> Thanks!
> Arun

-- 
Bonface M. K.
D4F09EB110177E03C28E2FE1F5BBAE1E0392253F (hkp://keys.gnupg.net)
Free Software Activist
Humble GNU Emacs User | Bearer of scheme-y parens
Curator: <https://upbookclub.com> | Twitter: @BonfaceKilz

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 865 bytes --]

^ permalink raw reply	[flat|nested] 15+ messages in thread

* [bug#50117] [PATCH 0/1] go-github-com-aswinkarthik-csvdiff package updates
  2021-12-13  6:08   ` [bug#50117] [PATCH 0/1] go-github-com-aswinkarthik-csvdiff package updates Arun Isaac
  2021-12-13  6:50     ` Bonface M. K
@ 2021-12-13 20:51     ` Bonface M. K
  2021-12-20  5:35       ` bug#50117: " Arun Isaac
  1 sibling, 1 reply; 15+ messages in thread
From: Bonface M. K @ 2021-12-13 20:51 UTC (permalink / raw)
  To: Arun Isaac; +Cc: 50117


[-- Attachment #1.1: Type: text/plain, Size: 629 bytes --]

Arun Isaac <arunisaac@systemreboot.net> anaandika:

> Hi Bonface,
>
>> Hi all!  Find below updated patches from a review from a while back.  @Arun, I
>> have moved csvdiff to textutils(it makes more semantic sense).
>
> Sounds good.
>
>> I see no need of defining it as a deprecated-package since there's no
>> package dependent on it ATM.
>
> Users might have installed csvdiff into their profiles. So, I think we
> still need to define a deprecated-package. Could you send an updated
> patchset?

Yup.  This makes sense.  Find attached a new patch
that adds an alias for the deprecated package.
Let me know if this is okay :)


[-- Attachment #1.2: 0001-gnu-Move-csvdiff-to-gnu-packages-textutils.patch --]
[-- Type: text/x-patch, Size: 6404 bytes --]

From 6767f1f8ffdbaa4c47b8fdd5778fbf570f4118d8 Mon Sep 17 00:00:00 2001
From: BonfaceKilz <me@bonfacemunyoki.com>
Date: Mon, 13 Dec 2021 23:42:56 +0300
Subject: [PATCH] gnu: Move csvdiff to (gnu packages textutils).

See <http://issues.guix.gnu.org/50117>.

* gnu/packages/golang.scm (go-github-com-aswinkarthik-csvdiff): Move from here
* gnu/packages/textutils (csvdiff): to here.
(go-github-com-aswinkarthik-csvdiff): Add deprecated alias for moved package.
---
 gnu/packages/golang.scm    | 44 ---------------------------------
 gnu/packages/textutils.scm | 50 ++++++++++++++++++++++++++++++++++++++
 2 files changed, 50 insertions(+), 44 deletions(-)

diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index 70731e2720..848f20fa1d 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -8754,50 +8754,6 @@ zero round-trip encryption, and other advanced features.")
 non-cryptographic hash algorithm, working at speeds close to RAM limits.")
     (license license:asl2.0)))
 
-(define-public go-github-com-aswinkarthik-csvdiff
-  (package
-    (name "go-github-com-aswinkarthik-csvdiff")
-    (version "1.4.0")
-    (source
-      (origin
-        (method git-fetch)
-        (uri (git-reference
-               (url "https://github.com/aswinkarthik/csvdiff")
-               (commit (string-append "v" version))))
-        (file-name (git-file-name name version))
-        (sha256
-         (base32
-          "0cd1ikxsypjqisfnmr7zix3g7x8p892w77086465chyd39gpk97b"))))
-    (build-system go-build-system)
-    (arguments
-     '(#:import-path "github.com/aswinkarthik/csvdiff"))
-    (propagated-inputs
-     `(("go-golang-org-x-sys" ,go-golang-org-x-sys)
-       ("go-github-com-stretchr-testify" ,go-github-com-stretchr-testify)
-       ("go-github-com-spf13-cobra" ,go-github-com-spf13-cobra)
-       ("go-github-com-spf13-afero" ,go-github-com-spf13-afero)
-       ("go-github-com-spaolacci-murmur3" ,go-github-com-spaolacci-murmur3)
-       ("go-github-com-mattn-go-colorable" ,go-github-com-mattn-go-colorable)
-       ("go-github-com-fatih-color" ,go-github-com-fatih-color)
-       ("go-github-com-cespare-xxhash" ,go-github-com-cespare-xxhash)
-       ("go-github-com-oneofone-xxhash" ,go-github-com-oneofone-xxhash)))
-    (home-page "https://github.com/aswinkarthik/csvdiff")
-    (synopsis "Fast diff tool for comparing CSV files")
-    (description "@code{csvdiff} is a diff tool to compute changes between two
-CSV files.  It can compare CSV files with a million records in under 2
-seconds.  It is specifically suited for comparing CSV files dumped from
-database tables.  GNU Diff is orders of magnitude faster for comparing line by
-line.  @code{csvdiff} supports
-
-@itemize
-@item Selective comparison of fields in a row
-@item Specifying group of columns as primary-key to uniquely identify a row
-@item Ignoring columns
-@item Several output formats including colored git style output or
-JSON for post-processing
-@end itemize")
-    (license license:expat)))
-
 (define-public go-gopkg-in-djherbis-times-v1
   (package
     (name "go-gopkg-in-djherbis-times-v1")
diff --git a/gnu/packages/textutils.scm b/gnu/packages/textutils.scm
index 7e7293ac16..c3baeeaa0b 100644
--- a/gnu/packages/textutils.scm
+++ b/gnu/packages/textutils.scm
@@ -22,6 +22,7 @@
 ;;; Copyright © 2020 Maxim Cournoyer <maxim.cournoyer@gmail.com>
 ;;; Copyright © 2021 Jean-Baptiste Volatier <jbv@pm.me>
 ;;; Copyright © 2021 Simon Tournier <zimon.toutoune@gmail.com>
+;;; Copyright © 2021 Bonface Munyoki Kilyungi <me@bonfacemunyoki.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -64,6 +65,7 @@
   #:use-module (gnu packages python)
   #:use-module (gnu packages python-build)
   #:use-module (gnu packages python-xyz)
+  #:use-module (gnu packages syncthing)
   #:use-module (gnu packages readline)
   #:use-module (gnu packages ruby)
   #:use-module (gnu packages slang)
@@ -1347,3 +1349,51 @@ languages such as HTML, Markdown, Asciidoc, and reStructuredText.  The community
 around it also has a list of style guides implemented with Vale in
 @url{https://github.com/errata-ai/styles, their styles repo}.")
     (license license:expat)))
+
+(define-public csvdiff
+  (package
+    (name "csvdiff")
+    (version "1.4.0")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/aswinkarthik/csvdiff")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32
+         "0cd1ikxsypjqisfnmr7zix3g7x8p892w77086465chyd39gpk97b"))))
+    (build-system go-build-system)
+    (arguments
+     '(#:import-path "github.com/aswinkarthik/csvdiff"))
+    (propagated-inputs
+     `(("go-golang-org-x-sys" ,go-golang-org-x-sys)
+       ("go-github-com-stretchr-testify" ,go-github-com-stretchr-testify)
+       ("go-github-com-spf13-cobra" ,go-github-com-spf13-cobra)
+       ("go-github-com-spf13-afero" ,go-github-com-spf13-afero)
+       ("go-github-com-spaolacci-murmur3" ,go-github-com-spaolacci-murmur3)
+       ("go-github-com-mattn-go-colorable" ,go-github-com-mattn-go-colorable)
+       ("go-github-com-fatih-color" ,go-github-com-fatih-color)
+       ("go-github-com-cespare-xxhash" ,go-github-com-cespare-xxhash)
+       ("go-github-com-oneofone-xxhash" ,go-github-com-oneofone-xxhash)))
+    (home-page "https://github.com/aswinkarthik/csvdiff")
+    (synopsis "Fast diff tool for comparing CSV files")
+    (description "@code{csvdiff} is a diff tool to compute changes between two
+CSV files.  It can compare CSV files with a million records in under 2
+seconds.  It is specifically suited for comparing CSV files dumped from
+database tables.  GNU Diff is orders of magnitude faster for comparing line by
+line.  @code{csvdiff} supports
+
+@itemize
+@item Selective comparison of fields in a row
+@item Specifying group of columns as primary-key to uniquely identify a row
+@item Ignoring columns
+@item Several output formats including colored git style output or
+JSON for post-processing
+@end itemize")
+    (license license:expat)))
+
+(define-public go-github-com-aswinkarthik-csvdiff
+  (deprecated-package "go-github-com-aswinkarthik-csvdiff" csvdiff))
+
-- 
2.31.1


[-- Attachment #1.3: Type: text/plain, Size: 225 bytes --]




-- 
Bonface M. K.
D4F09EB110177E03C28E2FE1F5BBAE1E0392253F (hkp://keys.gnupg.net)
Free Software Activist
Humble GNU Emacs User | Bearer of scheme-y parens
Curator: <https://upbookclub.com> | Twitter: @BonfaceKilz

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 865 bytes --]

^ permalink raw reply related	[flat|nested] 15+ messages in thread

* bug#50117: [PATCH 0/1] go-github-com-aswinkarthik-csvdiff package updates
  2021-12-13 20:51     ` Bonface M. K
@ 2021-12-20  5:35       ` Arun Isaac
  2021-12-21 12:29         ` [bug#50117] " Bonface M. K
  0 siblings, 1 reply; 15+ messages in thread
From: Arun Isaac @ 2021-12-20  5:35 UTC (permalink / raw)
  To: Bonface M. K; +Cc: 50117-done

[-- Attachment #1: Type: text/plain, Size: 243 bytes --]


Hi Bonface,

I have applied the patch on master with a few changes. Most
significantly, I moved the deprecated alias from
gnu/packages/textutils.scm to gnu/packages/golang.scm since golang.scm
is where the original package was.

Thanks,
Arun

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 524 bytes --]

^ permalink raw reply	[flat|nested] 15+ messages in thread

* [bug#50117] [PATCH 0/1] go-github-com-aswinkarthik-csvdiff package updates
  2021-12-20  5:35       ` bug#50117: " Arun Isaac
@ 2021-12-21 12:29         ` Bonface M. K
  0 siblings, 0 replies; 15+ messages in thread
From: Bonface M. K @ 2021-12-21 12:29 UTC (permalink / raw)
  To: Arun Isaac; +Cc: 50117-done

[-- Attachment #1: Type: text/plain, Size: 531 bytes --]

Arun Isaac <arunisaac@systemreboot.net> anaandika:

> Hi Bonface,
>
> I have applied the patch on master with a few changes. Most
> significantly, I moved the deprecated alias from
> gnu/packages/textutils.scm to gnu/packages/golang.scm since golang.scm
> is where the original package was.

Thanks!

-- 
Bonface M. K.
D4F09EB110177E03C28E2FE1F5BBAE1E0392253F (hkp://keys.gnupg.net)
Free Software Activist
Humble GNU Emacs User | Bearer of scheme-y parens
Curator: <https://upbookclub.com> | Twitter: @BonfaceKilz

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 865 bytes --]

^ permalink raw reply	[flat|nested] 15+ messages in thread

end of thread, other threads:[~2021-12-21 12:30 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-08-19  7:17 [bug#50117] [PATCH 0/2] go-github-com-aswinkarthik-csvdiff package updates BonfaceKilz
2021-08-19  7:21 ` BonfaceKilz
2021-08-19  7:21   ` [bug#50117] [PATCH 1/2] gnu: go-github-com-aswinkarthik-csvdiff: Rename name to "csvdiff" BonfaceKilz
2021-08-19  7:21   ` [bug#50117] [PATCH 2/2] gnu: go-github-com-aswinkarthik-csvdiff: Make inputs native BonfaceKilz
2021-08-19 19:47   ` [bug#50117] [PATCH 0/2] go-github-com-aswinkarthik-csvdiff package updates Arun Isaac
2021-12-09 10:35     ` Arun Isaac
2021-12-09 14:02       ` Bonface M. K
2021-12-10  3:30         ` Arun Isaac
2021-12-10 11:17 ` [bug#50117] [PATCH 0/1] " BonfaceKilz
2021-12-10 11:17   ` [bug#50117] [PATCH 1/1] gnu: Move csvdiff to (gnu packages textutils) BonfaceKilz
2021-12-13  6:08   ` [bug#50117] [PATCH 0/1] go-github-com-aswinkarthik-csvdiff package updates Arun Isaac
2021-12-13  6:50     ` Bonface M. K
2021-12-13 20:51     ` Bonface M. K
2021-12-20  5:35       ` bug#50117: " Arun Isaac
2021-12-21 12:29         ` [bug#50117] " Bonface M. K

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).