* [bug#50087] [PATCH 0/2] Add csvdiff @ 2021-08-17 5:47 BonfaceKilz 2021-08-17 5:50 ` BonfaceKilz 2021-08-17 20:00 ` Sarah Morgensen 0 siblings, 2 replies; 10+ messages in thread From: BonfaceKilz @ 2021-08-17 5:47 UTC (permalink / raw) To: 50087; +Cc: BonfaceKilz Hi all. This patch adds a fast csv diffing utility written in go-lang. BonfaceKilz (2): gn: Add go-github-com-oneofone-xxhash. gn: Add go-github-com-aswinkarthik-csvdiff. gnu/packages/golang.scm | 58 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 58 insertions(+) -- 2.31.1 ^ permalink raw reply [flat|nested] 10+ messages in thread
* [bug#50087] [PATCH 0/2] Add csvdiff 2021-08-17 5:47 [bug#50087] [PATCH 0/2] Add csvdiff BonfaceKilz @ 2021-08-17 5:50 ` BonfaceKilz 2021-08-17 5:50 ` [bug#50087] [PATCH 1/2] gn: Add go-github-com-oneofone-xxhash BonfaceKilz ` (2 more replies) 2021-08-17 20:00 ` Sarah Morgensen 1 sibling, 3 replies; 10+ messages in thread From: BonfaceKilz @ 2021-08-17 5:50 UTC (permalink / raw) To: 50087; +Cc: BonfaceKilz Hi all. This patch adds a fast csv diffing utility written in go-lang. BonfaceKilz (2): gn: Add go-github-com-oneofone-xxhash. gn: Add go-github-com-aswinkarthik-csvdiff. gnu/packages/golang.scm | 58 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 58 insertions(+) -- 2.31.1 ^ permalink raw reply [flat|nested] 10+ messages in thread
* [bug#50087] [PATCH 1/2] gn: Add go-github-com-oneofone-xxhash. 2021-08-17 5:50 ` BonfaceKilz @ 2021-08-17 5:50 ` BonfaceKilz 2021-08-17 5:50 ` [bug#50087] [PATCH 2/2] gn: Add go-github-com-aswinkarthik-csvdiff BonfaceKilz 2021-08-17 8:31 ` bug#50087: [PATCH 0/2] Add csvdiff Arun Isaac 2 siblings, 0 replies; 10+ messages in thread From: BonfaceKilz @ 2021-08-17 5:50 UTC (permalink / raw) To: 50087; +Cc: BonfaceKilz * gnu/packages/golang.scm (go-github-com-oneofone-xxhash): New variable. --- gnu/packages/golang.scm | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm index f4cd30c662..7cdd94b7f0 100644 --- a/gnu/packages/golang.scm +++ b/gnu/packages/golang.scm @@ -29,6 +29,7 @@ ;;; Copyright © 2021 Sarah Morgensen <iskarian@mgsn.dev> ;;; Copyright © 2021 Raghav Gururajan <rg@raghavgururajan.name> ;;; Copyright © 2021 jgart <jgart@dismail.de> +;;; Copyright © 2021 Bonface Munyoki Kilyungi <me@bonfacemunyoki.com> ;;; ;;; This file is part of GNU Guix. ;;; @@ -8396,3 +8397,27 @@ zero round-trip encryption, and other advanced features.") (synopsis "Go compression library") (description "@code{compress} provides various compression algorithms.") (license license:bsd-3))) + +(define-public go-github-com-oneofone-xxhash + (package + (name "go-github-com-oneofone-xxhash") + (version "1.2.8") + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/OneOfOne/xxhash") + (commit (string-append "v" version)))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "0f98qk83l2fhpclvrgyxsa9b8m4pipf11fah85bnjl01wy4lvybw")))) + (build-system go-build-system) + (arguments + '(#:import-path "github.com/OneOfOne/xxhash")) + (home-page "https://github.com/OneOfOne/xxhash") + (synopsis "Go implementation of xxhash") + (description "This is a native Go implementation of the +@url{https://github.com/Cyan4973/xxHash, xxhash} algorithm, an extremely fast +non-cryptographic Hash algorithm, working at speeds close to RAM limits.") + (license license:asl2.0))) -- 2.31.1 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [bug#50087] [PATCH 2/2] gn: Add go-github-com-aswinkarthik-csvdiff. 2021-08-17 5:50 ` BonfaceKilz 2021-08-17 5:50 ` [bug#50087] [PATCH 1/2] gn: Add go-github-com-oneofone-xxhash BonfaceKilz @ 2021-08-17 5:50 ` BonfaceKilz 2021-08-17 8:31 ` bug#50087: [PATCH 0/2] Add csvdiff Arun Isaac 2 siblings, 0 replies; 10+ messages in thread From: BonfaceKilz @ 2021-08-17 5:50 UTC (permalink / raw) To: 50087; +Cc: BonfaceKilz * gnu/packages/golang.scm (go-github-com-aswinkarthik-csvdiff): New variable. --- gnu/packages/golang.scm | 33 +++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+) diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm index 7cdd94b7f0..3de07478c6 100644 --- a/gnu/packages/golang.scm +++ b/gnu/packages/golang.scm @@ -8421,3 +8421,36 @@ zero round-trip encryption, and other advanced features.") @url{https://github.com/Cyan4973/xxHash, xxhash} algorithm, an extremely fast non-cryptographic Hash algorithm, working at speeds close to RAM limits.") (license license:asl2.0))) + +(define-public go-github-com-aswinkarthik-csvdiff + (package + (name "go-github-com-aswinkarthik-csvdiff") + (version "1.4.0") + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/aswinkarthik/csvdiff") + (commit (string-append "v" version)))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "0cd1ikxsypjqisfnmr7zix3g7x8p892w77086465chyd39gpk97b")))) + (build-system go-build-system) + (arguments + '(#:import-path "github.com/aswinkarthik/csvdiff")) + (propagated-inputs + `(("go-golang-org-x-sys" ,go-golang-org-x-sys) + ("go-github-com-stretchr-testify" ,go-github-com-stretchr-testify) + ("go-github-com-spf13-cobra" ,go-github-com-spf13-cobra) + ("go-github-com-spf13-afero" ,go-github-com-spf13-afero) + ("go-github-com-spaolacci-murmur3" ,go-github-com-spaolacci-murmur3) + ("go-github-com-mattn-go-colorable" ,go-github-com-mattn-go-colorable) + ("go-github-com-fatih-color" ,go-github-com-fatih-color) + ("go-github-com-cespare-xxhash" ,go-github-com-cespare-xxhash) + ("go-github-com-oneofone-xxhash" ,go-github-com-oneofone-xxhash))) + (home-page "https://github.com/aswinkarthik/csvdiff") + (synopsis "csvdiff") + (description + "This package provides a fast diff tool for comparing csv files.") + (license license:expat))) -- 2.31.1 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* bug#50087: [PATCH 0/2] Add csvdiff 2021-08-17 5:50 ` BonfaceKilz 2021-08-17 5:50 ` [bug#50087] [PATCH 1/2] gn: Add go-github-com-oneofone-xxhash BonfaceKilz 2021-08-17 5:50 ` [bug#50087] [PATCH 2/2] gn: Add go-github-com-aswinkarthik-csvdiff BonfaceKilz @ 2021-08-17 8:31 ` Arun Isaac 2021-08-17 17:02 ` [bug#50087] " Jack Hill 2 siblings, 1 reply; 10+ messages in thread From: Arun Isaac @ 2021-08-17 8:31 UTC (permalink / raw) To: BonfaceKilz; +Cc: 50087-done [-- Attachment #1: Type: text/plain, Size: 225 bytes --] Hi Bonface, Thanks for contributing to Guix! I pushed with the following few changes. 1. I replaced "gn" with "gnu" in the commit message. 2. I improved the synopsis and description of both the packages. Cheers! :-) Arun [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 524 bytes --] ^ permalink raw reply [flat|nested] 10+ messages in thread
* [bug#50087] [PATCH 0/2] Add csvdiff 2021-08-17 8:31 ` bug#50087: [PATCH 0/2] Add csvdiff Arun Isaac @ 2021-08-17 17:02 ` Jack Hill 2021-08-20 10:30 ` Arun Isaac 0 siblings, 1 reply; 10+ messages in thread From: Jack Hill @ 2021-08-17 17:02 UTC (permalink / raw) To: Arun Isaac; +Cc: BonfaceKilz, 50087-done On Tue, 17 Aug 2021, Arun Isaac wrote: > > Hi Bonface, > > Thanks for contributing to Guix! I pushed with the following few > changes. > > 1. I replaced "gn" with "gnu" in the commit message. > 2. I improved the synopsis and description of both the packages. > > Cheers! :-) > Arun Thanks to you both! I think I'll get a lot of use out of this package. Best! Jack ^ permalink raw reply [flat|nested] 10+ messages in thread
* [bug#50087] [PATCH 0/2] Add csvdiff 2021-08-17 17:02 ` [bug#50087] " Jack Hill @ 2021-08-20 10:30 ` Arun Isaac 0 siblings, 0 replies; 10+ messages in thread From: Arun Isaac @ 2021-08-20 10:30 UTC (permalink / raw) To: Jack Hill; +Cc: BonfaceKilz, 50087-done [-- Attachment #1: Type: text/plain, Size: 95 bytes --] > Thanks to you both! I think I'll get a lot of use out of this package. You're welcome! :-) [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 524 bytes --] ^ permalink raw reply [flat|nested] 10+ messages in thread
* [bug#50087] [PATCH 0/2] Add csvdiff 2021-08-17 5:47 [bug#50087] [PATCH 0/2] Add csvdiff BonfaceKilz 2021-08-17 5:50 ` BonfaceKilz @ 2021-08-17 20:00 ` Sarah Morgensen 2021-08-18 5:56 ` Arun Isaac 1 sibling, 1 reply; 10+ messages in thread From: Sarah Morgensen @ 2021-08-17 20:00 UTC (permalink / raw) To: Arun Isaac; +Cc: BonfaceKilz, 50087 Hello, On Tue, 17 Aug 2021, Arun Isaac wrote: > > Hi Bonface, > > Thanks for contributing to Guix! I pushed with the following few > changes. > > 1. I replaced "gn" with "gnu" in the commit message. > 2. I improved the synopsis and description of both the packages. > > Cheers! :-) > Arun Typically end-user Go packages will want inputs/native-inputs rather than propagated inputs unless the input provides a binary used at runtime, so user profiles are not cluttered (go-build-system needs source from all transitive dependencies). Also, a more friendly name ("csvdiff" is available) might be better for end-user packages like this. Apologies for not commenting sooner! -- Sarah ^ permalink raw reply [flat|nested] 10+ messages in thread
* [bug#50087] [PATCH 0/2] Add csvdiff 2021-08-17 20:00 ` Sarah Morgensen @ 2021-08-18 5:56 ` Arun Isaac 2021-08-19 7:23 ` Bonface Munyoki K. 0 siblings, 1 reply; 10+ messages in thread From: Arun Isaac @ 2021-08-18 5:56 UTC (permalink / raw) To: Sarah Morgensen, BonfaceKilz; +Cc: 50087 [-- Attachment #1: Type: text/plain, Size: 545 bytes --] Hi Sarah, > Typically end-user Go packages will want inputs/native-inputs rather > than propagated inputs unless the input provides a binary used at > runtime, so user profiles are not cluttered (go-build-system needs > source from all transitive dependencies). Also, a more friendly name > ("csvdiff" is available) might be better for end-user packages like > this. I agree. csvdiff being an end-user package, maybe we should also move it to some file other than golang.scm. @Bonface: Could you send patches to this effect? Regards, Arun [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 524 bytes --] ^ permalink raw reply [flat|nested] 10+ messages in thread
* [bug#50087] [PATCH 0/2] Add csvdiff 2021-08-18 5:56 ` Arun Isaac @ 2021-08-19 7:23 ` Bonface Munyoki K. 0 siblings, 0 replies; 10+ messages in thread From: Bonface Munyoki K. @ 2021-08-19 7:23 UTC (permalink / raw) To: Arun Isaac; +Cc: Sarah Morgensen, 50087 [-- Attachment #1: Type: text/plain, Size: 898 bytes --] Arun Isaac <arunisaac@systemreboot.net> anaandika: > Hi Sarah, > >> Typically end-user Go packages will want inputs/native-inputs rather >> than propagated inputs unless the input provides a binary used at >> runtime, so user profiles are not cluttered (go-build-system needs >> source from all transitive dependencies). Also, a more friendly name >> ("csvdiff" is available) might be better for end-user packages like >> this. > > I agree. csvdiff being an end-user package, maybe we should also move it > to some file other than golang.scm. > > @Bonface: Could you send patches to this effect? > > Regards, > Arun > Thanks for your feedback. Submitted patches in: bug#50117 -- Bonface M. K. D4F09EB110177E03C28E2FE1F5BBAE1E0392253F Free Software Activist Humble GNU Emacs User | Bearer of scheme-y parens Curator: <https://upbookclub.com> | Twitter: @BonfaceKilz [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 865 bytes --] ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2021-08-20 10:31 UTC | newest] Thread overview: 10+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2021-08-17 5:47 [bug#50087] [PATCH 0/2] Add csvdiff BonfaceKilz 2021-08-17 5:50 ` BonfaceKilz 2021-08-17 5:50 ` [bug#50087] [PATCH 1/2] gn: Add go-github-com-oneofone-xxhash BonfaceKilz 2021-08-17 5:50 ` [bug#50087] [PATCH 2/2] gn: Add go-github-com-aswinkarthik-csvdiff BonfaceKilz 2021-08-17 8:31 ` bug#50087: [PATCH 0/2] Add csvdiff Arun Isaac 2021-08-17 17:02 ` [bug#50087] " Jack Hill 2021-08-20 10:30 ` Arun Isaac 2021-08-17 20:00 ` Sarah Morgensen 2021-08-18 5:56 ` Arun Isaac 2021-08-19 7:23 ` Bonface Munyoki K.
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/guix.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).