From: "pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian.de>
To: phodina <phodina@protonmail.com>
Cc: 49934@debbugs.gnu.org, Vincent Legoll <vincent.legoll@gmail.com>
Subject: [bug#49934] [PATCH 1/3] gnu: Add libx86emu
Date: Mon, 9 Aug 2021 19:06:28 +0200 [thread overview]
Message-ID: <20210809170628.4yx45hvxcso6zgng@pelzflorian.localdomain> (raw)
In-Reply-To: <sgyM-_cPSQaNG4jL5qj3s3AKIfAfN8gA47DKsfVvvhsHEa8XEjHklHs1p_Gi0Q82a03fxMdBV0__C5GXREDuj7ILhYigp54kdj0b9TJ3_hs=@protonmail.com>
On Mon, Aug 09, 2021 at 12:00:00PM +0000, phodina wrote:
> Thanks. I didn't know there's a patch already. The aim of this one is to get the hwinfo and hw-prober to get the hardware details.
I think it is good to get your patch into shape and merged. While I
haven’t been involved in package review (shame on me), I’ll give it a
try.
You should, after applying each of your patches, cd to the guix repo
and run `./etc/indent-code.el gnu/packages/hardware.scm` as described
in `info '(guix)Formatting Code'`.
`./pre-inst-env guix lint libx86emu` warns that your custom check
phase does not consider #:tests? (i.e. it does not work with the
--without-tests transform option).
As for the package libx86emu proper:
> (define-public libx86emu
> (package
> (name "libx86emu")
> (version "3.1")
> (source (origin
> (method git-fetch)
> (uri (git-reference
> (url "https://github.com/wfeldt/libx86emu")
> (commit version)))
> (file-name (git-file-name name version))
> (sha256
> (base32
> "104xqc6nj9rpi7knl3dfqvasf087hlz2n5yndb1iycw35a6j509b"))))
> (build-system gnu-build-system)
> (arguments
> `(#:make-flags (list
> (string-append "CC=" ,(cc-for-target))
> (string-append "DESTDIR=" %output)
> (string-append "LIBDIR=/lib"))
> #:phases (modify-phases %standard-phases
> (delete 'configure)
> (add-after 'unpack 'fix-version-and-usr
> (lambda* (#:key inputs #:allow-other-keys)
> (delete-file "git2log")
I am not sure, would it be better to delete this git2log in an origin
snippet? I have not checked.
> (let* ((file (open-file "VERSION" "a")))
> (display ,version file)
> (close-port file))
> (substitute* "Makefile"
> (("/usr") "/"))))
> (replace 'check
> (lambda* _
> (invoke "make" "test"))))))
> (native-inputs `(("git" ,git) ("perl" ,perl) ("nasm" ,nasm)))
> (synopsis "Library for x86 emulation")
> (description "Small library to emulate x86 instructions. The focus here
> is not a complete emulation (go for qemu for this) but to cover enough for
> typical firmware blobs.
The start of the sentence is missing before @enumerate. “You can”?
> @enumerate
> @item intercept any memory access or directly map real memory ranges
> @item intercept any i/o access, map real i/o ports, or block any real i/o
> @item intercept any interrupt
> @item provides hook to run after each instruction
Either “provides a hook” or “provides hooks”.
> @item recognizes a special x86 instruction that can trigger logging
s/recognizes/recognize/
> @item has integrated logging
Maybe s/has/use/
> @end enumerate")
> (home-page "https://github.com/wfeldt/libx86emu")
> (license license:bsd-1)))
The license is not bsd-1 but x11-style, I think.
Regards,
Florian
next prev parent reply other threads:[~2021-08-09 17:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-07 21:58 [bug#49934] [PATCH 1/3] gnu: Add libx86emu phodina via Guix-patches via
2021-08-07 22:03 ` [bug#49934] Subject: [PATCH 2/3] gnu: Add hwinfo phodina via Guix-patches via
2021-08-07 22:05 ` [bug#49934] Subject: [PATCH 3/3] gnu: Add hw-probe phodina via Guix-patches via
2021-08-08 10:10 ` [bug#49934] [PATCH 1/3] gnu: Add libx86emu pelzflorian (Florian Pelz)
2021-08-09 12:00 ` phodina via Guix-patches via
2021-08-09 17:06 ` pelzflorian (Florian Pelz) [this message]
2021-08-30 21:34 ` [bug#49934] Hw-Probe Raghav Gururajan via Guix-patches via
2021-10-01 23:19 ` [bug#49934] [PATCH] gnu: Add hw-probe Raghav Gururajan via Guix-patches via
2021-10-02 9:58 ` Maxime Devos
2021-10-01 23:26 ` [bug#49934] HwInfo Raghav Gururajan via Guix-patches via
2021-12-09 11:51 ` [bug#49934] [PATCH v2] gnu: Add hw-probe Raghav Gururajan via Guix-patches via
2021-12-09 12:18 ` [bug#49934] [PATCH v3] " Raghav Gururajan via Guix-patches via
2021-12-16 5:53 ` [bug#49934] Hw-Probe Ricardo Wurmus
2021-12-25 21:17 ` Raghav Gururajan via Guix-patches via
2021-12-27 9:59 ` Efraim Flashner
2022-06-23 15:35 ` [bug#50283] HwInfo Maxim Cournoyer
2022-06-24 8:31 ` Raghav Gururajan via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210809170628.4yx45hvxcso6zgng@pelzflorian.localdomain \
--to=pelzflorian@pelzflorian.de \
--cc=49934@debbugs.gnu.org \
--cc=phodina@protonmail.com \
--cc=vincent.legoll@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).