From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id qzqJJi3XEGGbSAAAgWs5BA (envelope-from ) for ; Mon, 09 Aug 2021 09:20:13 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id ODqKIS3XEGG8VAAAB5/wlQ (envelope-from ) for ; Mon, 09 Aug 2021 07:20:13 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DC96218276 for ; Mon, 9 Aug 2021 09:20:12 +0200 (CEST) Received: from localhost ([::1]:36060 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mCzZz-0002yD-Ut for larch@yhetil.org; Mon, 09 Aug 2021 03:20:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:32936) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mCzZq-0002xt-3U for guix-patches@gnu.org; Mon, 09 Aug 2021 03:20:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:44038) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mCzZp-0004cW-S0 for guix-patches@gnu.org; Mon, 09 Aug 2021 03:20:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mCzZp-0004CU-NI for guix-patches@gnu.org; Mon, 09 Aug 2021 03:20:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49868] [PATCH v2 1/2] guix: dune-build-system: Add a profile parameter. Resent-From: pukkamustard Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 09 Aug 2021 07:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49868 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 49868@debbugs.gnu.org Cc: pukkamustard Received: via spool by 49868-submit@debbugs.gnu.org id=B49868.162849356516072 (code B ref 49868); Mon, 09 Aug 2021 07:20:01 +0000 Received: (at 49868) by debbugs.gnu.org; 9 Aug 2021 07:19:25 +0000 Received: from localhost ([127.0.0.1]:55581 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mCzZF-0004B9-Cv for submit@debbugs.gnu.org; Mon, 09 Aug 2021 03:19:25 -0400 Received: from mout02.posteo.de ([185.67.36.66]:54335) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mCzZE-0004At-4B for 49868@debbugs.gnu.org; Mon, 09 Aug 2021 03:19:24 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 2B43E240101 for <49868@debbugs.gnu.org>; Mon, 9 Aug 2021 09:19:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1628493558; bh=J+bjhMQJdTBbsly9wcidnGD5RGX3HHsrhGDbTwjqSd8=; h=From:To:Cc:Subject:Date:From; b=Sn06oiB4+ZqoqOcXdGiWZ856tKvKhyfnoXAKrRZz8+Nc7ZozCEVQvtwga9hqRWs/j Afm7gwvxwvqNBWTnL7zlyg/CQXYeYmS11tPB2b8hhjDg1x8HFJxGUJR7Q8IaYtuQX3 qPyco1NVImI9rh2FIITMn3TiM2bjr1wpdRInzMGJYnVLAFmEPEruD/c3loHoSSq+iL jqsFL+58tjjMDjYUraLonywUWYBQ+ZpqFTU4cnRfq75ode+Q9gvJgOAX5Rbr2/icb+ dofF+wFvP+MHrKp0Bp1smZm5uPsxMMkAQ9OF0gTx7L3T4EVVuIIA7tmF87QSAy2PFl yN5m2cu8y0iuQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4GjnWm6ng0z9rxR; Mon, 9 Aug 2021 09:19:16 +0200 (CEST) From: pukkamustard Date: Mon, 9 Aug 2021 07:19:03 +0000 Message-Id: <20210809071904.27334-1-pukkamustard@posteo.net> In-Reply-To: <20210804080423.3533-1-pukkamustard@posteo.net> References: <20210804080423.3533-1-pukkamustard@posteo.net> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1628493613; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=/RRpQxO394xiD7aWDL9xF6vl2N/bR08I4cL44UgF6xo=; b=NyEVpmDdDR488UPijAfyB94HfDy94Hc6YCqhPKZinxTTD7OZ4dA9BuHFpmLjQKu2jY/nqy E6KKXg3LmjR+gYUDQkrhOqiYscLMo/grdtJIYgbAbX9IF3QDenF+kS8D9DsvArRwSQ3n+G RqeAkBkZGaiNPqhlCyZXPtifMM+EJSToZbQpp0JjO7E7WYTaG0LqooBagadfnOBBpITr94 0FUybcJLX8bO1oFwSxh9RRIWVWGP3A+IgTb4+Mexu+vLkuZqFEAF6nmCUIuvp5u9++Zcao 8f1nGI3F3Nco36hmRrJCV13v3m5qmq2FkZVfPMr/707g0Syvb+xn9pR5zIebVQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1628493613; a=rsa-sha256; cv=none; b=R4L3kyaPVTCPz2gsaEEWjqG6C7unGXfM2h9ibigbWUwgYnSXQe7bsTn917YbwZlFy4jVaK GWJy3kAnDwhjjecKoA09OHjwfhywNW06fAS5rxa5rKNJGr5CPSC9E6Zbghhi0QZsjOKF0z ypA7pZ4OXaLgKtASKd0RHzWMJFNTCPcd+sH2bPnIZAxlhXbHDXsv7u7DiYgwsVHGlTYuDB 92thJXCunGUs3IfhqsbZaMsbu+NEK1rfsfAL5TC+FFf4s5QLixNoGdu0WrMnv90dnDJ6sS 9cPexn506BE9B/pb95YrxG+ysB2eIwRHl4OUtTKmP6MEgSyLSFb+kpKK37abnA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=Sn06oiB4; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -0.31 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=Sn06oiB4; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: DC96218276 X-Spam-Score: -0.31 X-Migadu-Scanner: scn0.migadu.com X-TUID: ZQjsj7gteeJy * guix/build-system/dune.scm: Add a profile parameter. * guix/build/dune-build-system.scm (build): Use it. * doc/guix.texi: Document it. * gnu/packages/ocaml.scm: Remove profile being set from build flags. --- doc/guix.texi | 7 +++++++ gnu/packages/ocaml.scm | 17 ++++++----------- guix/build-system/dune.scm | 3 +++ guix/build/dune-build-system.scm | 8 ++++++-- 4 files changed, 22 insertions(+), 13 deletions(-) diff --git a/doc/guix.texi b/doc/guix.texi index 9a9c85678c..15b0ed7534 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -94,6 +94,7 @@ Copyright @copyright{} 2021 Xinglu Chen@* Copyright @copyright{} 2021 Raghav Gururajan@* Copyright @copyright{} 2021 Domagoj Stolfa@* Copyright @copyright{} 2021 Hui Lu@* +Copyright @copyright{} 2021 pukkamustard@* Permission is granted to copy, distribute and/or modify this document under the terms of the GNU Free Documentation License, Version 1.3 or @@ -7731,6 +7732,12 @@ The @code{#:package} parameter can be passed to specify a package name, which is useful when a package contains multiple packages and you want to build only one of them. This is equivalent to passing the @code{-p} argument to @code{dune}. + +The @code{#:profile} parameter can be passed to specify the +@uref{https://dune.readthedocs.io/en/stable/dune-files.html#profile, +dune build profile}. This is equivalent to passing the @code{--profile} +argument to @code{dune}. Its default value is @code{"release"}. + @end defvr @defvr {Scheme Variable} go-build-system diff --git a/gnu/packages/ocaml.scm b/gnu/packages/ocaml.scm index bf9242410d..547b905317 100644 --- a/gnu/packages/ocaml.scm +++ b/gnu/packages/ocaml.scm @@ -2854,8 +2854,7 @@ without a complete in-memory representation of the data.") "1dvcl108ir9nqkk4mjm9xhhj4p9dx9bmg8bnms54fizs1x3x8ar3")))) (build-system dune-build-system) (arguments - `(#:test-target "tests" - #:build-flags (list "--profile=release"))) + `(#:test-target "tests")) (propagated-inputs `(("ocaml-cmdliner" ,ocaml-cmdliner))) (home-page "https://www.typerex.org/ocp-indent.html") @@ -3273,8 +3272,7 @@ build system and allows external tools to analyse your project easily.") "1smcc0l6fh2n0y6bp96c69j5nw755jja99w0b206wx3yb2m4w2hs")))) (build-system dune-build-system) (arguments - `(#:tests? #f - #:build-flags (list "--profile" "release"))) + `(#:tests? #f)) (native-inputs `(("ocamlbuild" ,ocamlbuild))) (home-page "https://github.com/mjambon/cppo") @@ -3342,8 +3340,7 @@ standard iterator type starting from 4.07.") (base32 "07ycb103mr4mrkxfd63cwlsn023xvcjp0ra0k7n2gwrg0mwxmfss")))) (build-system dune-build-system) (arguments - `(#:tests? #f - #:build-flags (list "--profile" "release"))) + `(#:tests? #f)) (propagated-inputs `(("ocaml-seq" ,ocaml-seq))) (native-inputs @@ -3820,9 +3817,8 @@ the plugins facilitate extensibility, and the frontends serve as entry points.") "0chn7ldqb3wyf95yhmsxxq65cif56smgz1mhhc7m0dpwmyq1k97h")))) (build-system dune-build-system) (arguments - `(#:build-flags (list "--profile" "release") - #:test-target "camomile-test" - #:tests? #f; Tests fail, see https://github.com/yoriyuki/Camomile/issues/82 + `(#:test-target "camomile-test" + #:tests? #f ; Tests fail, see https://github.com/yoriyuki/Camomile/issues/82 #:phases (modify-phases %standard-phases (add-before 'build 'fix-usr-share @@ -3913,8 +3909,7 @@ connect an engine to your inputs and rendering functions to get an editor.") (base32 "0zcjy6fvf0d3i2ssz96asl889n3r6bplyzk7xvb2s3dkxbgcisyy")))) (build-system dune-build-system) (arguments - `(#:build-flags (list "--profile" "release") - #:tests? #f + `(#:tests? #f #:ocaml ,ocaml-4.07 #:findlib ,ocaml4.07-findlib #:dune ,ocaml4.07-dune)) diff --git a/guix/build-system/dune.scm b/guix/build-system/dune.scm index 6a2f3d16de..1a64cf9b75 100644 --- a/guix/build-system/dune.scm +++ b/guix/build-system/dune.scm @@ -1,6 +1,7 @@ ;;; GNU Guix --- Functional package management for GNU ;;; Copyright © 2016, 2017, 2018 Julien Lepiller ;;; Copyright © 2017 Ben Woodcroft +;;; Copyright © 2021 pukkamustard ;;; ;;; This file is part of GNU Guix. ;;; @@ -88,6 +89,7 @@ (out-of-source? #t) (jbuild? #f) (package #f) + (profile "release") (tests? #t) (test-flags ''()) (test-target "test") @@ -127,6 +129,7 @@ provides a 'setup.ml' file as its build system." #:out-of-source? ,out-of-source? #:jbuild? ,jbuild? #:package ,package + #:profile ,profile #:tests? ,tests? #:test-target ,test-target #:install-target ,install-target diff --git a/guix/build/dune-build-system.scm b/guix/build/dune-build-system.scm index 7e2ec1e3e1..6a0c2593ac 100644 --- a/guix/build/dune-build-system.scm +++ b/guix/build/dune-build-system.scm @@ -1,6 +1,7 @@ ;;; GNU Guix --- Functional package management for GNU ;;; Copyright © 2018 Julien Lepiller ;;; Copyright © 2019 Gabriel Hondet +;;; Copyright © 2021 pukkamustard ;;; ;;; This file is part of GNU Guix. ;;; @@ -31,11 +32,14 @@ ;; Code: (define* (build #:key (build-flags '()) (jbuild? #f) - (use-make? #f) (package #f) #:allow-other-keys) + (use-make? #f) (package #f) + (profile "release") #:allow-other-keys) "Build the given package." (let ((program (if jbuild? "jbuilder" "dune"))) (apply invoke program "build" "@install" - (append (if package (list "-p" package) '()) build-flags))) + (append (if package (list "-p" package) '()) + `("--profile" ,profile) + build-flags))) #t) (define* (check #:key (test-flags '()) (test-target "test") tests? -- 2.32.0