* [bug#49183] [PATCH] gnu: ocaml-dose3: Fix tests.
@ 2021-06-23 8:52 Xinglu Chen
2021-06-23 11:09 ` pukkamustard
0 siblings, 1 reply; 3+ messages in thread
From: Xinglu Chen @ 2021-06-23 8:52 UTC (permalink / raw)
To: 49183
* gnu/packages/ocaml.scm (ocaml-dose3)[arguments]<#:phases>: Add phase to
patch tests script.
---
The test script was failing to run without this, which also caused
emacs-tuareg to not build.
No idea why one would use Python to test OCaml code...
gnu/packages/ocaml.scm | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/gnu/packages/ocaml.scm b/gnu/packages/ocaml.scm
index dd30f4cc97..1262c0e303 100644
--- a/gnu/packages/ocaml.scm
+++ b/gnu/packages/ocaml.scm
@@ -647,7 +647,14 @@ underlying solvers like Cplex, Gurobi, Lpsolver, Glpk, CbC, SCIP or WBO.")
#:make-flags
(list (string-append "LIBDIR="
(assoc-ref %outputs "out")
- "/lib/ocaml/site-lib"))))
+ "/lib/ocaml/site-lib"))
+ #:phases
+ (modify-phases %standard-phases
+ (add-after 'unpack 'fix-test-script
+ (lambda _
+ (substitute* "applications/dose-tests.py"
+ (("warning\\(")
+ "from warnings import warn\nwarn(")))))))
(propagated-inputs
`(("ocaml-graph" ,ocaml-graph)
("ocaml-cudf" ,ocaml-cudf)
base-commit: 4605ea1a780ff5889b7273d27a255294d7a08327
--
2.32.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [bug#49183] [PATCH] gnu: ocaml-dose3: Fix tests.
2021-06-23 8:52 [bug#49183] [PATCH] gnu: ocaml-dose3: Fix tests Xinglu Chen
@ 2021-06-23 11:09 ` pukkamustard
2021-06-23 12:45 ` bug#49183: " Julien Lepiller
0 siblings, 1 reply; 3+ messages in thread
From: pukkamustard @ 2021-06-23 11:09 UTC (permalink / raw)
To: Xinglu Chen; +Cc: 49171, 49183
Neat. Thanks!
Fixes the test and looks got to me.
> No idea why one would use Python to test OCaml code...
Yeah, makes one wonder. At least they've updated to Python3
(https://gitlab.com/irill/dose3/-/blob/master/CHANGES#L33)
recently.
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#49183: [PATCH] gnu: ocaml-dose3: Fix tests.
2021-06-23 11:09 ` pukkamustard
@ 2021-06-23 12:45 ` Julien Lepiller
0 siblings, 0 replies; 3+ messages in thread
From: Julien Lepiller @ 2021-06-23 12:45 UTC (permalink / raw)
To: pukkamustard; +Cc: 49183-done, 49171-done, Xinglu Chen
Le Wed, 23 Jun 2021 11:09:44 +0000,
pukkamustard <pukkamustard@posteo.net> a écrit :
> Neat. Thanks!
>
> Fixes the test and looks got to me.
>
> > No idea why one would use Python to test OCaml code...
>
> Yeah, makes one wonder. At least they've updated to Python3
> (https://gitlab.com/irill/dose3/-/blob/master/CHANGES#L33)
> recently.
>
>
>
Thanks! Pushed as 91b29aa37394b660117e1d79927621db1344b7fe.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-23 12:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-23 8:52 [bug#49183] [PATCH] gnu: ocaml-dose3: Fix tests Xinglu Chen
2021-06-23 11:09 ` pukkamustard
2021-06-23 12:45 ` bug#49183: " Julien Lepiller
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).