From: Julien Lepiller <julien@lepiller.eu>
To: Xinglu Chen <public@yoctocell.xyz>
Cc: 49101@debbugs.gnu.org
Subject: [bug#49101] [PATCH v2 2/5] gnu: ocaml4.07-expect: Switch to default OCaml compiler.
Date: Sat, 19 Jun 2021 13:05:28 +0200 [thread overview]
Message-ID: <20210619130528.41ef399e@tachikoma.lepiller.eu> (raw)
In-Reply-To: <5f41113189a8b9d4cff7f8eb41a42e4c99113118.1624093132.git.public@yoctocell.xyz>
Le Sat, 19 Jun 2021 11:03:41 +0200,
Xinglu Chen <public@yoctocell.xyz> a écrit :
> * gnu/packages/ocaml.scm (ocaml4.07-expect): Rename to ‘ocaml-expect’.
> [arguments]: Use default OCaml compiler.
> [native-inputs]: Use ‘ocaml-*’ packages instead of ‘ocaml4.07-*’.
> [propagated-inputs]: Likewise.
> [description]: Make it a full sentence.
> ---
> gnu/packages/ocaml.scm | 23 +++++++++++------------
> 1 file changed, 11 insertions(+), 12 deletions(-)
>
> diff --git a/gnu/packages/ocaml.scm b/gnu/packages/ocaml.scm
> index e02684fefd..c89908a1b2 100644
> --- a/gnu/packages/ocaml.scm
> +++ b/gnu/packages/ocaml.scm
> @@ -3118,9 +3118,9 @@ offered by the Perl language.")
> ;; With static linking exception
> (license license:lgpl2.1+)))
>
> -(define-public ocaml4.07-expect
> +(define-public ocaml-expect
> (package
> - (name "ocaml4.07-expect")
> + (name "ocaml-expect")
> (version "0.0.6")
> (source (origin
> (method url-fetch)
> @@ -3129,21 +3129,20 @@ offered by the Perl language.")
> (base32
> "098qvg9d4yrqzr5ax291y3whrpax0m3sx4gi6is0mblc96r9yqk0"))))
> (arguments
> - `(#:tests? #f
> - #:ocaml ,ocaml-4.07
> - #:findlib ,ocaml4.07-findlib))
> + `(#:tests? #f))
> (build-system ocaml-build-system)
> (native-inputs
> - `(("ocamlbuild" ,(package-with-ocaml4.07 ocamlbuild))
> - ("ocaml-num" ,(package-with-ocaml4.07 ocaml-num))
> - ("ocaml-pcre" ,ocaml4.07-pcre)
> - ("ounit" ,(package-with-ocaml4.07 ocaml-ounit))))
> + `(("ocamlbuild" ,ocamlbuild)
> + ("ocaml-num" ,ocaml-num)
> + ("ocaml-pcre" ,ocaml-pcre)
> + ("ounit" ,ocaml-ounit)))
> (propagated-inputs
> - `(("batteries" ,(package-with-ocaml4.07 ocaml-batteries))))
> + `(("batteries" ,ocaml-batteries)))
> (home-page "https://forge.ocamlcore.org/projects/ocaml-expect/")
> (synopsis "Simple implementation of expect")
> - (description "Help building unitary testing of interactive
> program. You -can match the question using a regular expression or a
> timeout.")
> + (description "This package provides utilities for building
> unitary testing +of interactive program. You can match the question
> using a regular expression +or a timeout.")
> (license license:lgpl2.1+))) ; with the OCaml static compilation
> exception
> (define-public ocaml-stdlib-shims
This patch looks good, but I think it needs to be merged with the
previous one, because after the first patch and before this one,
ocaml4.07-pcre doesn't exist. Remember that we want to make sure we can
build guix at every point in time.
The rest of the series is good. I'm looking forward to v3 :)
next prev parent reply other threads:[~2021-06-19 11:06 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-18 19:00 [bug#49101] [PATCH 0/4] Add ocaml-mparser & friends Xinglu Chen
2021-06-18 19:03 ` [bug#49101] [PATCH 1/4] gnu: Add ocaml-mparser Xinglu Chen
2021-06-18 19:03 ` [bug#49101] [PATCH 3/4] gnu: Add ocaml-mparser-pcre Xinglu Chen
2021-06-18 19:03 ` [bug#49101] [PATCH 4/4] gnu: Add ocaml-pcre Xinglu Chen
2021-06-18 19:03 ` [bug#49101] [PATCH 2/4] gnu: Add ocaml-mparser-re Xinglu Chen
2021-06-18 22:28 ` [bug#49101] [PATCH 0/4] Add ocaml-mparser & friends Julien Lepiller
2021-06-19 8:35 ` Xinglu Chen
2021-06-19 9:03 ` [bug#49101] [PATCH v2 0/5] Add ocaml-mparser & firends Xinglu Chen
2021-06-19 9:03 ` [bug#49101] [PATCH v2 1/5] gnu: ocaml4.07-pcre: Switch to default OCaml compiler Xinglu Chen
2021-06-19 11:01 ` Julien Lepiller
2021-06-19 13:51 ` Xinglu Chen
2021-06-19 9:03 ` [bug#49101] [PATCH v2 2/5] gnu: ocaml4.07-expect: " Xinglu Chen
2021-06-19 11:05 ` Julien Lepiller [this message]
2021-06-19 13:57 ` Xinglu Chen
2021-06-19 14:06 ` Xinglu Chen
2021-06-19 15:09 ` Julien Lepiller
2021-06-19 9:03 ` [bug#49101] [PATCH v2 3/5] gnu: Add ocaml-mparser Xinglu Chen
2021-06-19 9:03 ` [bug#49101] [PATCH v2 4/5] gnu: Add ocaml-mparser-re Xinglu Chen
2021-06-19 9:03 ` [bug#49101] [PATCH v2 5/5] gnu: Add ocaml-mparser-pcre Xinglu Chen
2021-06-19 15:50 ` [bug#49101] [PATCH v3 0/6] Add ocaml-mparser & friends Xinglu Chen
2021-06-19 15:50 ` [bug#49101] [PATCH v3 1/6] gnu: Add ocaml-pcre Xinglu Chen
2021-06-19 15:50 ` [bug#49101] [PATCH v3 2/6] gnu: ocaml4.07-expect: Switch to default OCaml compiler Xinglu Chen
2021-06-19 15:50 ` [bug#49101] [PATCH v3 3/6] gnu: ocaml4.07-pcre: Remove package Xinglu Chen
2021-06-19 15:50 ` [bug#49101] [PATCH v3 4/6] gnu: Add ocaml-mparser Xinglu Chen
2021-06-19 15:50 ` [bug#49101] [PATCH v3 5/6] gnu: Add ocaml-mparser-re Xinglu Chen
2021-06-19 15:50 ` [bug#49101] [PATCH v3 6/6] gnu: Add ocaml-mparser-pcre Xinglu Chen
2021-06-20 0:16 ` bug#49101: [PATCH v3 0/6] Add ocaml-mparser & friends Julien Lepiller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210619130528.41ef399e@tachikoma.lepiller.eu \
--to=julien@lepiller.eu \
--cc=49101@debbugs.gnu.org \
--cc=public@yoctocell.xyz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).