From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id ANv0LzUezWBx/QAAgWs5BA (envelope-from ) for ; Sat, 19 Jun 2021 00:29:09 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id IJZpKzUezWA5KwAA1q6Kng (envelope-from ) for ; Fri, 18 Jun 2021 22:29:09 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1D39122805 for ; Sat, 19 Jun 2021 00:29:09 +0200 (CEST) Received: from localhost ([::1]:41910 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1luMz5-0003zx-TD for larch@yhetil.org; Fri, 18 Jun 2021 18:29:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56300) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1luMz0-0003zp-2Y for guix-patches@gnu.org; Fri, 18 Jun 2021 18:29:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:46784) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1luMyz-00078d-RU for guix-patches@gnu.org; Fri, 18 Jun 2021 18:29:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1luMyz-0006ts-KE for guix-patches@gnu.org; Fri, 18 Jun 2021 18:29:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49101] [PATCH 0/4] Add ocaml-mparser & friends Resent-From: Julien Lepiller Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 18 Jun 2021 22:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49101 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Xinglu Chen Cc: 49101@debbugs.gnu.org Received: via spool by 49101-submit@debbugs.gnu.org id=B49101.162405533926516 (code B ref 49101); Fri, 18 Jun 2021 22:29:01 +0000 Received: (at 49101) by debbugs.gnu.org; 18 Jun 2021 22:28:59 +0000 Received: from localhost ([127.0.0.1]:58330 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1luMyx-0006tb-4a for submit@debbugs.gnu.org; Fri, 18 Jun 2021 18:28:59 -0400 Received: from lepiller.eu ([89.234.186.109]:45136) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1luMyu-0006tS-Ok for 49101@debbugs.gnu.org; Fri, 18 Jun 2021 18:28:57 -0400 Received: from lepiller.eu (localhost [127.0.0.1]) by lepiller.eu (OpenSMTPD) with ESMTP id 0905240b; Fri, 18 Jun 2021 22:28:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lepiller.eu; h=date:from :to:cc:subject:message-id:in-reply-to:references:mime-version :content-type:content-transfer-encoding; s=dkim; bh=YPCT632bvFgI +ckCMFlEUb8PFxq8S/aB1oUVpsGiVrA=; b=mZNfh/lxITnOVaXHVrJGuYveRoJz 3Pb8a5vm8JYeYn5C3UXsRayeF5H6wx0SogW7c2p/yWAJFeGq7lkuZdtxN9Vszdbg y/Jm4WGYbtgjuWpZjs1PaVmdrKhiLQbbvmcgTunxxvLPTRrxMFwidUmlDYQTTqFB qkOWScvBLGT3jNGyqKd0vn9Vr/JYxfItj5Gumx99w9txvLl8MuFc6ydk3RZYEKZ6 xc5nJPYXYoSnbc8ZbeSSCtsw/fxh5NlyZVhpCKLSxGNrUunw9M9QWJKki841mwZ1 VNVr4d63UbUpYGm/SwPDF8d+dL0inGJkOB2onHaCOp/C+xg0HLeQ0NoBuw== Received: by lepiller.eu (OpenSMTPD) with ESMTPSA id e5c901a6 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Fri, 18 Jun 2021 22:28:54 +0000 (UTC) Date: Sat, 19 Jun 2021 00:28:51 +0200 From: Julien Lepiller Message-ID: <20210619002851.732e3f59@tachikoma.lepiller.eu> In-Reply-To: References: X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1624055349; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=01M33pWqNXqN316ul1CBp2i6vX1CDIJ+hGvjRCeN6F8=; b=Sv6gGEIiUT0uPPiT+QkFTcMvdpt92I9ENbxCZhrGSJ8Cj9rbKUmchv/eH6Sl1JYz9FIGiD djRCaA4g6rmm1SFgjyWRjSdeq+bAdQcsNKrwz8MpUgFybnri00rjjrnTp+1PlE6Knh/UkQ wWOYjFEco1pAF89VAK+SUb5bz56X5TwFygVcAw7JvaNCZU88+1sNtX0X7R4t9731BeT31k 0eYEJ45Ft3wtdwcmy9fhe82ns9h5UttT4vSfONE8J+tW7Zc/EZu0riDt9A+6UVP6noQeJC yaVXV9fo6Hzm5NGhrjFuvtqlGnrnvPjt4SFh8R2WEWW62CyTbabY8sZFvwfGHw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1624055349; a=rsa-sha256; cv=none; b=IVjF4smv3F55wYSGx8cERWwB/ccBeyXE6YpdL5OOerfdge20ftZsMw58p5+rjQfOMMfV6N KIY2rv1tJlCr3WapWpp5u2Oh65OUAHkMZR5NkRNMM3b89aBhTQuvMSjNfAALiL39x57p2X anIMH+SC1HTYMfWXncTfd3Vx7be6dIbflJkR/BHIZEMw83a0DrES0j6R/krouGV5IKET5e zEEDqsTauNKN7oPCySF8w8p2ZiKnXep8yxDzIljn1A6/TnnqvSApdppk9hjz8MJm+CPp6L xd8UlKk36ToOje7rPTTKK2SX9ILGgowlKaQnAXtnqfpwyUQGcSfa5yNbRVoRqA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lepiller.eu header.s=dkim header.b="mZNfh/lx"; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: 0.18 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lepiller.eu header.s=dkim header.b="mZNfh/lx"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=lepiller.eu (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 1D39122805 X-Spam-Score: 0.18 X-Migadu-Scanner: scn0.migadu.com X-TUID: lYQU22Ncy+Ge Le Fri, 18 Jun 2021 21:00:51 +0200, Xinglu Chen a =C3=A9crit : > This series adds =E2=80=98ocaml-mparser=E2=80=99, a monad parser combinat= or library, > plus two extensions for it --- =E2=80=98ocaml-mparser-re=E2=80=99 and > =E2=80=98ocaml-mparser-pcre=E2=80=99. >=20 > I noticed that there already exists an =E2=80=98ocaml4.07-pcre=E2=80=99 p= ackage, what > is the policy regarding =E2=80=98ocaml4.07-*=E2=80=99 and =E2=80=98ocaml-= *=E2=80=99 packages? >=20 > Xinglu Chen (4): > gnu: Add ocaml-mparser. > gnu: Add ocaml-mparser-re. > gnu: Add ocaml-mparser-pcre. > gnu: Add ocaml-pcre. >=20 > gnu/packages/ocaml.scm | 88 > ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 88 > insertions(+) >=20 >=20 > base-commit: caf4a7a2770ef4d05a6e18f40d602e51da749ddc Hi Xinglu, thank you for the patches! First, you should reorder your patches: we try to make sure every revision of guix is correct, but after the third patch, ocaml-pcre is missing. I would simply put pcre first :). To answer your question, we try to avoid having both the ocaml and ocaml4.07 around if possible. It seems that ocaml4.07-pcre is only required for ocaml4.07-expect. Could you check if it is possible to build expect with our latest ocaml package? If so, please have a patch that builds pcre and expect with the latest ocaml, then another patch for updating pcre to the latest version, then your three patches to add mparser. If not, then we have to keep ocaml4.07-pcre around, so here is how we do it, in a single patch: Replace ocaml4.07-pcre with ocaml-pcre (remove the arguments that use ocaml-4.07) and create a new ocaml4.07-pcre that inherits from it. It would look like this: (define-public ocaml-pcre (package (name "ocaml-pcre") ... (properties `((ocaml4.07-variant ,(delay ocaml4.07-pcre)))) ...)) (define-public ocaml4.07-pcre (package-with-ocaml4.07 (package (inherit ocaml-pcre) ... (properties '())))) If the latest version of pcre cannot be built with ocaml 4.07, you can specify a different source, like we do for ocaml4.07-parsexp for instance. I'm looking forward to v2 of this series :)