unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian.de>
To: Luis Felipe <luis.felipe.la@protonmail.com>
Cc: "48637@debbugs.gnu.org" <48637@debbugs.gnu.org>
Subject: [bug#48637] [PATCH] website: Add publications page
Date: Tue, 25 May 2021 20:21:23 +0200	[thread overview]
Message-ID: <20210525182123.a5l4d6t3xt3qn437@pelzflorian.localdomain> (raw)
In-Reply-To: <3mZyc8pra0TLSyJS6RlWIrQGBnje7dT_EMRBeOdFC_Z2wsZGoaI1rVNVtoiI57KEOvolEiahl6j7M4UBsoO0NsuieAfDPIkZQ-MR8C5UhAE=@protonmail.com>

On Tue, May 25, 2021 at 02:37:03PM +0000, Luis Felipe wrote:
> Yeah. Would it as follows? (I still struggle with i18n):
> 
> (p
>  (@ (class "publication-info"))
>  ,(G_ `("Published "
>         ,(date->string (publication-date publication)
>                        (C_ "SRFI-19 date->string format" "~b ~d, ~Y"))
>         " by "
>         ,(string-join (publication-authors publication) ", "))))

It would need to be

(p
 (@ (class "publication-info"))
 ,(let ((format (C_ "SRFI-19 date->string format" "~b ~d, ~Y")))
    (G_ `("Published "
          ,(date->string (publication-date publication) format)
          " by "
          ,(string-join (publication-authors publication) ", ")
          ""))))

The let is needed because C_ cannot be nested inside G_ because the
sexp-xgettext script parses Scheme files in only one pass currently.
(And I’m not motivated enough to make it go back to parse the nested
C_ because nesting is seldom needed.)

The "" at the end is needed so (string-join …) gets its own XML
element that can be moved by translators.

Without "":

msgid "Published <1/> by "

With "":

msgid "Published <1/> by <2/>"



> Also, I think the delimiter for "string-join" in the list of authors
> should be translated because that comma is not used in Japanese, for
> example. So would it be ok like this:
> […]
>         ,(string-join (publication-authors publication)
>                       (C_ "Separator of items in a list" ", ")))))

Yes, you are very right, although as above please move it to the let.
Then it can become 、 or と or whatever; I don’t know what is common
in Japan.


> I'm still unsure about when I should use a context and when a
> TRANSLATORS comment...

A msgctxt should be used if another ", " string with different
translations might be added.  I would use a context, I think, but
maybe it is an abundance of caution.

Regards,
Florian




  reply	other threads:[~2021-05-25 18:22 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-24 23:35 [bug#48637] [PATCH] website: Add publications page Luis Felipe via Guix-patches via
2021-05-25 13:44 ` pelzflorian (Florian Pelz)
2021-05-25 14:37   ` Luis Felipe via Guix-patches via
2021-05-25 18:21     ` pelzflorian (Florian Pelz) [this message]
2021-05-25 19:46       ` Luis Felipe via Guix-patches via
2021-05-25 19:58         ` Julien Lepiller
2021-05-25 20:16           ` Luis Felipe via Guix-patches via
2021-05-26  2:03             ` Julien Lepiller
2021-05-26 10:00               ` pelzflorian (Florian Pelz)
2021-05-26 14:06                 ` Luis Felipe via Guix-patches via
2021-05-26 17:41                   ` Julien Lepiller
2021-05-26 18:25                     ` Luis Felipe via Guix-patches via
2021-05-26 18:42                       ` Julien Lepiller
2021-05-26 19:05                         ` Luis Felipe via Guix-patches via
2021-05-25 18:35     ` pelzflorian (Florian Pelz)
2021-05-25 19:14       ` Luis Felipe via Guix-patches via
2021-05-28 11:06 ` Ludovic Courtès
2021-05-28 15:20   ` Luis Felipe via Guix-patches via
2021-05-29 10:25     ` Ludovic Courtès
2021-06-02 19:31   ` Luis Felipe via Guix-patches via
2021-06-02 20:28     ` Julien Lepiller
2021-06-02 21:52       ` Luis Felipe via Guix-patches via
2021-06-02 23:28         ` Julien Lepiller
2021-06-03  9:40     ` Ludovic Courtès
2021-06-03 10:37       ` Julien Lepiller
2021-06-03 13:39         ` Luis Felipe via Guix-patches via
2021-06-03 19:50           ` Luis Felipe via Guix-patches via
2021-06-03 20:37           ` Ludovic Courtès
2021-06-03 21:50             ` Luis Felipe via Guix-patches via
2021-06-04 15:38               ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210525182123.a5l4d6t3xt3qn437@pelzflorian.localdomain \
    --to=pelzflorian@pelzflorian.de \
    --cc=48637@debbugs.gnu.org \
    --cc=luis.felipe.la@protonmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).