unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Björn Höfling" <bjoern.hoefling@bjoernhoefling.de>
To: Vinicius Monego <monego@posteo.net>
Cc: 48614@debbugs.gnu.org
Subject: [bug#48614] [PATCH 3/3] gnu: Add python-cartopy.
Date: Tue, 25 May 2021 01:11:45 +0200	[thread overview]
Message-ID: <20210525011145.0a70f8ff@alma-ubu.fritz.box> (raw)
In-Reply-To: <20210523193134.425937-3-monego@posteo.net>

[-- Attachment #1: Type: text/plain, Size: 726 bytes --]

Hi Vinicius,

thanks for your contribution. this patch series looks good, except of
some little requarks:

- I would prefer to add python-cartopy and python-pyshp to geo.scm, as
to have all Geo/Cartographic packages there. Or is there a reason to
have it in python-xyz.scm? WDYT?

- If you move it, add a copyright line for you.

On Sun, 23 May 2021 19:31:33 +0000
Vinicius Monego <monego@posteo.net> wrote:

> * gnu/packages/python-science.scm (python-cartopy): New variable.

> +(define-public python-cartopy
> +  (package
> +    (name "python-cartopy")
> +    (version "0.19.0.post1")

Is this a pre-release/beta? Ah, no: It's a POST-release fix. Maybe add
a comment to explain?

Thanks,

Björn

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

  reply	other threads:[~2021-05-24 23:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-23 19:29 [bug#48614] [PATCH 0/3] gnu: Add python-cartopy Vinicius Monego
2021-05-23 19:31 ` [bug#48614] [PATCH 1/3] gnu: Add python-pyshp Vinicius Monego
2021-05-23 19:31   ` [bug#48614] [PATCH 2/3] gnu: Add python-pykdtree Vinicius Monego
2021-05-23 19:31   ` [bug#48614] [PATCH 3/3] gnu: Add python-cartopy Vinicius Monego
2021-05-24 23:11     ` Björn Höfling [this message]
2021-05-26 18:00       ` Vinicius Monego
2021-06-23  4:53         ` bug#48614: " Björn Höfling
2021-06-23 10:06           ` [bug#48614] " Vinicius Monego

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210525011145.0a70f8ff@alma-ubu.fritz.box \
    --to=bjoern.hoefling@bjoernhoefling.de \
    --cc=48614@debbugs.gnu.org \
    --cc=monego@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).