From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id UCRjKLiPmmC2pgAAgWs5BA (envelope-from ) for ; Tue, 11 May 2021 16:07:52 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 8OD2I7iPmmByIQAAbx9fmQ (envelope-from ) for ; Tue, 11 May 2021 14:07:52 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5C63CB296 for ; Tue, 11 May 2021 16:07:52 +0200 (CEST) Received: from localhost ([::1]:45070 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lgT39-0007WV-Ce for larch@yhetil.org; Tue, 11 May 2021 10:07:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40274) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lgT1P-0004as-6d for guix-patches@gnu.org; Tue, 11 May 2021 10:06:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:53671) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lgT1O-0007Ou-U2 for guix-patches@gnu.org; Tue, 11 May 2021 10:06:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lgT1O-000654-Oc for guix-patches@gnu.org; Tue, 11 May 2021 10:06:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#45692] [PATCH v3 2/3] gnu: Add zfs-auto-snapshot. Resent-From: Danny Milosavljevic Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 11 May 2021 14:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45692 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: raid5atemyhomework Cc: "45692@debbugs.gnu.org" <45692@debbugs.gnu.org> Received: via spool by 45692-submit@debbugs.gnu.org id=B45692.162074194723338 (code B ref 45692); Tue, 11 May 2021 14:06:02 +0000 Received: (at 45692) by debbugs.gnu.org; 11 May 2021 14:05:47 +0000 Received: from localhost ([127.0.0.1]:36982 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lgT19-00064M-KP for submit@debbugs.gnu.org; Tue, 11 May 2021 10:05:47 -0400 Received: from dd26836.kasserver.com ([85.13.145.193]:35430) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lgT18-000649-Lx for 45692@debbugs.gnu.org; Tue, 11 May 2021 10:05:47 -0400 Received: from localhost (80-110-127-104.cgn.dynamic.surfer.at [80.110.127.104]) by dd26836.kasserver.com (Postfix) with ESMTPSA id 0C3493362D7F; Tue, 11 May 2021 16:05:44 +0200 (CEST) Date: Tue, 11 May 2021 16:05:42 +0200 From: Danny Milosavljevic Message-ID: <20210511160434.6b88bba3@scratchpost.org> In-Reply-To: <2c97vRukDGd4mnnPwPzLZOBq6qR5EqiBvaevyGcaoh1zc8NQkJO8y2DvtaMuafb6R9m5_Hhizx41nJjyggYPiHNXmnYKkQCejKsw_n1-wec=@protonmail.com> References: <2c97vRukDGd4mnnPwPzLZOBq6qR5EqiBvaevyGcaoh1zc8NQkJO8y2DvtaMuafb6R9m5_Hhizx41nJjyggYPiHNXmnYKkQCejKsw_n1-wec=@protonmail.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1620742072; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=AA4GNoTtKfe0t+WFYRfoao09FXe556qW6wDQdgH0fpo=; b=lzpQuQUVyPaBgI+Jay6OkIaFA2bmr5jpohub3EvieHlHaK771YCLlIjvJk6lc4c34ni3wt KOIQ8J/YC4g9n4En+Jq0ZS67dsWjMw7ZEAxwsJ/ssq/yooZQU4sUHdBO23KX5Bki42lZVX NCpkbZCCit7DWzqeaFdH61RSuI3sH0iZwnzAQKC06XxyJxb05QOu4S9WPnKRRb+SRe4H4v qUlKKF2f+RcJH130hIiG4Lhfz8uJwAaF/7hBaw42pDhIU353dDroaAZj7e6WE1TG6cShHk lHqJ8xheW4elhMvgAhEUj8A6V+R5PNYScDXnKcFnifPWc23N/6Mxb/Cqy8cliQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1620742072; a=rsa-sha256; cv=none; b=QasJmzdDjv0OUvCnI6LAUNaPxmN8mPC4TP2Z3Rt55cqz36WM5DQ6oHpOIyVMP/GCqGt21J aJDKMaYXToxmPv7cSG3XQUMXnUNoP5xNvQpNnO1IKK8+Z/1Opk5BmMxQ12fpOEaLyfStmj btOA0fwuAelX8eV6XvmzgV822a+psM96pbTBAoTzQkyBXbXXCYBJ52l82cTdY5p8lknMC+ Rt5KAID1AZ9txJ94XMn5MDlbqiqXWI3w0vAwm/IXs5P4Iy7rjycCZs5C/dVXi21fv2eaYX ryRatd6A6Z4sPHiqn5F/MwaBfqYbK7V5Ry4RDsiyltol5cydk1meJRvcaM8F2w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -2.45 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 5C63CB296 X-Spam-Score: -2.45 X-Migadu-Scanner: scn0.migadu.com X-TUID: LnLk6H0lvw2h Hi, > + (invoke "make" "install" > + "PREFIX=" > + (string-append "DESTDIR=" out))) Are you sure about that? Usually, DESTDIR is in order to supply a temporary build root (which will not be referred-to by the installed programs--because that directory will be deleted after the build) and PREFIX is in order to supply an actual installation directory (installed programs can refer to that whenever they want). Is it different for this program? Also, I'd suggest to use #:make-flags so other phases can also see the PREFIX chosen. Otherwise, those could erroneously default to another prefix (for loading of config files at runtime etc). What do you think?