From: Tobias Geerinckx-Rice via Guix-patches via <guix-patches@gnu.org>
To: 48230@debbugs.gnu.org
Cc: francois.joulaud@radiofrance.com, maxim.cournoyer@gmail.com
Subject: [bug#48230] [PATCH] tests: go: Rename and fix duplicate test.
Date: Tue, 4 May 2021 22:55:48 +0200 [thread overview]
Message-ID: <20210504205548.4232-1-me@tobias.gr> (raw)
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=UTF-8, Size: 1156 bytes --]
* tests/go.scm: Rename "go-version omited 'v' character" to
"go-version without 'v' prefix" and change the code to match.
---
Hi all,
Found on a typo hunt.
This is my best-effort guess at what was intended. Maybe I'm mistaken: is GO-VERSION->GIT-REF supposed to normalise "1.0.2" to "v1.0.2" instead? Let me know!
Kind regards,
T G-R
tests/go.scm | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/tests/go.scm b/tests/go.scm
index c33a834f69..565a0d451d 100644
--- a/tests/go.scm
+++ b/tests/go.scm
@@ -1,5 +1,6 @@
;;; GNU Guix --- Functional package management for GNU
;;; Copyright © 2021 François Joulaud <francois.joulaud@radiofrance.com>
+;;; Copyright © 2021 Tobias Geerinckx-Rice <me@tobias.gr>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -158,9 +159,9 @@ require github.com/kr/pretty v0.2.1
"v1.0.2"
(go-version->git-ref "v1.0.2"))
-(test-equal "go-version omited 'v' character"
- "v1.0.2"
- (go-version->git-ref "v1.0.2"))
+(test-equal "go-version without 'v' prefix"
+ "1.0.2"
+ (go-version->git-ref "1.0.2"))
(test-equal "go-version with embedded git-ref"
"65e3620a7ae7"
--
2.31.1
next reply other threads:[~2021-05-04 20:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-04 20:55 Tobias Geerinckx-Rice via Guix-patches via [this message]
2021-05-05 5:03 ` bug#48230: [PATCH] tests: go: Rename and fix duplicate test Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210504205548.4232-1-me@tobias.gr \
--to=guix-patches@gnu.org \
--cc=48230@debbugs.gnu.org \
--cc=francois.joulaud@radiofrance.com \
--cc=maxim.cournoyer@gmail.com \
--cc=me@tobias.gr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).