unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian.de>
To: Luis Felipe <luis.felipe.la@protonmail.com>
Cc: 48187@debbugs.gnu.org
Subject: [bug#48187] [PATCH] website: help: Add Guix's latest manual
Date: Mon, 3 May 2021 17:37:24 +0200	[thread overview]
Message-ID: <20210503153724.74z2kuwyajusqguo@pelzflorian.localdomain> (raw)
In-Reply-To: <8UmQnlT6MS9cVKGVfsf7WZLqOi0-EbqzUNPUDKxOhYgbUbgfWqiwnWHqyeLWZSScRW913J8ecUCUBy-_WBrT0wD9vExrDMudtn4ZrQU-XQo=@protonmail.com>

Thank you for this patch, Luis!

On Mon, May 03, 2021 at 02:07:12PM +0000, Luis Felipe via Guix-patches via wrote:
> --- a/website/apps/base/templates/help.scm
> +++ b/website/apps/base/templates/help.scm
> @@ -43,14 +43,14 @@ system|GNU Hurd|GNU Guix package manager|Help resources") #\|)
>  	(img
>  	 (@ (src ,(guix-url "static/base/img/manual-icon.png"))
>  	    (alt "")))
> -        ,(G_ `(h3 "GNU Guix Manual"))
> +        ,(G_ `(h3 "GNU Guix Manual" " " ,(latest-guix-version)))

This leads to a translatable msgid in po/guix-website.po like this:

#: apps/base/templates/help.scm:46
#, xml-text
msgid "GNU Guix Manual "
msgstr ""

Please change the ordering and strings to

,(G_ `(h3 "GNU Guix Manual " ,(latest-guix-version) ""))

This makes for a translatable string

#: apps/base/templates/help.scm:46
#, xml-text
msgid "GNU Guix Manual <1/>"
msgstr ""

Otherwise LGTM.  

Regards,
Florian




  parent reply	other threads:[~2021-05-03 15:38 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-03 14:07 [bug#48187] [PATCH] website: help: Add Guix's latest manual Luis Felipe via Guix-patches via
2021-05-03 15:15 ` Julien Lepiller
2021-05-03 15:43   ` Luis Felipe via Guix-patches via
2021-05-03 15:37 ` pelzflorian (Florian Pelz) [this message]
2021-05-03 16:27   ` Luis Felipe via Guix-patches via
2021-05-03 22:25     ` Julien Lepiller
2021-05-04  6:05     ` pelzflorian (Florian Pelz)
2021-05-04  6:37       ` pelzflorian (Florian Pelz)
2021-05-04 13:25         ` pelzflorian (Florian Pelz)
2021-05-04 14:00           ` Luis Felipe via Guix-patches via
2021-05-04 14:33             ` bug#48187: " pelzflorian (Florian Pelz)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210503153724.74z2kuwyajusqguo@pelzflorian.localdomain \
    --to=pelzflorian@pelzflorian.de \
    --cc=48187@debbugs.gnu.org \
    --cc=luis.felipe.la@protonmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).