* gnu/packages/video.scm (libmediainfo)[arguments]: Add configure-flags. --- gnu/packages/video.scm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm index 481ab46b6e..1052351357 100644 --- a/gnu/packages/video.scm +++ b/gnu/packages/video.scm @@ -3834,6 +3834,8 @@ practically any type of media.") (build-system gnu-build-system) (arguments '(#:tests? #f ; see above TODO + #:configure-flags + (list "--with-libcurl" "--with-libtinyxml2") #:phases ;; build scripts not in root of archive (modify-phases %standard-phases -- 2.31.1
Hi,
Michael Rohleder <mike@rohleder.de> skribis:
> * gnu/packages/video.scm (libmediainfo)[arguments]: Add configure-flags.
Applied, thanks!
Michael Rohleder <mike@rohleder.de> skribis:
> * gnu/packages/video.scm (libmediainfo)[arguments]: Add configure-flags.
Actually no, this one appears to break ‘mediainfo’ as I wrote in my
other message.
[-- Attachment #1.1: Type: text/plain, Size: 329 bytes --] Ludovic Courtès <ludo@gnu.org> writes: > Michael Rohleder <mike@rohleder.de> skribis: > >> * gnu/packages/video.scm (libmediainfo)[arguments]: Add configure-flags. > > Actually no, this one appears to break ‘mediainfo’ as I wrote in my > other message. The consumer (mediainfo) needs curl and tinyxml2 inputs: [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #1.2: Fix usage of libcurl and tinyxml2. --] [-- Type: text/x-patch, Size: 1250 bytes --] >From 6612d1189263cc4670b820e26f5e75d4df9c68b0 Mon Sep 17 00:00:00 2001 From: Michael Rohleder <mike@rohleder.de> Date: Tue, 11 May 2021 14:05:13 +0200 Subject: [PATCH] gnu: mediainfo: Fix usage of libcurl and tinyxml2. * gnu/packages/video.scm (mediainfo): Fix usage of libcurl and tinyxml2. --- gnu/packages/video.scm | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm index 481ab46b6e..630edf49b6 100644 --- a/gnu/packages/video.scm +++ b/gnu/packages/video.scm @@ -3834,6 +3834,8 @@ practically any type of media.") (build-system gnu-build-system) (arguments '(#:tests? #f ; see above TODO + #:configure-flags + (list "--with-libcurl" "--with-libtinyxml2") #:phases ;; build scripts not in root of archive (modify-phases %standard-phases @@ -3888,6 +3890,8 @@ MPEG-2, MPEG-4, DVD (VOB)... ("libtool" ,libtool) ("pkg-config" ,pkg-config) ("zlib" ,zlib) + ("curl" ,curl) ;; In Requires.private of libmediainfo pkg-config files. + ("tinyxml2" ,tinyxml2) ("libmediainfo" ,libmediainfo) ("libzen" ,libzen))) (build-system gnu-build-system) -- 2.31.1 [-- Attachment #1.3: Type: text/plain, Size: 146 bytes --] -- A million monkeys pounding on a million typewriters will never produce Shakespeare. The experiment's been tried; we got USENET instead. [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 511 bytes --]
Michael Rohleder <mike@rohleder.de> skribis: >>From 6612d1189263cc4670b820e26f5e75d4df9c68b0 Mon Sep 17 00:00:00 2001 > From: Michael Rohleder <mike@rohleder.de> > Date: Tue, 11 May 2021 14:05:13 +0200 > Subject: [PATCH] gnu: mediainfo: Fix usage of libcurl and tinyxml2. > > * gnu/packages/video.scm (mediainfo): Fix usage of libcurl and tinyxml2. Please mention [arguments] and [propagated-inputs]. > gnu/packages/video.scm | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm > index 481ab46b6e..630edf49b6 100644 > --- a/gnu/packages/video.scm > +++ b/gnu/packages/video.scm > @@ -3834,6 +3834,8 @@ practically any type of media.") > (build-system gnu-build-system) > (arguments > '(#:tests? #f ; see above TODO > + #:configure-flags > + (list "--with-libcurl" "--with-libtinyxml2") > #:phases > ;; build scripts not in root of archive > (modify-phases %standard-phases > @@ -3888,6 +3890,8 @@ MPEG-2, MPEG-4, DVD (VOB)... > ("libtool" ,libtool) > ("pkg-config" ,pkg-config) > ("zlib" ,zlib) > + ("curl" ,curl) ;; In Requires.private of libmediainfo pkg-config files. > + ("tinyxml2" ,tinyxml2) Shouldn’t we also remove them from ‘native-inputs’, which looks bogus anyway? Thanks, Ludo’.
Ping! :-)
Ludovic Courtès <ludo@gnu.org> skribis:
> Michael Rohleder <mike@rohleder.de> skribis:
>
>>>>From 6612d1189263cc4670b820e26f5e75d4df9c68b0 Mon Sep 17 00:00:00 2001
>> From: Michael Rohleder <mike@rohleder.de>
>> Date: Tue, 11 May 2021 14:05:13 +0200
>> Subject: [PATCH] gnu: mediainfo: Fix usage of libcurl and tinyxml2.
>>
>> * gnu/packages/video.scm (mediainfo): Fix usage of libcurl and tinyxml2.
>
> Please mention [arguments] and [propagated-inputs].
>
>
>> gnu/packages/video.scm | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
>> index 481ab46b6e..630edf49b6 100644
>> --- a/gnu/packages/video.scm
>> +++ b/gnu/packages/video.scm
>> @@ -3834,6 +3834,8 @@ practically any type of media.")
>> (build-system gnu-build-system)
>> (arguments
>> '(#:tests? #f ; see above TODO
>> + #:configure-flags
>> + (list "--with-libcurl" "--with-libtinyxml2")
>> #:phases
>> ;; build scripts not in root of archive
>> (modify-phases %standard-phases
>> @@ -3888,6 +3890,8 @@ MPEG-2, MPEG-4, DVD (VOB)...
>> ("libtool" ,libtool)
>> ("pkg-config" ,pkg-config)
>> ("zlib" ,zlib)
>> + ("curl" ,curl) ;; In Requires.private of libmediainfo pkg-config files.
>> + ("tinyxml2" ,tinyxml2)
>
> Shouldn’t we also remove them from ‘native-inputs’, which looks bogus
> anyway?
>
> Thanks,
> Ludo’.
[-- Attachment #1.1: Type: text/plain, Size: 99 bytes --] Hey Ludo! Thanks for the ping and sorry for the delay! I hope, this patch is better/pushable ;) [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #1.2: Fix usage of libcurl and linyxml2. --] [-- Type: text/x-patch, Size: 2008 bytes --] >From 7e998af5b498388e5ffcf2491c6c934bf49b5c98 Mon Sep 17 00:00:00 2001 From: Michael Rohleder <mike@rohleder.de> Date: Wed, 9 Jun 2021 08:12:40 +0200 Subject: [PATCH] gnu: libmediainfo: Fix usage of libcurl and libtinyxml2. * gnu/packages/video.scm (libmediainfo): Fix usage of libcurl and libtinyxml2. [arguments]: Add configure-flags. [native-inputs]: Move zlib, tinyxml2, curl, libzen to ... [propagated-inputs]: ... Here. (mediainfo): [native-inputs]: Remove zlib, libzen. Move libmediainfo to ... [inputs]: ... Here. --- gnu/packages/video.scm | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm index a694d4bb43..5c028016cf 100644 --- a/gnu/packages/video.scm +++ b/gnu/packages/video.scm @@ -3850,14 +3850,17 @@ practically any type of media.") `(("autoconf" ,autoconf) ("automake" ,automake) ("libtool" ,libtool) - ("pkg-config" ,pkg-config) - ("zlib" ,zlib) + ("pkg-config" ,pkg-config))) + (propagated-inputs + `(("zlib" ,zlib) ("tinyxml2" ,tinyxml2) - ("curl" ,curl) + ("curl" ,curl) ; In Requires.private of libmediainfo.pc. ("libzen" ,libzen))) (build-system gnu-build-system) (arguments '(#:tests? #f ; see above TODO + #:configure-flags + (list "--with-libcurl" "--with-libtinyxml2") #:phases ;; build scripts not in root of archive (modify-phases %standard-phases @@ -3910,10 +3913,9 @@ MPEG-2, MPEG-4, DVD (VOB)... `(("autoconf" ,autoconf) ("automake" ,automake) ("libtool" ,libtool) - ("pkg-config" ,pkg-config) - ("zlib" ,zlib) - ("libmediainfo" ,libmediainfo) - ("libzen" ,libzen))) + ("pkg-config" ,pkg-config))) + (inputs + `(("libmediainfo" ,libmediainfo))) (build-system gnu-build-system) (arguments '(#:tests? #f ; lacks tests -- 2.32.0 [-- Attachment #1.3: Type: text/plain, Size: 132 bytes --] -- I've finally learned what "upward compatible" means. It means we get to keep all our old mistakes. Dennie van Tassel [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 511 bytes --]
Hi,
Michael Rohleder <mike@rohleder.de> skribis:
>>From 7e998af5b498388e5ffcf2491c6c934bf49b5c98 Mon Sep 17 00:00:00 2001
> From: Michael Rohleder <mike@rohleder.de>
> Date: Wed, 9 Jun 2021 08:12:40 +0200
> Subject: [PATCH] gnu: libmediainfo: Fix usage of libcurl and libtinyxml2.
>
> * gnu/packages/video.scm (libmediainfo): Fix usage of libcurl and libtinyxml2.
> [arguments]: Add configure-flags.
> [native-inputs]: Move zlib, tinyxml2, curl, libzen to ...
> [propagated-inputs]: ... Here.
> (mediainfo):
> [native-inputs]: Remove zlib, libzen. Move libmediainfo to ...
> [inputs]: ... Here.
Applied, thanks!
Ludo’.