unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / Atom feed
* [bug#48101] [PATCH] gnu: Add aspell-dict-ro.
@ 2021-04-29  8:17 Sergiu Ivanov
  2021-04-30 10:54 ` bug#48101: " Julien Lepiller
  0 siblings, 1 reply; 3+ messages in thread
From: Sergiu Ivanov @ 2021-04-29  8:17 UTC (permalink / raw)
  To: 48101

[-- Attachment #1: Type: text/plain, Size: 318 bytes --]

Dear Guix,

Please find attached my first ever patch adding the Romanian
aspell dictionary.

The addition seems very simple and I tested building and installing it
in my custom channel and building within a Git checkout of Guix.

Do tell me if there are any improvement opportunities, I am here to
learn :-)

-
Sergiu

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-aspell-dict-ro.patch --]
[-- Type: text/x-patch, Size: 919 bytes --]

From 2188a7e01a024fafadfa62b9bd37803fa73b9a98 Mon Sep 17 00:00:00 2001
From: Sergiu Ivanov <sivanov@colimite.fr>
Date: Tue, 27 Apr 2021 21:33:11 +0200
Subject: [PATCH] gnu: Add aspell-dict-ro.

---
 gnu/packages/aspell.scm | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/gnu/packages/aspell.scm b/gnu/packages/aspell.scm
index 26c0cf4332..99e878e08a 100644
--- a/gnu/packages/aspell.scm
+++ b/gnu/packages/aspell.scm
@@ -356,6 +356,14 @@ dictionaries, including personal ones.")
                      (base32
                       "137i4njvnslab6l4s291s11xijr5jsy75lbdph32f9y183lagy9m")))
 
+(define-public aspell-dict-ro
+  (aspell-dictionary "ro" "Romanian"
+		     #:version "3.3-2"
+		     #:prefix "aspell5-"
+		     #:sha256
+		     (base32
+                      "0gb8j9iy1acdl11jq76idgc2lbc1rq3w04favn8cyh55d1v8phsk")))
+
 \f
 ;;;
 ;;; Hunspell packages made from the Aspell word lists.
-- 
2.31.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#48101: [PATCH] gnu: Add aspell-dict-ro.
  2021-04-29  8:17 [bug#48101] [PATCH] gnu: Add aspell-dict-ro Sergiu Ivanov
@ 2021-04-30 10:54 ` Julien Lepiller
  2021-04-30 13:17   ` [bug#48101] " Sergiu Ivanov
  0 siblings, 1 reply; 3+ messages in thread
From: Julien Lepiller @ 2021-04-30 10:54 UTC (permalink / raw)
  To: Sergiu Ivanov; +Cc: 48101-done

Le Thu, 29 Apr 2021 10:17:05 +0200,
Sergiu Ivanov <sivanov@colimite.fr> a écrit :

> Dear Guix,
> 
> Please find attached my first ever patch adding the Romanian
> aspell dictionary.
> 
> The addition seems very simple and I tested building and installing it
> in my custom channel and building within a Git checkout of Guix.
> 
> Do tell me if there are any improvement opportunities, I am here to
> learn :-)
> 
> -
> Sergiu

Pushed as 847f523381f79e46d151257bf5f9a636a85db8ac with some small
changes:

I added a copyright line for you at the top of the file.

There was an alignment issue, caused by tabulations. I replaced them
with spaces (please don't use tabs).

You should be able to use the package after running "guix pull". Thanks
for your contribution!




^ permalink raw reply	[flat|nested] 3+ messages in thread

* [bug#48101] [PATCH] gnu: Add aspell-dict-ro.
  2021-04-30 10:54 ` bug#48101: " Julien Lepiller
@ 2021-04-30 13:17   ` Sergiu Ivanov
  0 siblings, 0 replies; 3+ messages in thread
From: Sergiu Ivanov @ 2021-04-30 13:17 UTC (permalink / raw)
  To: Julien Lepiller; +Cc: 48101-done

Thus quoth  Julien Lepiller  on Fri Apr 30 2021 at 12:54 (+0200):
> Le Thu, 29 Apr 2021 10:17:05 +0200,
> Sergiu Ivanov <sivanov@colimite.fr> a écrit :
>
>> Dear Guix,
>> 
>> Please find attached my first ever patch adding the Romanian
>> aspell dictionary.
>> 
>> The addition seems very simple and I tested building and installing it
>> in my custom channel and building within a Git checkout of Guix.
>> 
>> Do tell me if there are any improvement opportunities, I am here to
>> learn :-)
>> 
>> -
>> Sergiu
>
> Pushed as 847f523381f79e46d151257bf5f9a636a85db8ac with some small
> changes:
>
> I added a copyright line for you at the top of the file.

Oh, thank you, I completely forgot about that!

> There was an alignment issue, caused by tabulations. I replaced them
> with spaces (please don't use tabs).

Ooops, sorry, I've just disabled tabs in my Emacs configuration.
Not sure why I kept them enabled anyway.

> You should be able to use the package after running "guix pull". Thanks
> for your contribution!

Thank you for your time!




^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-04-30 14:56 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-29  8:17 [bug#48101] [PATCH] gnu: Add aspell-dict-ro Sergiu Ivanov
2021-04-30 10:54 ` bug#48101: " Julien Lepiller
2021-04-30 13:17   ` [bug#48101] " Sergiu Ivanov

unofficial mirror of guix-patches@gnu.org 

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://yhetil.org/guix-patches/1 guix-patches/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 guix-patches guix-patches/ https://yhetil.org/guix-patches \
		guix-patches@gnu.org
	public-inbox-index guix-patches

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://news.yhetil.org/yhetil.gnu.guix.patches


AGPL code for this site: git clone http://ou63pmih66umazou.onion/public-inbox.git