unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Julien Lepiller <julien@lepiller.eu>
To: Leo Prikler <leo.prikler@student.tugraz.at>
Cc: Maxime Devos <maximedevos@telenet.be>, 47704@debbugs.gnu.org
Subject: [bug#47704] [PATCH] services: mysql: Add extra-environment as configuration option.
Date: Wed, 14 Apr 2021 00:29:58 +0200	[thread overview]
Message-ID: <20210414002958.2c5a6e19@tachikoma.lepiller.eu> (raw)
In-Reply-To: <7a570acae3d60b16e34a89097d801876d5951f4e.camel@student.tugraz.at>

Le Tue, 13 Apr 2021 18:58:57 +0200,
Leo Prikler <leo.prikler@student.tugraz.at> a écrit :

> Am Montag, den 12.04.2021, 22:09 +0200 schrieb Maxime Devos:
> > I think your original patch is good to go into the git repo.  I'll
> > open a
> > separate bug report about ‘absolutising’ the binaries referred to
> > from the scripts.  
> I've pushed this patch now, but let us still look for a smaller
> solution if applicable.  (That said, I'm not a mysql user and I'm
> happy to leave security stuff to lle_bout.)
> 
> @david: Note, that I did not change the author, meaning it is
> committed as "methuselah-0 <david.larsson@selfhosted.xyz>" rather
> than "david larsson <david.larsson@selfhosted.xyz>".  Since this
> patch is hopefully small enough to not require attribution, that is
> fine, but if you plan on making bigger changes, please consider
> setting your git up appropriately.
> 
> Regards,
> Leo 
> 
> 
> 
> 

Hi!

I saw this patch went through, but it updates the Guix Manual while we
are in string freeze. The change is very small and close to the start
of string freeze, so I'm willing to let it go. However, please refrain
from pushing such changes to the manual. Ideally, this patch should
have been pushed yesterday or postponed until after the release.

As a reminder, the string freeze applies to guix and to the manual. It
does not apply to the website, package synopsis and descriptions, nor
to the cookbook.

Thank you!




  reply	other threads:[~2021-04-13 22:31 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-11  8:44 [bug#47704] [PATCH] services: mysql: Add extra-environment as configuration option david larsson
2021-04-11 15:33 ` Maxime Devos
2021-04-11 18:07   ` david larsson
2021-04-11 20:44     ` Maxime Devos
2021-04-12 18:06       ` david larsson
2021-04-12 20:09         ` Maxime Devos
2021-04-13 16:58           ` bug#47704: " Leo Prikler
2021-04-13 22:29             ` Julien Lepiller [this message]
2021-04-13 22:38               ` [bug#47704] " Leo Prikler
2021-04-13 22:56                 ` Julien Lepiller
2021-04-19  9:59                   ` Leo Prikler
2021-04-27 18:15                     ` david larsson
2021-04-27 18:47                       ` Leo Prikler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210414002958.2c5a6e19@tachikoma.lepiller.eu \
    --to=julien@lepiller.eu \
    --cc=47704@debbugs.gnu.org \
    --cc=leo.prikler@student.tugraz.at \
    --cc=maximedevos@telenet.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).