unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian.de>
To: Luis Felipe <luis.felipe.la@protonmail.com>
Cc: 47710@debbugs.gnu.org
Subject: [bug#47710] [PATCH] website: Fix dropdown menu shrinking when clicked
Date: Sun, 11 Apr 2021 23:48:56 +0200	[thread overview]
Message-ID: <20210411214856.vo2uoqlsxssitzah@pelzflorian.localdomain> (raw)
In-Reply-To: <6qPduW122TIVLNu9Rj_6WQGFxdoNCifPrJccAjS5vVqz-1ROc0Oz9Mj1jQNuueNtgXJh1VyK9NX1bUnZV0__a7E1n1_La1beKfPVxcn1Zes=@protonmail.com>

On Sun, Apr 11, 2021 at 03:35:32PM +0000, Luis Felipe via Guix-patches via wrote:
> Subject: [PATCH] website: Fix dropdown menu shrinking when clicked.
> […]
> This change fixes these problems by leaving the menu width as wide as
> its longest item when the button is toggled.

Thank you, this does the trick.  (Except on Microsoft Internet
Explorer, which we do not need to care about anymore.)

> * apps/base/templates/components.scm (menu-dropdown): Set width to
>   max-content on :checked.

The last line should not be indented, but it does not matter.

> ---
>  website/apps/base/templates/components.scm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/website/apps/base/templates/components.scm b/website/apps/base/templates/components.scm
> index 5440408..f521436 100644
> --- a/website/apps/base/templates/components.scm
> +++ b/website/apps/base/templates/components.scm
> @@ -310,7 +310,7 @@ manual.
>  {
>      min-width: 150px;
>      /* reset to initial values: */
> -    width: auto;
> +    width: max-content;
>      height: auto;
>      overflow: visible;
>  }"))

The comment /* reset to initial values: */ is misplaced now;
max-content is not an initial value for width.  I have moved the
comment down one line in commit
81a6c477d92b2c4a206c390b97c9cb0159d79719.

Regards,
Florian




  parent reply	other threads:[~2021-04-11 21:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-11 15:35 [bug#47710] [PATCH] website: Fix dropdown menu shrinking when clicked Luis Felipe via Guix-patches via
2021-04-11 16:30 ` bug#47710: " Mathieu Othacehe
2021-04-11 21:48 ` pelzflorian (Florian Pelz) [this message]
2021-04-12  2:05   ` [bug#47710] " Luis Felipe via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210411214856.vo2uoqlsxssitzah@pelzflorian.localdomain \
    --to=pelzflorian@pelzflorian.de \
    --cc=47710@debbugs.gnu.org \
    --cc=luis.felipe.la@protonmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).