From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id AK39E9ARc2BuhgEAgWs5BA (envelope-from ) for ; Sun, 11 Apr 2021 17:12:16 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id iF/JDdARc2B8ewAAB5/wlQ (envelope-from ) for ; Sun, 11 Apr 2021 15:12:16 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DD07636EBA for ; Sun, 11 Apr 2021 17:12:15 +0200 (CEST) Received: from localhost ([::1]:36316 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lVbl1-00073v-2x for larch@yhetil.org; Sun, 11 Apr 2021 11:12:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50438) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lVbko-00072y-Jo for guix-patches@gnu.org; Sun, 11 Apr 2021 11:12:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:44190) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lVbko-0002O6-Cy for guix-patches@gnu.org; Sun, 11 Apr 2021 11:12:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lVbko-0007NL-8I for guix-patches@gnu.org; Sun, 11 Apr 2021 11:12:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#46399] [PATCH] build-system/cargo: Propagate crates across builds. Resent-From: "pelzflorian (Florian Pelz)" Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 11 Apr 2021 15:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46399 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Efraim Flashner Cc: 46399@debbugs.gnu.org Received: via spool by 46399-submit@debbugs.gnu.org id=B46399.161815389628317 (code B ref 46399); Sun, 11 Apr 2021 15:12:02 +0000 Received: (at 46399) by debbugs.gnu.org; 11 Apr 2021 15:11:36 +0000 Received: from localhost ([127.0.0.1]:55736 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lVbkN-0007Me-QB for submit@debbugs.gnu.org; Sun, 11 Apr 2021 11:11:36 -0400 Received: from pelzflorian.de ([5.45.111.108]:39532 helo=mail.pelzflorian.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lVbkI-0007MS-PW for 46399@debbugs.gnu.org; Sun, 11 Apr 2021 11:11:34 -0400 Received: from pelzflorian.localdomain (unknown [5.45.111.108]) by mail.pelzflorian.de (Postfix) with ESMTPSA id 9531F36063C; Sun, 11 Apr 2021 17:11:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=pelzflorian.de; s=mail; t=1618153889; bh=Jvo7KyJ5/9DXSeOAKjPJJSHGPBN5R+IYrY38HRi+kNk=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=ieTUGbUCtY8A6Jhl3bj2gcEZoLGTiYr+SptldHcpVkQKiDIxOoCGhyp9zynGDfsJh wKvj7mRCwMvSfIVC4nDVhDkRMdxdeuQYkugCLNdKqY39Q2XC7BwwHN43bpxKgCp0yk McpcjbH98W0Zudg7W3f0CjI97sejzVz9NVFhfzWE= Date: Sun, 11 Apr 2021 17:11:21 +0200 From: "pelzflorian (Florian Pelz)" Message-ID: <20210411151052.ckjjpbrpqgfp43tl@pelzflorian.localdomain> References: <20210209105843.13230-1-efraim@flashner.co.il> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210209105843.13230-1-efraim@flashner.co.il> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1618153936; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=nwIyNLUPw9TptuYs4DuVq2oETypzZJwjld+89VORm20=; b=Mpgk40dGDDBQ3IlfuqRADY7TUgrCF3VSGPup3MWSoMW/OiMC1tMyKSBioKDgYCwlC+lqf0 FotJH+aKJ8ndEwCyiu+gxbs2fbwpJwsBGE+5jXEFAoLQcA4NQAM8eRLPzqFWM6B48hC9cQ H77puF9o370TOhv8c0yisqnKOfkAqJuMiXwQAtX+uelaeEHJemvdMS78Szlswi7ZWfoYCT kx1TacNf5x9abG364VKbr4QPSe6zs5O2WawNCmfiMV6GwdnmRKnHW5Houe2VkcmYl/ec8t xLR2f26U6Ir5LLxhJeyfWgGrHbFcfqB82DwTYzbz/thiXEf0+OU6IDXg5wYk/Q== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1618153936; a=rsa-sha256; cv=none; b=cb5rPgJ+/6o0gGc6ZLqCu+IZH3o5L4PHU0IrpqgXphb0+SU9p73L7FnqzfraGPIatcB7ve c8mc3a0pYnM0axV7/Ek5eO5SZIlD4QyYScmU4bVvGCQIn0Lvmh/vDhm1+4z8RaugpwBr4f WOaTIuj5UUOImpm4ti9j09SH/30mwge4o2h29OS0Po+XOq22SsVrHFeGldktj0TCqrZr+n +9/pGALVoAXSIrL5wObykXyHBpyVFZy1/1+Y1Wm/Ku/3thRe5fvMYDHKMnhGLp2wey28/r Iy0VhuGCQaNXCYEZpx6D/kgBhcjSmP5J1C3TJfdjt1sZxOdLOhNAL52kjQm35A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=pelzflorian.de header.s=mail header.b=ieTUGbUC; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: 0.06 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=pelzflorian.de header.s=mail header.b=ieTUGbUC; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: DD07636EBA X-Spam-Score: 0.06 X-Migadu-Scanner: scn0.migadu.com X-TUID: MPM/4mUnQbuo Hello Efraim! Thank you for improving Rust development with Guix. I have a question about this change to doc/guix.texi when translating. Sorry for noticing so late just before the string freeze. On Tue, Feb 09, 2021 at 12:58:43PM +0200, Efraim Flashner wrote: > diff --git a/doc/guix.texi b/doc/guix.texi > index 7d18703283..0d153a1470 100644 > --- a/doc/guix.texi > +++ b/doc/guix.texi > […] > @@ -7437,8 +7437,10 @@ supports builds of packages using Cargo, the build tool of the > It adds @code{rustc} and @code{cargo} to the set of inputs. > A different Rust package can be specified with the @code{#:rust} parameter. > > -Regular cargo dependencies should be added to the package definition via the > -@code{#:cargo-inputs} parameter as a list of name and spec pairs, where the > +Regular cargo dependencies should be added to the package definition similarly > +to other packages; those needed only at build time to native-inputs, others to > +inputs. If you need to add source-only crates then you should add them to via > +the @code{#:cargo-inputs} parameter as a list of name and spec pairs, where the > spec can be a package or a source definition. Note that the spec must > evaluate to a path to a gzipped tarball which includes a @code{Cargo.toml} > file at its root, or it will be ignored. Similarly, cargo dev-dependencies I have no experience in Rust. Do I understand correctly that source-only crates among the inputs should be added both to inputs and to #:cargo-inputs? Is the > +inputs. If you need to add source-only crates then you should add them to via a typo which should read “add them too” instead of “add them to”? I look at the subsequent change f35ab79e033aa8e4955e9c9100c74ecbb3ce4d0b to rust-wayland-commons > diff --git a/gnu/packages/crates-graphics.scm b/gnu/packages/crates-graphics.scm > index d67e9dc02f..7dde00ffdb 100644 > --- a/gnu/packages/crates-graphics.scm > +++ b/gnu/packages/crates-graphics.scm > @@ -2415,8 +2415,11 @@ the wayland protocol, client side.") > (arguments > - `(#:skip-build? #t > - #:cargo-inputs > + `(#:cargo-inputs > (("rust-nix" ,rust-nix-0.18) > ("rust-once-cell" ,rust-once-cell-1) > - ("rust-smallvec" ,rust-smallvec-1) > - ("rust-wayland-sys" ,rust-wayland-sys-0.28)))) > + ("rust-smallvec" ,rust-smallvec-1)))) > + (inputs > + `(("rust-nix" ,rust-nix-0.18) > + ("rust-once-cell" ,rust-once-cell-1) > + ("rust-smallvec" ,rust-smallvec-1) > + ("rust-wayland-sys" ,rust-wayland-sys-0.28))) > (home-page "https://github.com/smithay/wayland-rs") and do not understand why rust-wayland-sys is only part of inputs but rust-once-cell is also among the cargo-inputs. Also the inputs are empty for older versions of rust-wayland-commons. Could you clarify what is written in the doc/guix.texi? Regards, Florian