From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id brXDENspamBamwAAgWs5BA (envelope-from ) for ; Sun, 04 Apr 2021 23:04:27 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id SEqMCdspamCdRQAAbx9fmQ (envelope-from ) for ; Sun, 04 Apr 2021 21:04:27 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DE4EE8D71 for ; Sun, 4 Apr 2021 23:04:26 +0200 (CEST) Received: from localhost ([::1]:34800 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lT9uz-0002pb-PF for larch@yhetil.org; Sun, 04 Apr 2021 17:04:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42514) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lT9ud-0002ng-KH for guix-patches@gnu.org; Sun, 04 Apr 2021 17:04:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:53262) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lT9ud-0000lQ-9u for guix-patches@gnu.org; Sun, 04 Apr 2021 17:04:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lT9ud-0000ho-6Q for guix-patches@gnu.org; Sun, 04 Apr 2021 17:04:03 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47597] [PATCH 3/3] lint: refresh: Warn about missing or dysfunctional updaters. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 04 Apr 2021 21:04:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47597 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 47597@debbugs.gnu.org Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 47597-submit@debbugs.gnu.org id=B47597.16175702272674 (code B ref 47597); Sun, 04 Apr 2021 21:04:03 +0000 Received: (at 47597) by debbugs.gnu.org; 4 Apr 2021 21:03:47 +0000 Received: from localhost ([127.0.0.1]:36573 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lT9uG-0000gs-1j for submit@debbugs.gnu.org; Sun, 04 Apr 2021 17:03:47 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49466) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lT9uC-0000gG-Mi for 47597@debbugs.gnu.org; Sun, 04 Apr 2021 17:03:37 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45767) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lT9u7-0000WC-HX; Sun, 04 Apr 2021 17:03:31 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=45190 helo=gnu.org) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lT9u7-00049w-1q; Sun, 04 Apr 2021 17:03:31 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Date: Sun, 4 Apr 2021 23:03:16 +0200 Message-Id: <20210404210316.31198-3-ludo@gnu.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210404210316.31198-1-ludo@gnu.org> References: <20210404210316.31198-1-ludo@gnu.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1617570267; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=s8ui0IlbBy4q09S4aahFU0lzKwHqJTD9qa72DGQWV6g=; b=ph38Y2YyMS8VQ3BD31cAb9fIAxO1Fqkiiws2ROwYls1Lm6MxLSTIW7V7flf+f2BKPMYGDr 0HQ7dPnFWdL5KMH7CjC/LWt7wf9oVnwhicAd9ommfLkHliEkw3I07nWTF15eNlnX3Tpxd6 nFhSPyXl+Rd+gTY3Q4b7yBwFi+o1G7axZwgeCcRNSxG/kckfjzN/dOjUyI6twX4JfRU0jS Icy4FMcqICh8XejlcnGQXe64Lz2bEbfaLJyIcbdqYT4YQrLFsjbJo4ikyQ5QeVhfiJyxLA Ehi322Lpr5OH5pFj0SzbWD2Xn48zTMD3s3W5mCnPC4DNnii/goOMEb3W2xdFNw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1617570267; a=rsa-sha256; cv=none; b=qvZscvld59G0imsFArbKnuKqYsv26CdrpVxJgg3V3mIFyjplW7GirPYjhJYhXhJnsRl+H7 e4vLjvS77oOslbPOUFxZWAdO1YgzR7HMmVywbHxjqsxaGRJsC2rOto/D2KH++cdXa6u0yM TLWc3yRwUwHTrLTiVUzL28UIvn9G6seudGvxNMW2vFilsD2W/EJCYD1nucU6FkldIhO9ck jcHcAW4cNEGwiFzdtRlXNzyrn8U0j6LtsII1kRxY3GAio3CdF/QmQfG0zTVuHefyabKnDe pJc7029Wu4T1i+vpGz4+ZsanL26HuwICLiZW/oi6cxrqABeHfm3oBc0VbGfTUQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: 2.06 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: DE4EE8D71 X-Spam-Score: 2.06 X-Migadu-Scanner: scn0.migadu.com X-TUID: tVSXtGasY4S/ This feedback should help us improve updaters. * guix/lint.scm (check-for-updates): Return a warning when PACKAGE lacks an updater or when the updater returns #f. --- guix/lint.scm | 41 ++++++++++++++++++++++++++--------------- 1 file changed, 26 insertions(+), 15 deletions(-) diff --git a/guix/lint.scm b/guix/lint.scm index cdd9dd14d7..a7d6bbba4f 100644 --- a/guix/lint.scm +++ b/guix/lint.scm @@ -1191,21 +1191,32 @@ vulnerability records for PACKAGE by calling PACKAGE-VULNERABILITIES." (define (check-for-updates package) "Check if there is an update available for PACKAGE." - (match (with-networking-fail-safe - (format #f (G_ "while retrieving upstream info for '~a'") - (package-name package)) - #f - (package-latest-release* package)) - ((? upstream-source? source) - (if (version>? (upstream-source-version source) - (package-version package)) - (list - (make-warning package - (G_ "can be upgraded to ~a") - (list (upstream-source-version source)) - #:field 'version)) - '())) - (#f '()))) ; cannot find newer upstream release + (match (lookup-updater package) + (#f + (list (make-warning package (G_ "no updater for ~a") + (list (package-name package)) + #:field 'source))) + ((? upstream-updater? updater) + (match (with-networking-fail-safe + (format #f (G_ "while retrieving upstream info for '~a'") + (package-name package)) + #f + (package-latest-release package)) + ((? upstream-source? source) + (if (version>? (upstream-source-version source) + (package-version package)) + (list + (make-warning package + (G_ "can be upgraded to ~a") + (list (upstream-source-version source)) + #:field 'version)) + '())) + (#f ;cannot find upstream release + (list (make-warning package + (G_ "updater '~a' failed to find \ +upstream releases") + (list (upstream-updater-name updater)) + #:field 'source))))))) (define (check-archival package) -- 2.31.1