unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / Atom feed
From: "Mădălin Ionel Patrașcu" <madalinionel.patrascu@mdc-berlin.de>
To: 46715@debbugs.gnu.org
Cc: rekado@elephly.net,
	"Mădălin Ionel Patrașcu" <madalinionel.patrascu@mdc-berlin.de>
Subject: [bug#46715] [PATCH] guix import: Fixing detection of Fortran files.
Date: Tue, 23 Feb 2021 12:00:21 +0100
Message-ID: <20210223110021.10765-1-madalinionel.patrascu@mdc-berlin.de> (raw)

This fixes a bug whereby Guix importer considers files like .f.*
being Fortran's files.

(find-files dir "\\.f(90|95)?")

would consider a lot of files with an extension starting with f
being a Fortran file. The right way is to consider only files
ending with .f90 or .f95.

*guix/import/cran.scm: changing pattern of the detection for
Fortran's files to .f(90|95)$.

Co-authored-by: Ricardo Wurmus <rekado@elephly.net>
---
 guix/import/cran.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/guix/import/cran.scm b/guix/import/cran.scm
index e8caf080fd..dbc858cb84 100644
--- a/guix/import/cran.scm
+++ b/guix/import/cran.scm
@@ -361,7 +361,7 @@ empty list when the FIELD cannot be found."
 
 (define (directory-needs-fortran? dir)
   "Check if the directory DIR contains Fortran source files."
-  (match (find-files dir "\\.f(90|95)?")
+  (match (find-files dir "\\.f(90|95)$")
     (() #f)
     (_ #t)))
 
-- 
2.30.1





             reply	other threads:[~2021-02-23 11:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-23 11:00 Mădălin Ionel Patrașcu [this message]
2021-03-01 21:47 ` bug#46715: " Ricardo Wurmus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210223110021.10765-1-madalinionel.patrascu@mdc-berlin.de \
    --to=madalinionel.patrascu@mdc-berlin.de \
    --cc=46715@debbugs.gnu.org \
    --cc=rekado@elephly.net \
    --subject='Re: [bug#46715] [PATCH] guix import: Fixing detection of Fortran files.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

unofficial mirror of guix-patches@gnu.org 

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://yhetil.org/guix-patches/1 guix-patches/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 guix-patches guix-patches/ https://yhetil.org/guix-patches \
		guix-patches@gnu.org
	public-inbox-index guix-patches

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://news.yhetil.org/yhetil.gnu.guix.patches


AGPL code for this site: git clone http://ou63pmih66umazou.onion/public-inbox.git