unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: pkill9 <pkill9@runbox.com>
To: Leo Famulari <leo@famulari.name>
Cc: 46337@debbugs.gnu.org
Subject: [bug#46337] A patch to enable building proprietary codecs in qtwebengine
Date: Mon, 8 Feb 2021 15:40:43 +0000	[thread overview]
Message-ID: <20210208154043.65635e9c@runbox.com> (raw)
In-Reply-To: <YCAtfGuZDUrjAHwx@jasmine.lan>

[-- Attachment #1: Type: text/plain, Size: 382 bytes --]

> Thanks! I tried building with this flag on a powerful computer, but
> the build failed because it couldn't find the dependency openh264.
> That is packaged, so we just need an updated patch.

I've attached an updated patch with the 'openh264' package added to
inputs. Also changed the flag so it's indented using spaces instead of
tabs, which is why it wasn't aligned previously.

[-- Attachment #2: 0001-gnu-packages-qt.scm-Enable-proprietary-codecs-suppor.patch --]
[-- Type: text/x-patch, Size: 1325 bytes --]

From dc0945c1720c74f0a071a8b28b0220e91890ec5c Mon Sep 17 00:00:00 2001
From: Pkill -9 <pkill9@runbox.com>
Date: Mon, 8 Feb 2021 15:37:54 +0000
Subject: [PATCH] gnu/packages/qt.scm: Enable proprietary codecs support (h264)
 in qtwebengine

---
 gnu/packages/qt.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm
index 4fbb157600..cb4699387d 100644
--- a/gnu/packages/qt.scm
+++ b/gnu/packages/qt.scm
@@ -1881,6 +1881,7 @@ using the Enchant spell-checking library.")
        ("mesa" ,mesa)
        ("minizip" ,minizip)
        ("nss" ,nss)
+       ("openh264" ,openh264)
        ("opus" ,opus)
        ("pciutils" ,pciutils)
        ("protobuf" ,protobuf)
@@ -1939,7 +1940,8 @@ using the Enchant spell-checking library.")
                        "--webengine-printing-and-pdf=no"
                        "--webengine-ffmpeg=system"
                        "--webengine-icu=system"
-                       "--webengine-pepper-plugins=no")))))
+                       "--webengine-pepper-plugins=no"
+                       "-webengine-proprietary-codecs")))))
        ;; Tests are disabled due to "Could not find QtWebEngineProcess error"
        ;; It's possible this can be fixed by setting QTWEBENGINEPROCESS_PATH
        ;; before running tests.
-- 
2.30.0


  reply	other threads:[~2021-02-08 21:32 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-06  1:47 [bug#46337] A patch to enable building proprietary codecs in qtwebengine pkill9
2021-02-06 10:10 ` Tobias Geerinckx-Rice via Guix-patches via
2021-02-06 13:05   ` Tobias Geerinckx-Rice via Guix-patches via
2021-02-07 18:12 ` Leo Famulari
2021-02-08 15:40   ` pkill9 [this message]
2021-02-08 16:36     ` Leo Famulari
2021-02-08 22:53       ` pkill9
2021-02-08 23:44         ` pkill9
2021-02-09 21:17           ` Leo Famulari
2021-05-30 17:54 ` [bug#46337] Attempt to fix the build Sergey Trofimov
2021-06-07 21:01   ` bug#46337: " Leo Famulari
2021-05-30 18:47 ` [bug#46337] Clarification for the previous patch Sergey Trofimov
2021-05-30 20:00 ` [bug#46337] Update Sergey Trofimov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210208154043.65635e9c@runbox.com \
    --to=pkill9@runbox.com \
    --cc=46337@debbugs.gnu.org \
    --cc=leo@famulari.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).