From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id cIuTB0gf819wdQAA0tVLHw (envelope-from ) for ; Mon, 04 Jan 2021 13:59:36 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 6DpNA0gf81/HXAAAbx9fmQ (envelope-from ) for ; Mon, 04 Jan 2021 13:59:36 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D15D29406F7 for ; Mon, 4 Jan 2021 13:59:34 +0000 (UTC) Received: from localhost ([::1]:44310 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kwQOT-0002zp-Oi for larch@yhetil.org; Mon, 04 Jan 2021 08:59:33 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:37038) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kwQNy-0002y0-QR for guix-patches@gnu.org; Mon, 04 Jan 2021 08:59:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:46587) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kwQNy-0006Of-J3 for guix-patches@gnu.org; Mon, 04 Jan 2021 08:59:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kwQNy-0006hV-Fs for guix-patches@gnu.org; Mon, 04 Jan 2021 08:59:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#45403] [PATCH] gnu: zfs: Split into packages specific for each of our major supported kernel versions. Resent-From: Danny Milosavljevic Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 04 Jan 2021 13:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45403 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 45403@debbugs.gnu.org X-Debbugs-Original-To: Tobias Geerinckx-Rice via Guix-patches via X-Debbugs-Original-Cc: raid5atemyhomework@protonmail.com, Tobias Geerinckx-Rice , 45403@debbugs.gnu.org Received: via spool by submit@debbugs.gnu.org id=B.160976870925710 (code B ref -1); Mon, 04 Jan 2021 13:59:02 +0000 Received: (at submit) by debbugs.gnu.org; 4 Jan 2021 13:58:29 +0000 Received: from localhost ([127.0.0.1]:58133 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kwQNR-0006gc-1V for submit@debbugs.gnu.org; Mon, 04 Jan 2021 08:58:29 -0500 Received: from lists.gnu.org ([209.51.188.17]:37730) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kwQNP-0006gV-L9 for submit@debbugs.gnu.org; Mon, 04 Jan 2021 08:58:27 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:36992) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kwQNP-0002f1-C8 for guix-patches@gnu.org; Mon, 04 Jan 2021 08:58:27 -0500 Received: from dd26836.kasserver.com ([85.13.145.193]:55500) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kwQNN-0006DI-9z for guix-patches@gnu.org; Mon, 04 Jan 2021 08:58:27 -0500 Received: from localhost (80-110-127-104.cgn.dynamic.surfer.at [80.110.127.104]) by dd26836.kasserver.com (Postfix) with ESMTPSA id 7C9CD33656AE; Mon, 4 Jan 2021 14:58:20 +0100 (CET) Date: Mon, 4 Jan 2021 14:58:18 +0100 From: Danny Milosavljevic Message-ID: <20210104145818.0fcd9a0d@scratchpost.org> In-Reply-To: <87tusaa5mf.fsf@nckx> References: <87tusaa5mf.fsf@nckx> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/Q/RvIEApKgH6KQhOlJJcvR="; protocol="application/pgp-signature"; micalg=pgp-sha512 Received-SPF: none client-ip=85.13.145.193; envelope-from=dannym@scratchpost.org; helo=dd26836.kasserver.com X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: raid5atemyhomework@protonmail.com Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.43 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: D15D29406F7 X-Spam-Score: -2.43 X-Migadu-Scanner: scn1.migadu.com X-TUID: +jzqmG5efHMn --Sig_/Q/RvIEApKgH6KQhOlJJcvR= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Fri, 25 Dec 2020 05:09:44 +0100 Tobias Geerinckx-Rice via Guix-patches via wrote: > Worse, there's no such thing as =E2=80=98a 5.10=E2=80=99 Linux module tha= t loads=20 > on =E2=80=98a 5.10=E2=80=99 Linux kernel. We still need an easy generic = method to=20 > build modules against their chosen kernel and configuration. >=20 > As your patch illustrates, that already exists: >=20 > > (define (make-linux-zfs linux-libre) > > (package > > (inherit zfs-base) > > (arguments > > `(#:linux ,linux-libre) > > ,@(package-arguments zfs-base)) =20 >=20 > It just belongs in your system.scm, not in Guix itself. Why is this needed? KERNEL-LOADABLE-MODULES are already automatically adapted in this way. See this in gnu/system.scm : (define* (operating-system-directory-base-entries os) "Return the basic entries of the 'system' directory of OS for use as the value of the SYSTEM-SERVICE-TYPE service." (let* ((locale (operating-system-locale-directory os)) (kernel (operating-system-kernel os)) (hurd (operating-system-hurd os)) (modules (operating-system-kernel-loadable-modules os)) (kernel (if hurd kernel (profile (content (packages->manifest (cons kernel (map (lambda (module) (if (package? module) (package-for-kernel kerne= l <----- modul= e) module)) modules)))) (hooks (list linux-module-database))))) (initrd (and (not hurd) (operating-system-initrd-file os))) (params (operating-system-boot-parameters-file os))) `(("kernel" ,kernel) ,@(if hurd `(("hurd" ,hurd)) '()) ("parameters" ,params) ,@(if initrd `(("initrd" ,initrd)) '()) ("locale" ,locale)))) ;used by libc --Sig_/Q/RvIEApKgH6KQhOlJJcvR= Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAl/zHvoACgkQ5xo1VCww uqVN4ggAnf6F7tLDIa3EU200sDCYpVLCX0e+69/Yrio9UiNVtm7wqbjwK9XUelPH +M6FedO9jC29rHv4F1eV0sl9u5sxnuALLW7gO8L6hTRM8DXLpcsfHUB0cJFP8d3h 1LXKJJasu7CaRCC3byYy9vD93o3eBJyz0M39Jalqwwi4KEGz5N53d+wzEx9OKnf6 8nAHbopXePUtt30qW/D2YfirnijjdRuMsaHoYJVSCphT+A1ny3ikuvmOmSDtZttq SImM11fjmljEmbKebyjKflBk97cktS3vKFpjqz2uu0j8u93ACpMYezAeL1r83J2Z UbE8wlCF3xUdKiNiNp/kF78lCw8ZeA== =N9Ts -----END PGP SIGNATURE----- --Sig_/Q/RvIEApKgH6KQhOlJJcvR=--