From: Danny Milosavljevic <dannym@scratchpost.org>
To: 45403@debbugs.gnu.org
Cc: raid5atemyhomework@protonmail.com
Subject: [bug#45403] [PATCH] gnu: zfs: Split into packages specific for each of our major supported kernel versions.
Date: Mon, 4 Jan 2021 14:58:18 +0100 [thread overview]
Message-ID: <20210104145818.0fcd9a0d@scratchpost.org> (raw)
In-Reply-To: <87tusaa5mf.fsf@nckx>
[-- Attachment #1: Type: text/plain, Size: 2151 bytes --]
On Fri, 25 Dec 2020 05:09:44 +0100
Tobias Geerinckx-Rice via Guix-patches via <guix-patches@gnu.org> wrote:
> Worse, there's no such thing as ‘a 5.10’ Linux module that loads
> on ‘a 5.10’ Linux kernel. We still need an easy generic method to
> build modules against their chosen kernel and configuration.
>
> As your patch illustrates, that already exists:
>
> > (define (make-linux-zfs linux-libre)
> > (package
> > (inherit zfs-base)
> > (arguments
> > `(#:linux ,linux-libre)
> > ,@(package-arguments zfs-base))
>
> It just belongs in your system.scm, not in Guix itself.
Why is this needed? KERNEL-LOADABLE-MODULES are already automatically
adapted in this way.
See this in gnu/system.scm :
(define* (operating-system-directory-base-entries os)
"Return the basic entries of the 'system' directory of OS for use as the
value of the SYSTEM-SERVICE-TYPE service."
(let* ((locale (operating-system-locale-directory os))
(kernel (operating-system-kernel os))
(hurd (operating-system-hurd os))
(modules (operating-system-kernel-loadable-modules os))
(kernel (if hurd
kernel
(profile
(content (packages->manifest
(cons kernel
(map (lambda (module)
(if (package? module)
(package-for-kernel kernel <-----
module)
module))
modules))))
(hooks (list linux-module-database)))))
(initrd (and (not hurd) (operating-system-initrd-file os)))
(params (operating-system-boot-parameters-file os)))
`(("kernel" ,kernel)
,@(if hurd `(("hurd" ,hurd)) '())
("parameters" ,params)
,@(if initrd `(("initrd" ,initrd)) '())
("locale" ,locale)))) ;used by libc
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-01-04 13:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-24 10:59 [bug#45403] [PATCH] gnu: zfs: Split into packages specific for each of our major supported kernel versions raid5atemyhomework via Guix-patches via
2020-12-24 20:41 ` Leo Famulari
2020-12-25 1:12 ` raid5atemyhomework via Guix-patches via
2020-12-25 4:09 ` Tobias Geerinckx-Rice via Guix-patches via
2021-01-04 13:58 ` Danny Milosavljevic [this message]
2021-01-04 15:49 ` raid5atemyhomework via Guix-patches via
2021-01-04 16:07 ` raid5atemyhomework via Guix-patches via
2021-01-04 16:32 ` raid5atemyhomework via Guix-patches via
2021-01-08 15:50 ` bug#45403: " raid5atemyhomework via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210104145818.0fcd9a0d@scratchpost.org \
--to=dannym@scratchpost.org \
--cc=45403@debbugs.gnu.org \
--cc=raid5atemyhomework@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).