From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id QNfTMow56l+zPAAA0tVLHw (envelope-from ) for ; Mon, 28 Dec 2020 20:01:16 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 6A2LLow56l++awAAB5/wlQ (envelope-from ) for ; Mon, 28 Dec 2020 20:01:16 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1897C94036A for ; Mon, 28 Dec 2020 20:01:16 +0000 (UTC) Received: from localhost ([::1]:47548 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ktyhe-0003bR-UC for larch@yhetil.org; Mon, 28 Dec 2020 15:01:14 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50244) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ktyhS-0003b5-Ou for guix-patches@gnu.org; Mon, 28 Dec 2020 15:01:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:53649) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ktyhS-0007w4-HA for guix-patches@gnu.org; Mon, 28 Dec 2020 15:01:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ktyhS-0002ub-Gi for guix-patches@gnu.org; Mon, 28 Dec 2020 15:01:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#45498] [PATCH 00/12] Add ocaml-merlin. Resent-From: Julien Lepiller Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 28 Dec 2020 20:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45498 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: pukkamustard Received: via spool by 45498-submit@debbugs.gnu.org id=B45498.160918565011164 (code B ref 45498); Mon, 28 Dec 2020 20:01:02 +0000 Received: (at 45498) by debbugs.gnu.org; 28 Dec 2020 20:00:50 +0000 Received: from localhost ([127.0.0.1]:36960 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ktyhF-0002u0-Uz for submit@debbugs.gnu.org; Mon, 28 Dec 2020 15:00:50 -0500 Received: from lepiller.eu ([89.234.186.109]:58636) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ktyhD-0002tl-0p for 45498@debbugs.gnu.org; Mon, 28 Dec 2020 15:00:48 -0500 Received: from lepiller.eu (localhost [127.0.0.1]) by lepiller.eu (OpenSMTPD) with ESMTP id b65b518b; Mon, 28 Dec 2020 20:00:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lepiller.eu; h=date:from :to:cc:subject:message-id:in-reply-to:references:mime-version :content-type:content-transfer-encoding; s=dkim; bh=CxCQ0RBxZuPr UhyIw0Yg1pBCrXfqsyAsvTZNWdVucvo=; b=j5HOHJfwnvi1ll0i7WKGr5TUykvU 5vJ0jYg5p3eyvjZBxQE0DqnD9xQDMBsJGUAA+hxIITP+Fdc4DNRwB78z0cMA6m6d F5bn1NfQ+VhVBnfXc/JxC+CzYBIiJ0D7jHnL6nEpgtUDuZgs5Sdrs1+meaZ4dNBw 7HYUR5SfvneuXJOGnsBj+ZTQvrueE37qRpWK6C2dK5jJ7iNCf1q+MQV/ShBESirf ukA1NY3B1ZOuQjxeepI7xSL5Ak3E9YJy3v6Uc4u+Kb6KwotN4YRxvi6DivC9/0PO Rr+vfGErSA7cGfu7GKXJylGuTH3RDqBaSFDsvz6XY8d79GM8oZiGqNvnCA== Received: by lepiller.eu (OpenSMTPD) with ESMTPSA id e749e1ca (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Mon, 28 Dec 2020 20:00:44 +0000 (UTC) Date: Mon, 28 Dec 2020 21:00:37 +0100 From: Julien Lepiller Message-ID: <20201228210037.0af6cf8a@tachikoma.lepiller.eu> In-Reply-To: <86pn2tn6mv.fsf@posteo.net> References: <20201228124017.24295-1-pukkamustard@posteo.net> <20201228150655.101e4704@tachikoma.lepiller.eu> <86pn2tn6mv.fsf@posteo.net> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 45498@debbugs.gnu.org Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -1.22 Authentication-Results: aspmx1.migadu.com; dkim=fail (headers rsa verify failed) header.d=lepiller.eu header.s=dkim header.b=j5HOHJfw; dmarc=fail reason="SPF not aligned (relaxed)" header.from=lepiller.eu (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 1897C94036A X-Spam-Score: -1.22 X-Migadu-Scanner: scn0.migadu.com X-TUID: DBcs0Owx/Bjb Le Mon, 28 Dec 2020 19:10:48 +0100, pukkamustard a =C3=A9crit : > Thank you for the feedback! v2 of patch series coming shortly... >=20 > I was not aware of the `ocaml4.07-variant` property. It makes=20 > things a > lot nicer! >=20 > I've added it for `ocaml-markup` and `ocaml-odoc` and also > `ocaml-sexplib0`, `ocaml-parsexp`, `ocaml-base` and=20 > `ocaml-sexplib`. Thank you, it will make things easier to maintain I think :) >=20 > This makes `ocaml4.07-*` vanish from lot of places in favor of > `(package-with-ocaml4.07 *)`. >=20 > > Have you tried updating dune to the latest version that builds=20 > > with > > ocaml 4.07? =20 >=20 > Not yet. For ocaml-markup 1.0.0 the problem is that the dune file > version is set to 2.7. Any dune below 2.7.x will probably not=20 > work. Is this a hard requirement? I think we used to be able to use older dune versions despite this. >=20 > For other packages it might work... >=20 > > =20 > >> > >> This is quite cumbersome as two trees of OCaml packages need=20 > >> to be > >> maintained. =20 > > > > Actually 3, there are ocaml 4.07, 4.09 and 4.11 currently. I'm=20 > > working > > on a bootstrap for ocaml 4.07 (ocaml builds from a binary=20 > > version of > > itself), so I don't think it'll disappear soon, but at least we=20 > > can try > > and make ocaml4.07-* packages disappear :) > > =20 >=20 > \o/ Looking forward to the bootstrap! Yay, it should become reality in the next few months. Currently we target ocaml 4.07 because it's the last version that doesn't require merlin; after that we should be able to use ocaml4.07-merlin to build the parser for more recent versions. > With the `ocaml4.*-variant` property managing the 3 trees does not=20 > seem > so bad after all. >=20 > Currently there are a lot of packages only for 4.07. It would be=20 > nicer > to have packages for default compiler and when needed variants for=20 > older > compilers. This is for historical reasons: we had these packages with ocaml 4.07, and only for those packages that still require ocaml 4.07. More recent versions of these packages have a different dependency tree, which makes it hard to maintain both trees at the same time, especially as there is no version that supports any two of our ocaml compilers at the same time. > I plan to do some OCaml hacking in the next months and will send=20 > in > patches toward this, if that is ok. That would be very appreciated! > >> - Some OCaml libraries have dependencies in `inputs` that seem=20 > >> to be > >> required from packages using the libraries. E.g.=20 > >> `ocaml-yojson` > >> depends on `ocaml-biniou`. Packages depending on `ocaml-yojson`=20 > >> need > >> to manually add `ocaml-biniou` to their inputs. Would it=20 > >> work/make > >> sense to add `ocaml-biniou` to `propagated-inputs` of=20 > >> `ocaml-yojson`? =20 > > > > Yeah, could you provide an additional patch for that? =20 >=20 > Done. Patch 13 in v2. Could you instead put this as patch 12, and add merlin as patch 13? That way you don't have to add the dependencies in merlin and remove them in the following patch. Also, patch 12 adds ocaml-dot-merlin-reader and ocaml-merlin. could you separate it in two separate patches? I'm also wondering if we should call this package "merlin" instead of ocaml-merlin, since it provides a binary of that name? >=20 > -pukkamustard >=20