From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id GBPmG8vm6V+AIgAA0tVLHw (envelope-from ) for ; Mon, 28 Dec 2020 14:08:11 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id KCXDF8vm6V9LUAAA1q6Kng (envelope-from ) for ; Mon, 28 Dec 2020 14:08:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0241C9404C8 for ; Mon, 28 Dec 2020 14:08:11 +0000 (UTC) Received: from localhost ([::1]:54092 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kttBx-0004Y9-Ru for larch@yhetil.org; Mon, 28 Dec 2020 09:08:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:36422) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kttBq-0004Xw-8N for guix-patches@gnu.org; Mon, 28 Dec 2020 09:08:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:51355) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kttBq-0005xe-1N for guix-patches@gnu.org; Mon, 28 Dec 2020 09:08:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kttBp-0005vo-RW for guix-patches@gnu.org; Mon, 28 Dec 2020 09:08:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#34412] [bug#45498] [PATCH 00/12] Add ocaml-merlin. Resent-From: Julien Lepiller Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 28 Dec 2020 14:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34412 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: pukkamustard Received: via spool by 34412-submit@debbugs.gnu.org id=B34412.160916442922738 (code B ref 34412); Mon, 28 Dec 2020 14:08:01 +0000 Received: (at 34412) by debbugs.gnu.org; 28 Dec 2020 14:07:09 +0000 Received: from localhost ([127.0.0.1]:34668 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kttAy-0005uf-Vd for submit@debbugs.gnu.org; Mon, 28 Dec 2020 09:07:09 -0500 Received: from lepiller.eu ([89.234.186.109]:58612) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kttAw-0005uM-DK; Mon, 28 Dec 2020 09:07:07 -0500 Received: from lepiller.eu (localhost [127.0.0.1]) by lepiller.eu (OpenSMTPD) with ESMTP id eff938db; Mon, 28 Dec 2020 14:07:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lepiller.eu; h=date:from :to:cc:subject:message-id:in-reply-to:references:mime-version :content-type:content-transfer-encoding; s=dkim; bh=cxORErbEDRx6 OzQGOBkt/a4Ut25ot8cLY1g2cWa7jRA=; b=daxNnhDaJOK87s437tpKL3CfeNDx m9Adbktk+LlvDht81/QSz6UcuodW4fISsCONZago+sgg4IDvtqhBwwzLphjh5wjc dcHST0pRJ8ANqzkHuLNksxL8cCxfmyQmCKiaCUkaWcfADpXMhRXLWQ+9aHksoI2Q GsUMFy9259WXXPjjy72j9o0y1hSWU52OCyWeSZYlUeAI/BNv992RO3ndtgbvNUt5 c/QvrS3FxIf7vn6QxYAcGK7lR8L06XDe2jgnOW5utjo6gV5I5h8nIafiMBL0L47r pPFI2IsaTlOvzK/+6EwZi/P5ejQS8Jh3l4OpDcZKpMqdGR6H1hU0bT8D9Q== Received: by lepiller.eu (OpenSMTPD) with ESMTPSA id 131c7be1 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Mon, 28 Dec 2020 14:07:04 +0000 (UTC) Date: Mon, 28 Dec 2020 15:06:55 +0100 From: Julien Lepiller Message-ID: <20201228150655.101e4704@tachikoma.lepiller.eu> In-Reply-To: <20201228124017.24295-1-pukkamustard@posteo.net> References: <20201228124017.24295-1-pukkamustard@posteo.net> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 45498@debbugs.gnu.org, 34412@debbugs.gnu.org Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -1.22 Authentication-Results: aspmx1.migadu.com; dkim=fail (headers rsa verify failed) header.d=lepiller.eu header.s=dkim header.b=daxNnhDa; dmarc=fail reason="SPF not aligned (relaxed)" header.from=lepiller.eu (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 0241C9404C8 X-Spam-Score: -1.22 X-Migadu-Scanner: scn0.migadu.com X-TUID: szB+Pq0izdZw Le Mon, 28 Dec 2020 13:40:17 +0100, pukkamustard a =C3=A9crit : > Hi Guix, >=20 > This adds ocaml-merlin, a development tool for OCaml (and > dependencies). Thanks for the patches! >=20 > Some notes and questions: >=20 > - ocaml4.07-merlin is already available (version 3.2.2). This version > has not been updated (but changed to inherit from ocaml-merlin). >=20 > - There are many ocaml4.07-* packages in Guix. The reason for this is > that some packages need to be built with OCaml 4.07 but some newer > versions of libraries do no longer support OCaml 4.07 (or the old > version of dune), requiring older versions of the same packages. See > also commit message 9ada1555. Have you tried updating dune to the latest version that builds with ocaml 4.07? >=20 > This is quite cumbersome as two trees of OCaml packages need to be > maintained. Actually 3, there are ocaml 4.07, 4.09 and 4.11 currently. I'm working on a bootstrap for ocaml 4.07 (ocaml builds from a binary version of itself), so I don't think it'll disappear soon, but at least we can try and make ocaml4.07-* packages disappear :) >=20 > A nice solution would be to upgrade packages requiring OCaml 4.07 > to also build with the default OCaml (4.11). Packages that are not > dependencies of other packages that require OCaml 4.07 seem to be: > `bap`, `ocaml-earley` and `pplacer`. Maybe this should be opened as > an issue? pretty sure they build with at least ocaml-4.09 now, I'll see what I can do :) >=20 > - Some OCaml libraries have dependencies in `inputs` that seem to be > required from packages using the libraries. E.g. `ocaml-yojson` > depends on `ocaml-biniou`. Packages depending on `ocaml-yojson` need > to manually add `ocaml-biniou` to their inputs. Would it work/make > sense to add `ocaml-biniou` to `propagated-inputs` of `ocaml-yojson`? Yeah, could you provide an additional patch for that? >=20 > - Test for ocaml-merlin (version 3.4.2) work. This resolves issue > #34412 (alltough ocaml4.07-merlin still can not run tests). >=20 > Thanks! > -pukkamustard Thank you! I've sent some remarks to your patches, but generally LGTM :) >=20 > pukkamustard (12): > gnu: Remove ocaml-js-build-tools. > gnu: Add ocaml-sexplib. > gnu: Add ocaml-base. > gnu: Add ocaml-parsexp. > gnu: Add ocaml-sexplib. > gnu: Add ocaml-ounit2. > gnu: ocaml-tyxml: Update to 4.4.0. > gnu: ocaml-markup: Update to 1.0.0. > gnu: Add ocaml-odoc. > gnu: Add ocaml-version. > gnu: Add ocaml-mdx. > gnu: Add ocaml-merlin. >=20 > gnu/packages/ocaml.scm | 527 > ++++++++++++++++++++++++++++------------- 1 file changed, 359 > insertions(+), 168 deletions(-) >=20