From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id +rU0Fn8o1l9DSQAA0tVLHw (envelope-from ) for ; Sun, 13 Dec 2020 14:43:11 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id IHN5EX8o1l+NfQAAbx9fmQ (envelope-from ) for ; Sun, 13 Dec 2020 14:43:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E4755940355 for ; Sun, 13 Dec 2020 14:43:10 +0000 (UTC) Received: from localhost ([::1]:36490 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1koSab-0005w6-PB for larch@yhetil.org; Sun, 13 Dec 2020 09:43:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:57886) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1koSaU-0005vx-O4 for guix-patches@gnu.org; Sun, 13 Dec 2020 09:43:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:36281) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1koSaU-0006AH-Fd for guix-patches@gnu.org; Sun, 13 Dec 2020 09:43:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1koSaU-0004v9-Bf for guix-patches@gnu.org; Sun, 13 Dec 2020 09:43:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#41066] [PATCH] gnu: bootloader: Improve support for chain loading. Resent-From: Danny Milosavljevic Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 13 Dec 2020 14:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41066 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Stefan Received: via spool by 41066-submit@debbugs.gnu.org id=B41066.160787054118864 (code B ref 41066); Sun, 13 Dec 2020 14:43:02 +0000 Received: (at 41066) by debbugs.gnu.org; 13 Dec 2020 14:42:21 +0000 Received: from localhost ([127.0.0.1]:47827 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1koSZp-0004uC-7C for submit@debbugs.gnu.org; Sun, 13 Dec 2020 09:42:21 -0500 Received: from dd26836.kasserver.com ([85.13.145.193]:54410) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1koSZn-0004u3-AM for 41066@debbugs.gnu.org; Sun, 13 Dec 2020 09:42:19 -0500 Received: from localhost (80-110-125-229.cgn.dynamic.surfer.at [80.110.125.229]) by dd26836.kasserver.com (Postfix) with ESMTPSA id 55E61336389B; Sun, 13 Dec 2020 15:42:17 +0100 (CET) Date: Sun, 13 Dec 2020 15:42:14 +0100 From: Danny Milosavljevic Message-ID: <20201213154149.47423b18@scratchpost.org> In-Reply-To: <7FDE10B2-EA52-4598-AE22-25181DE76A86@vodafonemail.de> References: <7A4ABEA8-4500-4D55-BCCE-BFB37FB06B2C@vodafonemail.de> <20200524131316.4c6e8a50@scratchpost.org> <3197004D-0131-4781-99FD-60EBE434E794@vodafonemail.de> <023CBBED-35CD-4AD3-97C4-0DE0B7623B9A@vodafonemail.de> <6E5ECFBA-57F4-485F-9403-1D04CF82062D@vodafonemail.de> <4D71A75A-5722-457C-A5CE-98CE51A53450@vodafonemail.de> <975EC414-6A81-444B-9BB0-AE303C6A9511@vodafonemail.de> <20201116103346.55ff8422@scratchpost.org> <20201117164755.1a27422b@scratchpost.org> <20201118190559.1f9fed82@scratchpost.org> <10AB4620-ECD3-4199-A9E4-CE0F906AC3BE@vodafonemail.de> <98EF392F-E84E-4CEB-8166-C28D16552057@vodafonemail.de> <7FDE10B2-EA52-4598-AE22-25181DE76A86@vodafonemail.de> X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/mLZZU7aJUGcgMbcUDlWNUSM"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 41066@debbugs.gnu.org, Mathieu Othacehe Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.40 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: E4755940355 X-Spam-Score: -2.40 X-Migadu-Scanner: scn1.migadu.com X-TUID: 6j2XrWnc6UFJ --Sig_/mLZZU7aJUGcgMbcUDlWNUSM Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi Stefan, thanks! Like mentioned in recent e-mails on the mailing list by Mark Weaver (in gen= eral, not to you), please seperate cosmetic patches from non-cosmetic patches. This is mostly so users can see which commits change what and why without having to read through unrelated stuff. Your latest patch does: (1) Export chain-bootloader-installer. I totally agree with Ludo's earlier comment in that this is not the right abstraction for GENERAL bootloader chaining (which would be a LOT more difficult/impossible to do). Regardless, since we want to use this for efi-bootloader-chain, that should= be called "efi-chain-bootloader-installer" instead. I'm not sure whether "efi-bootloader-chain-installer" would be better (use whatever you think is best)--in any case, please do not make it seem like this function is in any way generic, which it is absolutely not. It only works if there is a special partition which contains the bootloader, which is not a given (and was pretty uncommon until a few years ago--a bootloader on a FILESYSTEM? What? :) ). (2) efi-bootloader-profile cosmetic comment and import cleanup. Also, some more cosmetic comment cleanup in some other procedure. Please use extra patch(es). (3) Definition of procedure chain-bootloader-installer. This procedure does not fail if the conditions are weird (collection is not a directory, bootloader-target is not a directory). If there is no good reason for that, please use (error "...") to make it fail instead of silently continuing. If there are good reasons, nevermind. Since this is merely moving the existing procedure, please, if you do these changes I suggest, do those in an extra commit (so the moving commit is clearing only moving the procedure, not changing it). (4) gnu/bootloader/grub.scm font installer doesn't use symlinks anymore. Fine, but maybe also make an extra patch for that. Please use your judgeme= nt. --Sig_/mLZZU7aJUGcgMbcUDlWNUSM Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAl/WKEYACgkQ5xo1VCww uqWjvwgAkxIFOwSz3bhI589vJaKtS9yGMYGcrXzA2Hd0EXk315u/RD2xyfGu3D3a BSSIhloPqDtWuMFVU9P6PQrYaFgclULyVPRREBLxvViePW1HZxThqfjit9Wvxnbm eP8ywx7mPSxePeFIpMfVWcOFhrNvcpK2Ogpogq/qX8lMTTLD2uin/BVaBnn+reLf tfEkLRRzRMEQQAZvgI5SfJz/bJCNDCLIS6iFpSrUsHXh7VU9sTCprkGmsQUvLo4m 6gTc24UBqHyLamKV2saxvnHZeFhIT5KeBUlFB2/QRAj5hN0jlp7+YRntrHcw/EO5 IG9vYX/MGKXNBlaPeL9M8sbH6Fg8sQ== =/w0+ -----END PGP SIGNATURE----- --Sig_/mLZZU7aJUGcgMbcUDlWNUSM--