From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 2FFCET64wl/yAgAA0tVLHw (envelope-from ) for ; Sat, 28 Nov 2020 20:51:10 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id mGUTDT64wl+0bwAA1q6Kng (envelope-from ) for ; Sat, 28 Nov 2020 20:51:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 073E59404C4 for ; Sat, 28 Nov 2020 20:51:10 +0000 (UTC) Received: from localhost ([::1]:52036 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kj7BV-00010K-0H for larch@yhetil.org; Sat, 28 Nov 2020 15:51:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:47780) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kj7BO-0000zq-Hk for guix-patches@gnu.org; Sat, 28 Nov 2020 15:51:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:37658) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kj7BO-0004eG-9Q for guix-patches@gnu.org; Sat, 28 Nov 2020 15:51:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kj7BO-0003Uy-8D for guix-patches@gnu.org; Sat, 28 Nov 2020 15:51:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#44926] [WIP] Add dart-2.8.4 Resent-From: Julien Lepiller Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 28 Nov 2020 20:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44926 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: =?UTF-8?Q?Nicol=C3=B2?= Balzarotti Cc: 44926@debbugs.gnu.org Received: via spool by 44926-submit@debbugs.gnu.org id=B44926.160659663713419 (code B ref 44926); Sat, 28 Nov 2020 20:51:02 +0000 Received: (at 44926) by debbugs.gnu.org; 28 Nov 2020 20:50:37 +0000 Received: from localhost ([127.0.0.1]:49204 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kj7Ay-0003UM-T6 for submit@debbugs.gnu.org; Sat, 28 Nov 2020 15:50:37 -0500 Received: from lepiller.eu ([89.234.186.109]:55516) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kj7Av-0003UC-4l for 44926@debbugs.gnu.org; Sat, 28 Nov 2020 15:50:35 -0500 Received: from lepiller.eu (localhost [127.0.0.1]) by lepiller.eu (OpenSMTPD) with ESMTP id a42eae1b; Sat, 28 Nov 2020 20:50:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lepiller.eu; h=date:from :to:cc:subject:message-id:in-reply-to:references:mime-version :content-type:content-transfer-encoding; s=dkim; bh=XM829mDOzL29 nxxIo0/kY2xnRLpK8LBoynrvcDOV1hE=; b=MA9WQtp7Y/XChOLqGfCMJN0S5X6/ P3t+KPc7I3YIhgu+DrK5Ie3bmwzp3akLGFq/NDHiWmRh3S0jzPrY88kJjk2sWIgy vLMF/G27SE84S70d4mG9Hx/YZqF1d40HH/W96flVc0XXbRigfM9s7uR861Dgr6gD jTPMWuM4yjwBEVuLaIo9XogFmtdYD/wPYWiNYZh6m2gjIh6z/uPCU6kNPpbjB8aO OrO5tOy0+428vqkyz8ORsXRSEyiRPUdLsC01KUK1iuiUVUouy5KwJk5tzuN0Xymb cLcUD/h5+bnxRFn8nTX9fIL+1TPBo1tjiOf+g0sXymPGMSLLQubvOEe1Yw== Received: by lepiller.eu (OpenSMTPD) with ESMTPSA id 8faebd38 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Sat, 28 Nov 2020 20:50:30 +0000 (UTC) Date: Sat, 28 Nov 2020 21:50:20 +0100 From: Julien Lepiller Message-ID: <20201128215020.39ddb709@tachikoma.lepiller.eu> In-Reply-To: <87lfelqrni.fsf@guixSD.i-did-not-set--mail-host-address--so-tickle-me> References: <87lfelqrni.fsf@guixSD.i-did-not-set--mail-host-address--so-tickle-me> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -1.17 X-Scanner: ns3122888.ip-94-23-21.eu Authentication-Results: aspmx1.migadu.com; dkim=fail (headers rsa verify failed) header.d=lepiller.eu header.s=dkim header.b=MA9WQtp7; dmarc=fail reason="SPF not aligned (relaxed)" header.from=lepiller.eu (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-TUID: Ywwys5FfcWts Le Sat, 28 Nov 2020 19:10:09 +0100, Nicol=C3=B2 Balzarotti a =C3=A9crit : > Hi Guix! > As announced on guix-devel, I bootstrapped the dart compiler from > source. >=20 > Following patches add dart 2.8.4 (latest release is 2.10, but I wanted > to be sure that this work in progress is fine before continuing, as I > fear that 4 other steps are required). >=20 > NOTE: I tagged this as WIP as I've not yet disabled analytics yet (I > disabled it from the first added version, but I was wondering if I > need to disable it in _each_ version or if just the latest one is > fine. Patching all of them will require some time). >=20 > (Each build takes ~20min on my server and ~60min on my laptop, and > there's a dozen of them) >=20 > Let me know if there are major problems or if I can go on with > disabling analytics! >=20 > Thanks, Nicol=C3=B2 >=20 Impressive :) I can see a few issues in terms of style in these patches, but looking at the first dart version, it looks like it's going to work :) So, instead of using dart-zlib, dart-boringssl, ..., I'd recommend changing dart-pkg to something like this: (define* (dart-pkg name tag hash #:optional (url (string-append "https://github.com/dart-lang/" (string-replace-substring name "-" "_") ".git"))) (origin (method git-fetch) (uri (git-reference (url url) (commit tag))) ...)) That way, dart-zlib, ... also have a proper file name ;) I don't really like the fact that the build system simply bundles these dependencies instead of link dynamically to them, but I guess it's hard to do anything for that, and for bootstrap versions, I don't think it's too much of an issue. You should also make sure to clean up your patches: for instance patch 8 modifies things you've added before (I think it's only because of whitespace, but that's not clean). Thank you!