From: zimoun <zimon.toutoune@gmail.com>
To: 44931@debbugs.gnu.org
Cc: zimoun <zimon.toutoune@gmail.com>
Subject: [bug#44931] [PATCH 0/1] upgrade: Allow several regexps (fix #44928).
Date: Sat, 28 Nov 2020 21:26:31 +0100 [thread overview]
Message-ID: <20201128202631.27734-1-zimon.toutoune@gmail.com> (raw)
Dear,
Fixes <https://bugs.gnu.org/44928> describing that the 2nd raises an error:
$ guix upgrade foo bar
guix upgrade: error: bar: extraneous argument
And it is not the case with "guix package -u foo bar". I am not convinced by
the patch but after thinking a bit, the 'match' does not seem necessary
because the options are correctly handled by SRFI-37 and any extra term is
potentially an other regexp. The 'opts' is correctly formed and then
"guix-package" does all the job.
Well, I have been too lazy to create something in the test suite; someone
should do. :-) Testing "guix package --upgrade" and "guix upgrade". Maybe a
v2 of this tiny patch? ;-)
Feedback welcome.
All the best,
simon
zimoun (1):
upgrade: Allow several regexps.
guix/scripts/upgrade.scm | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
base-commit: 8ea2d7c2fa4d4ad7b4cf522fa259561beeeda072
--
2.29.2
next reply other threads:[~2020-11-28 20:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-28 20:26 zimoun [this message]
2020-11-28 20:32 ` [bug#44931] [PATCH 1/1] upgrade: Allow several regexps zimoun
2020-12-01 10:36 ` bug#44931: " Mathieu Othacehe
2020-12-01 12:42 ` [bug#44931] " zimoun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201128202631.27734-1-zimon.toutoune@gmail.com \
--to=zimon.toutoune@gmail.com \
--cc=44931@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).