unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Efraim Flashner <efraim@flashner.co.il>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: Vinicius Monego <monego@posteo.net>, 44786@debbugs.gnu.org
Subject: [bug#44786] [PATCH] gnu: Add python-xlsxwriter.
Date: Wed, 25 Nov 2020 09:37:52 +0200	[thread overview]
Message-ID: <20201125073752.GA24491@E5400> (raw)
In-Reply-To: <87360yrk1p.fsf@nicolasgoaziou.fr>

[-- Attachment #1: Type: text/plain, Size: 926 bytes --]

On Tue, Nov 24, 2020 at 01:55:30PM +0100, Nicolas Goaziou wrote:
> Hello,
> 
> Vinicius Monego <monego@posteo.net> writes:
> 
> > * gnu/packages/python-xyz.scm (python-xlsxwriter): New variable.
> 
> Thank you.
> 
> > +       ;; There are no tests in the PyPI tarball.
> > +       (method git-fetch)
> 
> Is this the sole reason to not use PyPI here? If that's the case,
> I wonder if it's worth reconsidering, because using PyPI makes updates
> easier.
> 
> WDYT?
> 

It is standard for us to use a git checkout when the pypi release
doesn't have the tests packaged. It's not uncommon for python packages
to build correctly but fail to run, and the test suite almost always
catches those.

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  parent reply	other threads:[~2020-11-25  8:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-22  2:40 [bug#44786] [PATCH] gnu: Add python-xlsxwriter Vinicius Monego
2020-11-24 12:55 ` Nicolas Goaziou
2020-11-24 21:25   ` Vinicius Monego
2020-11-25  7:37   ` Efraim Flashner [this message]
2020-11-26 13:48     ` bug#44786: " Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201125073752.GA24491@E5400 \
    --to=efraim@flashner.co.il \
    --cc=44786@debbugs.gnu.org \
    --cc=mail@nicolasgoaziou.fr \
    --cc=monego@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).