unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / Atom feed
* [bug#44786] [PATCH] gnu: Add python-xlsxwriter.
@ 2020-11-22  2:40 Vinicius Monego
  2020-11-24 12:55 ` Nicolas Goaziou
  0 siblings, 1 reply; 5+ messages in thread
From: Vinicius Monego @ 2020-11-22  2:40 UTC (permalink / raw)
  To: 44786; +Cc: Vinicius Monego

* gnu/packages/python-xyz.scm (python-xlsxwriter): New variable.
---
 gnu/packages/python-xyz.scm | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 32235c22a1..0d53797a36 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -5851,6 +5851,28 @@ a front-end for C compilers or analysis tools.")
 (define-public python2-pycparser
   (package-with-python2 python-pycparser))
 
+(define-public python-xlsxwriter
+  (package
+    (name "python-xlsxwriter")
+    (version "1.3.7")
+    (source
+     (origin
+       ;; There are no tests in the PyPI tarball.
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/jmcnamara/XlsxWriter")
+             (commit (string-append "RELEASE_" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "1qg40r2mwrqfmhaxnary1cfgi0dwwazp5qga7c9p2cdji2v0x5rm"))))
+    (build-system python-build-system)
+    (home-page "https://github.com/jmcnamara/XlsxWriter")
+    (synopsis "Python module for creating Excel XLSX files")
+    (description
+     "XlsxWriter is a Python module that can be used to write text, numbers,
+formulas and hyperlinks to multiple worksheets in an Excel 2007+ XLSX file.")
+    (license license:bsd-2)))
+
 (define-public python-pywavelets
   (package
     (name "python-pywavelets")
-- 
2.20.1





^ permalink raw reply	[flat|nested] 5+ messages in thread

* [bug#44786] [PATCH] gnu: Add python-xlsxwriter.
  2020-11-22  2:40 [bug#44786] [PATCH] gnu: Add python-xlsxwriter Vinicius Monego
@ 2020-11-24 12:55 ` Nicolas Goaziou
  2020-11-24 21:25   ` Vinicius Monego
  2020-11-25  7:37   ` Efraim Flashner
  0 siblings, 2 replies; 5+ messages in thread
From: Nicolas Goaziou @ 2020-11-24 12:55 UTC (permalink / raw)
  To: Vinicius Monego; +Cc: 44786

Hello,

Vinicius Monego <monego@posteo.net> writes:

> * gnu/packages/python-xyz.scm (python-xlsxwriter): New variable.

Thank you.

> +       ;; There are no tests in the PyPI tarball.
> +       (method git-fetch)

Is this the sole reason to not use PyPI here? If that's the case,
I wonder if it's worth reconsidering, because using PyPI makes updates
easier.

WDYT?

Regards,
-- 
Nicolas Goaziou




^ permalink raw reply	[flat|nested] 5+ messages in thread

* [bug#44786] [PATCH] gnu: Add python-xlsxwriter.
  2020-11-24 12:55 ` Nicolas Goaziou
@ 2020-11-24 21:25   ` Vinicius Monego
  2020-11-25  7:37   ` Efraim Flashner
  1 sibling, 0 replies; 5+ messages in thread
From: Vinicius Monego @ 2020-11-24 21:25 UTC (permalink / raw)
  To: Nicolas Goaziou; +Cc: 44786


Hello,

Nicolas Goaziou writes:

> Hello,
>
> Vinicius Monego <monego@posteo.net> writes:
>
>> * gnu/packages/python-xyz.scm (python-xlsxwriter): New variable.
>
> Thank you.
>
>> +       ;; There are no tests in the PyPI tarball.
>> +       (method git-fetch)
>
> Is this the sole reason to not use PyPI here? If that's the case,
> I wonder if it's worth reconsidering, because using PyPI makes updates
> easier.
>
> WDYT?

That is the sole reason. I prefer to enable tests because Python lacks
setup-time checking. Without tests, the build would succeed even if core
dependencies are unmet.

How does PyPI make updates easier, though? Refreshing works on GitHub.




^ permalink raw reply	[flat|nested] 5+ messages in thread

* [bug#44786] [PATCH] gnu: Add python-xlsxwriter.
  2020-11-24 12:55 ` Nicolas Goaziou
  2020-11-24 21:25   ` Vinicius Monego
@ 2020-11-25  7:37   ` Efraim Flashner
  2020-11-26 13:48     ` bug#44786: " Nicolas Goaziou
  1 sibling, 1 reply; 5+ messages in thread
From: Efraim Flashner @ 2020-11-25  7:37 UTC (permalink / raw)
  To: Nicolas Goaziou; +Cc: Vinicius Monego, 44786

[-- Attachment #1: Type: text/plain, Size: 926 bytes --]

On Tue, Nov 24, 2020 at 01:55:30PM +0100, Nicolas Goaziou wrote:
> Hello,
> 
> Vinicius Monego <monego@posteo.net> writes:
> 
> > * gnu/packages/python-xyz.scm (python-xlsxwriter): New variable.
> 
> Thank you.
> 
> > +       ;; There are no tests in the PyPI tarball.
> > +       (method git-fetch)
> 
> Is this the sole reason to not use PyPI here? If that's the case,
> I wonder if it's worth reconsidering, because using PyPI makes updates
> easier.
> 
> WDYT?
> 

It is standard for us to use a git checkout when the pypi release
doesn't have the tests packaged. It's not uncommon for python packages
to build correctly but fail to run, and the test suite almost always
catches those.

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#44786: [PATCH] gnu: Add python-xlsxwriter.
  2020-11-25  7:37   ` Efraim Flashner
@ 2020-11-26 13:48     ` Nicolas Goaziou
  0 siblings, 0 replies; 5+ messages in thread
From: Nicolas Goaziou @ 2020-11-26 13:48 UTC (permalink / raw)
  To: Efraim Flashner; +Cc: Vinicius Monego, 44786-done

Hello,

Efraim Flashner <efraim@flashner.co.il> writes:

> It is standard for us to use a git checkout when the pypi release
> doesn't have the tests packaged.

I had not heard about this standard before. Considering many Python
packages are imported through PyPI, I genuinely wonder how common this
custom is, tho.

Fair enough. I applied the patch. Thank you!

Regards,
-- 
Nicolas Goaziou




^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2020-11-26 13:49 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-22  2:40 [bug#44786] [PATCH] gnu: Add python-xlsxwriter Vinicius Monego
2020-11-24 12:55 ` Nicolas Goaziou
2020-11-24 21:25   ` Vinicius Monego
2020-11-25  7:37   ` Efraim Flashner
2020-11-26 13:48     ` bug#44786: " Nicolas Goaziou

unofficial mirror of guix-patches@gnu.org 

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://yhetil.org/guix-patches/1 guix-patches/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 guix-patches guix-patches/ https://yhetil.org/guix-patches \
		guix-patches@gnu.org
	public-inbox-index guix-patches

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://news.yhetil.org/yhetil.gnu.guix.patches


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git