unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / Atom feed
* [bug#44781] Dino
@ 2020-11-21 18:40 Raghav Gururajan
  2020-11-22  1:08 ` [bug#44781] Dino (v2) Raghav Gururajan
  0 siblings, 1 reply; 3+ messages in thread
From: Raghav Gururajan @ 2020-11-21 18:40 UTC (permalink / raw)
  To: 44781


[-- Attachment #1.1.1: Type: text/plain, Size: 69 bytes --]

Hello Guix!

Please find the attached patch-set.

Regards,
RG.

[-- Attachment #1.1.2: 0001-gnu-dino-Make-some-cosmetic-changes.patch --]
[-- Type: text/x-patch, Size: 2768 bytes --]

From 55aa0d8d546fe2b67651042461bb23145c3a1393 Mon Sep 17 00:00:00 2001
From: Raghav Gururajan <raghavgururajan@disroot.org>
Date: Sat, 21 Nov 2020 13:13:49 -0500
Subject: [PATCH 1/4] gnu: dino: Make some cosmetic changes.

* gnu/packages/messaging.scm (dino): Make some cosmetic changes.
---
 gnu/packages/messaging.scm | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
index 9a2034f253..b60922e809 100644
--- a/gnu/packages/messaging.scm
+++ b/gnu/packages/messaging.scm
@@ -932,19 +932,19 @@ Encryption to Gajim.")
   (package
     (name "dino")
     (version "0.2.0")
-    (outputs '("out" "debug"))
     (source
      (origin
        (method url-fetch)
-       (uri (string-append "https://github.com/dino/dino/releases/download/v"
-                           version "/dino-" version ".tar.gz"))
+       (uri
+        (string-append "https://github.com/dino/dino/releases/download/v"
+                       version "/dino-" version ".tar.gz"))
        (sha256
-        (base32
-         "0iigh7bkil6prf02dqcl6lmd89jxz685h8lqr3ni4x39zkcransn"))))
+        (base32 "0iigh7bkil6prf02dqcl6lmd89jxz685h8lqr3ni4x39zkcransn"))))
     (build-system cmake-build-system)
+    (outputs '("out" "debug"))
     (arguments
      `(#:tests? #f
-       #:parallel-build? #f ; not supported
+       #:parallel-build? #f             ; not supported
        #:modules ((guix build cmake-build-system)
                   ((guix build glib-or-gtk-build-system) #:prefix glib-or-gtk:)
                   (guix build utils))
@@ -955,6 +955,11 @@ Encryption to Gajim.")
        (modify-phases %standard-phases
          (add-after 'install 'glib-or-gtk-wrap
            (assoc-ref glib-or-gtk:%standard-phases 'glib-or-gtk-wrap)))))
+    (native-inputs
+     `(("pkg-config" ,pkg-config)
+       ("glib" ,glib "bin")
+       ("vala" ,vala)
+       ("gettext" ,gettext-minimal)))
     (inputs
      `(("libgee" ,libgee)
        ("libsignal-protocol-c" ,libsignal-protocol-c)
@@ -966,15 +971,10 @@ Encryption to Gajim.")
        ("gtk+" ,gtk+)
        ("glib-networking" ,glib-networking)
        ("gsettings-desktop-schemas" ,gsettings-desktop-schemas)))
-    (native-inputs
-     `(("pkg-config" ,pkg-config)
-       ("glib" ,glib "bin")
-       ("vala" ,vala)
-       ("gettext" ,gettext-minimal)))
-    (home-page "https://dino.im")
     (synopsis "Graphical Jabber (XMPP) client")
     (description "Dino is a Jabber (XMPP) client which aims to fit well into
 a graphical desktop environment like GNOME.")
+    (home-page "https://dino.im")
     (license license:gpl3+)))
 
 (define-public prosody
-- 
2.29.2


[-- Attachment #1.1.3: 0002-gnu-dino-Update-synopsis-and-description.patch --]
[-- Type: text/x-patch, Size: 1271 bytes --]

From f4bbc73b45b431917e4f9021777c1141d754ac1a Mon Sep 17 00:00:00 2001
From: Raghav Gururajan <raghavgururajan@disroot.org>
Date: Sat, 21 Nov 2020 13:17:52 -0500
Subject: [PATCH 2/4] gnu: dino: Update synopsis and description.

* gnu/packages/messaging.scm (dino) [synopsis]: Modify.
[description]: Modify.
---
 gnu/packages/messaging.scm | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
index b60922e809..0cfc380643 100644
--- a/gnu/packages/messaging.scm
+++ b/gnu/packages/messaging.scm
@@ -971,9 +971,10 @@ Encryption to Gajim.")
        ("gtk+" ,gtk+)
        ("glib-networking" ,glib-networking)
        ("gsettings-desktop-schemas" ,gsettings-desktop-schemas)))
-    (synopsis "Graphical Jabber (XMPP) client")
-    (description "Dino is a Jabber (XMPP) client which aims to fit well into
-a graphical desktop environment like GNOME.")
+    (synopsis "Mordern Jabber/XMPP Client using GTK+/Vala")
+    (description "Dino is a modern chat client for the desktop.  It focuses on
+providing a clean and reliable Jabber/XMPP experience while having your privacy
+in mind.")
     (home-page "https://dino.im")
     (license license:gpl3+)))
 
-- 
2.29.2


[-- Attachment #1.1.4: 0003-gnu-dino-Re-arrange-inputs-in-alphabetical-order.patch --]
[-- Type: text/x-patch, Size: 1939 bytes --]

From f17d03f041f9e6790347d6446ac5109e7d00f4fc Mon Sep 17 00:00:00 2001
From: Raghav Gururajan <raghavgururajan@disroot.org>
Date: Sat, 21 Nov 2020 13:24:34 -0500
Subject: [PATCH 3/4] gnu: dino: Re-arrange inputs in alphabetical order.

* gnu/packages/messaging.scm (dino) [native-inputs]: Re-order.
[inputs]: Re-order.
---
 gnu/packages/messaging.scm | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
index 0cfc380643..15848a9511 100644
--- a/gnu/packages/messaging.scm
+++ b/gnu/packages/messaging.scm
@@ -956,21 +956,21 @@ Encryption to Gajim.")
          (add-after 'install 'glib-or-gtk-wrap
            (assoc-ref glib-or-gtk:%standard-phases 'glib-or-gtk-wrap)))))
     (native-inputs
-     `(("pkg-config" ,pkg-config)
+     `(("gettext" ,gettext-minimal)
        ("glib" ,glib "bin")
-       ("vala" ,vala)
-       ("gettext" ,gettext-minimal)))
+       ("pkg-config" ,pkg-config)
+       ("vala" ,vala)))
     (inputs
-     `(("libgee" ,libgee)
-       ("libsignal-protocol-c" ,libsignal-protocol-c)
+     `(("glib-networking" ,glib-networking)
+       ("gpgme" ,gpgme)
+       ("gsettings-desktop-schemas" ,gsettings-desktop-schemas)
+       ("gtk+" ,gtk+)
+       ("libgee" ,libgee)
        ("libgcrypt" ,libgcrypt)
+       ("libsignal-protocol-c" ,libsignal-protocol-c)
        ("libsoup" ,libsoup)
        ("qrencode" ,qrencode)
-       ("sqlite" ,sqlite)
-       ("gpgme" ,gpgme)
-       ("gtk+" ,gtk+)
-       ("glib-networking" ,glib-networking)
-       ("gsettings-desktop-schemas" ,gsettings-desktop-schemas)))
+       ("sqlite" ,sqlite)))
     (synopsis "Mordern Jabber/XMPP Client using GTK+/Vala")
     (description "Dino is a modern chat client for the desktop.  It focuses on
 providing a clean and reliable Jabber/XMPP experience while having your privacy
-- 
2.29.2


[-- Attachment #1.1.5: 0004-gnu-dino-Add-some-inputs.patch --]
[-- Type: text/x-patch, Size: 1209 bytes --]

From 4c07e4fc6704eed0632ca11b12aa50f246a41b3d Mon Sep 17 00:00:00 2001
From: Raghav Gururajan <raghavgururajan@disroot.org>
Date: Sat, 21 Nov 2020 13:26:44 -0500
Subject: [PATCH 4/4] gnu: dino: Add some inputs.

* gnu/packages/messaging.scm (dino) [native-inputs]: Add gtk+:bin.
[inputs]: Add glib.

These inputs are referenced by the package, but were used indirectly
via propagation from other inputs. Now they are just directly added.
---
 gnu/packages/messaging.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
index 15848a9511..a04a078b52 100644
--- a/gnu/packages/messaging.scm
+++ b/gnu/packages/messaging.scm
@@ -958,10 +958,12 @@ Encryption to Gajim.")
     (native-inputs
      `(("gettext" ,gettext-minimal)
        ("glib" ,glib "bin")
+       ("gtk+:bin" ,gtk+ "bin")
        ("pkg-config" ,pkg-config)
        ("vala" ,vala)))
     (inputs
-     `(("glib-networking" ,glib-networking)
+     `(("glib" ,glib)
+       ("glib-networking" ,glib-networking)
        ("gpgme" ,gpgme)
        ("gsettings-desktop-schemas" ,gsettings-desktop-schemas)
        ("gtk+" ,gtk+)
-- 
2.29.2


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [bug#44781] Dino (v2)
  2020-11-21 18:40 [bug#44781] Dino Raghav Gururajan
@ 2020-11-22  1:08 ` Raghav Gururajan
  2020-11-22  1:18   ` Leo Famulari
  0 siblings, 1 reply; 3+ messages in thread
From: Raghav Gururajan @ 2020-11-22  1:08 UTC (permalink / raw)
  To: 44781


[-- Attachment #1.1.1: Type: text/plain, Size: 61 bytes --]

@Leo

Please find the revised patch-set.

Regards,
RG.

[-- Attachment #1.1.2: 0001-gnu-dino-Make-some-cosmetic-changes.patch --]
[-- Type: text/x-patch, Size: 2768 bytes --]

From 55aa0d8d546fe2b67651042461bb23145c3a1393 Mon Sep 17 00:00:00 2001
From: Raghav Gururajan <raghavgururajan@disroot.org>
Date: Sat, 21 Nov 2020 13:13:49 -0500
Subject: [PATCH 1/5] gnu: dino: Make some cosmetic changes.

* gnu/packages/messaging.scm (dino): Make some cosmetic changes.
---
 gnu/packages/messaging.scm | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
index 9a2034f253..b60922e809 100644
--- a/gnu/packages/messaging.scm
+++ b/gnu/packages/messaging.scm
@@ -932,19 +932,19 @@ Encryption to Gajim.")
   (package
     (name "dino")
     (version "0.2.0")
-    (outputs '("out" "debug"))
     (source
      (origin
        (method url-fetch)
-       (uri (string-append "https://github.com/dino/dino/releases/download/v"
-                           version "/dino-" version ".tar.gz"))
+       (uri
+        (string-append "https://github.com/dino/dino/releases/download/v"
+                       version "/dino-" version ".tar.gz"))
        (sha256
-        (base32
-         "0iigh7bkil6prf02dqcl6lmd89jxz685h8lqr3ni4x39zkcransn"))))
+        (base32 "0iigh7bkil6prf02dqcl6lmd89jxz685h8lqr3ni4x39zkcransn"))))
     (build-system cmake-build-system)
+    (outputs '("out" "debug"))
     (arguments
      `(#:tests? #f
-       #:parallel-build? #f ; not supported
+       #:parallel-build? #f             ; not supported
        #:modules ((guix build cmake-build-system)
                   ((guix build glib-or-gtk-build-system) #:prefix glib-or-gtk:)
                   (guix build utils))
@@ -955,6 +955,11 @@ Encryption to Gajim.")
        (modify-phases %standard-phases
          (add-after 'install 'glib-or-gtk-wrap
            (assoc-ref glib-or-gtk:%standard-phases 'glib-or-gtk-wrap)))))
+    (native-inputs
+     `(("pkg-config" ,pkg-config)
+       ("glib" ,glib "bin")
+       ("vala" ,vala)
+       ("gettext" ,gettext-minimal)))
     (inputs
      `(("libgee" ,libgee)
        ("libsignal-protocol-c" ,libsignal-protocol-c)
@@ -966,15 +971,10 @@ Encryption to Gajim.")
        ("gtk+" ,gtk+)
        ("glib-networking" ,glib-networking)
        ("gsettings-desktop-schemas" ,gsettings-desktop-schemas)))
-    (native-inputs
-     `(("pkg-config" ,pkg-config)
-       ("glib" ,glib "bin")
-       ("vala" ,vala)
-       ("gettext" ,gettext-minimal)))
-    (home-page "https://dino.im")
     (synopsis "Graphical Jabber (XMPP) client")
     (description "Dino is a Jabber (XMPP) client which aims to fit well into
 a graphical desktop environment like GNOME.")
+    (home-page "https://dino.im")
     (license license:gpl3+)))
 
 (define-public prosody
-- 
2.29.2


[-- Attachment #1.1.3: 0002-gnu-dino-Update-synopsis-and-description.patch --]
[-- Type: text/x-patch, Size: 1265 bytes --]

From dc388b2e22992ef6b5300913e477d9a917fcb7d1 Mon Sep 17 00:00:00 2001
From: Raghav Gururajan <raghavgururajan@disroot.org>
Date: Sat, 21 Nov 2020 13:17:52 -0500
Subject: [PATCH 2/5] gnu: dino: Update synopsis and description.

* gnu/packages/messaging.scm (dino) [synopsis]: Modify.
[description]: Modify.
---
 gnu/packages/messaging.scm | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
index b60922e809..9a7372c500 100644
--- a/gnu/packages/messaging.scm
+++ b/gnu/packages/messaging.scm
@@ -971,9 +971,10 @@ Encryption to Gajim.")
        ("gtk+" ,gtk+)
        ("glib-networking" ,glib-networking)
        ("gsettings-desktop-schemas" ,gsettings-desktop-schemas)))
-    (synopsis "Graphical Jabber (XMPP) client")
-    (description "Dino is a Jabber (XMPP) client which aims to fit well into
-a graphical desktop environment like GNOME.")
+    (synopsis "Jabber/XMPP Client using GTK+/Vala")
+    (description "Dino is a chat client for the desktop.  It focuses on providing
+a minimal yet reliable Jabber/XMPP experience and having encryption enabled by
+default.")
     (home-page "https://dino.im")
     (license license:gpl3+)))
 
-- 
2.29.2


[-- Attachment #1.1.4: 0003-gnu-dino-Re-arrange-inputs-in-alphabetical-order.patch --]
[-- Type: text/x-patch, Size: 1933 bytes --]

From 66a0b8895adce93856ca425fd14a4d4f3101c848 Mon Sep 17 00:00:00 2001
From: Raghav Gururajan <raghavgururajan@disroot.org>
Date: Sat, 21 Nov 2020 20:01:53 -0500
Subject: [PATCH 3/5] gnu: dino: Re-arrange inputs in alphabetical order.

* gnu/packages/messaging.scm (dino) [native-inputs]: Re-order.
[inputs]: Re-order.
---
 gnu/packages/messaging.scm | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
index 9a7372c500..f5151558b1 100644
--- a/gnu/packages/messaging.scm
+++ b/gnu/packages/messaging.scm
@@ -956,21 +956,21 @@ Encryption to Gajim.")
          (add-after 'install 'glib-or-gtk-wrap
            (assoc-ref glib-or-gtk:%standard-phases 'glib-or-gtk-wrap)))))
     (native-inputs
-     `(("pkg-config" ,pkg-config)
+     `(("gettext" ,gettext-minimal)
        ("glib" ,glib "bin")
-       ("vala" ,vala)
-       ("gettext" ,gettext-minimal)))
+       ("pkg-config" ,pkg-config)
+       ("vala" ,vala)))
     (inputs
-     `(("libgee" ,libgee)
-       ("libsignal-protocol-c" ,libsignal-protocol-c)
+     `(("glib-networking" ,glib-networking)
+       ("gpgme" ,gpgme)
+       ("gsettings-desktop-schemas" ,gsettings-desktop-schemas)
+       ("gtk+" ,gtk+)
        ("libgcrypt" ,libgcrypt)
+       ("libgee" ,libgee)
+       ("libsignal-protocol-c" ,libsignal-protocol-c)
        ("libsoup" ,libsoup)
        ("qrencode" ,qrencode)
-       ("sqlite" ,sqlite)
-       ("gpgme" ,gpgme)
-       ("gtk+" ,gtk+)
-       ("glib-networking" ,glib-networking)
-       ("gsettings-desktop-schemas" ,gsettings-desktop-schemas)))
+       ("sqlite" ,sqlite)))
     (synopsis "Jabber/XMPP Client using GTK+/Vala")
     (description "Dino is a chat client for the desktop.  It focuses on providing
 a minimal yet reliable Jabber/XMPP experience and having encryption enabled by
-- 
2.29.2


[-- Attachment #1.1.5: 0004-gnu-dino-Add-some-inputs.patch --]
[-- Type: text/x-patch, Size: 1067 bytes --]

From e6f23e6b44c2de48452b7615a1b04d75e8c3b260 Mon Sep 17 00:00:00 2001
From: Raghav Gururajan <raghavgururajan@disroot.org>
Date: Sat, 21 Nov 2020 20:04:06 -0500
Subject: [PATCH 4/5] gnu: dino: Add some inputs.

* gnu/packages/messaging.scm (dino) [native-inputs]: Add gtk+:bin.
[inputs]: Add glib.
---
 gnu/packages/messaging.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
index f5151558b1..cf83f8edf7 100644
--- a/gnu/packages/messaging.scm
+++ b/gnu/packages/messaging.scm
@@ -958,10 +958,12 @@ Encryption to Gajim.")
     (native-inputs
      `(("gettext" ,gettext-minimal)
        ("glib" ,glib "bin")
+       ("gtk+:bin" ,gtk+ "bin")
        ("pkg-config" ,pkg-config)
        ("vala" ,vala)))
     (inputs
-     `(("glib-networking" ,glib-networking)
+     `(("glib" ,glib)
+       ("glib-networking" ,glib-networking)
        ("gpgme" ,gpgme)
        ("gsettings-desktop-schemas" ,gsettings-desktop-schemas)
        ("gtk+" ,gtk+)
-- 
2.29.2


[-- Attachment #1.1.6: 0005-gnu-dino-Correct-glib-native-input-name.patch --]
[-- Type: text/x-patch, Size: 932 bytes --]

From b30740a072e88cf9c7bd9cf68e0b6310024cefc9 Mon Sep 17 00:00:00 2001
From: Raghav Gururajan <raghavgururajan@disroot.org>
Date: Sat, 21 Nov 2020 20:05:36 -0500
Subject: [PATCH 5/5] gnu: dino: Correct glib native-input name.

* gnu/packages/messaging.scm (dino) [native-inputs]: Rename glib to
glib:bin.
---
 gnu/packages/messaging.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
index cf83f8edf7..42e5688bef 100644
--- a/gnu/packages/messaging.scm
+++ b/gnu/packages/messaging.scm
@@ -957,7 +957,7 @@ Encryption to Gajim.")
            (assoc-ref glib-or-gtk:%standard-phases 'glib-or-gtk-wrap)))))
     (native-inputs
      `(("gettext" ,gettext-minimal)
-       ("glib" ,glib "bin")
+       ("glib:bin" ,glib "bin")
        ("gtk+:bin" ,gtk+ "bin")
        ("pkg-config" ,pkg-config)
        ("vala" ,vala)))
-- 
2.29.2


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [bug#44781] Dino (v2)
  2020-11-22  1:08 ` [bug#44781] Dino (v2) Raghav Gururajan
@ 2020-11-22  1:18   ` Leo Famulari
  0 siblings, 0 replies; 3+ messages in thread
From: Leo Famulari @ 2020-11-22  1:18 UTC (permalink / raw)
  To: Raghav Gururajan; +Cc: 44781

[-- Attachment #1: Type: text/plain, Size: 179 bytes --]

On Sat, Nov 21, 2020 at 08:08:29PM -0500, Raghav Gururajan wrote:
> @Leo
> 
> Please find the revised patch-set.

Thanks! Pushed as eeee65076e3199c778b177e06de3aae7696dbb9f

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-11-22  1:19 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-21 18:40 [bug#44781] Dino Raghav Gururajan
2020-11-22  1:08 ` [bug#44781] Dino (v2) Raghav Gururajan
2020-11-22  1:18   ` Leo Famulari

unofficial mirror of guix-patches@gnu.org 

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://yhetil.org/guix-patches/1 guix-patches/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 guix-patches guix-patches/ https://yhetil.org/guix-patches \
		guix-patches@gnu.org
	public-inbox-index guix-patches

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://news.yhetil.org/yhetil.gnu.guix.patches


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git