unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / Atom feed
* [bug#44771] [PATCH] gnu: Properly use $QTWEBENGINEPROCESS_PATH
@ 2020-11-20 21:19 Sergey Trofimov
  2020-11-21 10:11 ` Sergey Trofimov
  0 siblings, 1 reply; 3+ messages in thread
From: Sergey Trofimov @ 2020-11-20 21:19 UTC (permalink / raw)
  To: 44771

I've noticed that installing supercollider breaks qutebrowser. It happens
because QTWEBENGINEPROCESS_PATH is not a search path, but rather a full path
to a file.  So supercollider puts this var into the user profile and then
qutebrowser's wrapper incorrectly concatenates it with the path coming from
the qtwebengine dependency. Calibre package has the same defect.





^ permalink raw reply	[flat|nested] 3+ messages in thread

* [bug#44771] [PATCH] gnu: Properly use $QTWEBENGINEPROCESS_PATH
  2020-11-20 21:19 [bug#44771] [PATCH] gnu: Properly use $QTWEBENGINEPROCESS_PATH Sergey Trofimov
@ 2020-11-21 10:11 ` Sergey Trofimov
  2020-11-28 16:34   ` bug#44771: " Christopher Baines
  0 siblings, 1 reply; 3+ messages in thread
From: Sergey Trofimov @ 2020-11-21 10:11 UTC (permalink / raw)
  To: 44771; +Cc: Sergey Trofimov

---
 gnu/packages/ebook.scm        | 2 +-
 gnu/packages/web-browsers.scm | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/ebook.scm b/gnu/packages/ebook.scm
index 1609a631b7..e80ad45383 100644
--- a/gnu/packages/ebook.scm
+++ b/gnu/packages/ebook.scm
@@ -281,7 +281,7 @@
                   (lambda (binary)
                     (wrap-program binary
                       ;; Make QtWebEngineProcess available.
-                      `("QTWEBENGINEPROCESS_PATH" ":" =
+                      `("QTWEBENGINEPROCESS_PATH" =
                         ,(list (string-append
                                 qtwebengine
                                 "/lib/qt5/libexec/QtWebEngineProcess")))))
diff --git a/gnu/packages/web-browsers.scm b/gnu/packages/web-browsers.scm
index 51af66ef54..bf1d45e5cc 100644
--- a/gnu/packages/web-browsers.scm
+++ b/gnu/packages/web-browsers.scm
@@ -538,7 +538,7 @@ interface.")
                                       (assoc-ref inputs "qtwebengine")
                                       "/lib/qt5/libexec/QtWebEngineProcess")))
                (wrap-program bin
-                 `("QTWEBENGINEPROCESS_PATH" ":" prefix (,qt-process-path)))
+                 `("QTWEBENGINEPROCESS_PATH" = (,qt-process-path)))
                #t))))))
     (home-page "https://qutebrowser.org/")
     (synopsis "Minimal, keyboard-focused, vim-like web browser")
-- 
2.29.2





^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#44771: [PATCH] gnu: Properly use $QTWEBENGINEPROCESS_PATH
  2020-11-21 10:11 ` Sergey Trofimov
@ 2020-11-28 16:34   ` Christopher Baines
  0 siblings, 0 replies; 3+ messages in thread
From: Christopher Baines @ 2020-11-28 16:34 UTC (permalink / raw)
  To: Sergey Trofimov; +Cc: 44771-done

[-- Attachment #1: Type: text/plain, Size: 1649 bytes --]


Sergey Trofimov <sarg@sarg.org.ru> writes:

> ---
>  gnu/packages/ebook.scm        | 2 +-
>  gnu/packages/web-browsers.scm | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/ebook.scm b/gnu/packages/ebook.scm
> index 1609a631b7..e80ad45383 100644
> --- a/gnu/packages/ebook.scm
> +++ b/gnu/packages/ebook.scm
> @@ -281,7 +281,7 @@
>                    (lambda (binary)
>                      (wrap-program binary
>                        ;; Make QtWebEngineProcess available.
> -                      `("QTWEBENGINEPROCESS_PATH" ":" =
> +                      `("QTWEBENGINEPROCESS_PATH" =
>                          ,(list (string-append
>                                  qtwebengine
>                                  "/lib/qt5/libexec/QtWebEngineProcess")))))
> diff --git a/gnu/packages/web-browsers.scm b/gnu/packages/web-browsers.scm
> index 51af66ef54..bf1d45e5cc 100644
> --- a/gnu/packages/web-browsers.scm
> +++ b/gnu/packages/web-browsers.scm
> @@ -538,7 +538,7 @@ interface.")
>                                        (assoc-ref inputs "qtwebengine")
>                                        "/lib/qt5/libexec/QtWebEngineProcess")))
>                 (wrap-program bin
> -                 `("QTWEBENGINEPROCESS_PATH" ":" prefix (,qt-process-path)))
> +                 `("QTWEBENGINEPROCESS_PATH" = (,qt-process-path)))
>                 #t))))))
>      (home-page "https://qutebrowser.org/")
>      (synopsis "Minimal, keyboard-focused, vim-like web browser")

Thanks, I split this in to two commits, wrote commit messages and pushed
to master in f4d139d02f0b0404540b74f3249de050b519b880.

Chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-11-28 16:37 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-20 21:19 [bug#44771] [PATCH] gnu: Properly use $QTWEBENGINEPROCESS_PATH Sergey Trofimov
2020-11-21 10:11 ` Sergey Trofimov
2020-11-28 16:34   ` bug#44771: " Christopher Baines

unofficial mirror of guix-patches@gnu.org 

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://yhetil.org/guix-patches/1 guix-patches/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 guix-patches guix-patches/ https://yhetil.org/guix-patches \
		guix-patches@gnu.org
	public-inbox-index guix-patches

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://news.yhetil.org/yhetil.gnu.guix.patches


AGPL code for this site: git clone http://ou63pmih66umazou.onion/public-inbox.git