unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / Atom feed
* [bug#30500] [PATCH] services: cups: Add all extensions by default.
@ 2018-02-17 14:54 Danny Milosavljevic
  2018-02-26 17:57 ` Ludovic Courtès
  2020-11-17 23:07 ` zimoun
  0 siblings, 2 replies; 9+ messages in thread
From: Danny Milosavljevic @ 2018-02-17 14:54 UTC (permalink / raw)
  To: 30500

* gnu/services/cups.scm (cups-configuration): Add all extensions by default.
---
 gnu/services/cups.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/services/cups.scm b/gnu/services/cups.scm
index 4c62e6a6f..4e7325a74 100644
--- a/gnu/services/cups.scm
+++ b/gnu/services/cups.scm
@@ -465,7 +465,7 @@ programs."))
    (package cups)
    "The CUPS package.")
   (extensions
-   (package-list (list cups-filters))
+   (package-list (list cups-filters escpr hplip))
    "Drivers and other extensions to the CUPS package.")
   (files-configuration
    (files-configuration (files-configuration))

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [bug#30500] [PATCH] services: cups: Add all extensions by default.
  2018-02-17 14:54 [bug#30500] [PATCH] services: cups: Add all extensions by default Danny Milosavljevic
@ 2018-02-26 17:57 ` Ludovic Courtès
  2020-10-19 13:51   ` zimoun
  2020-11-17 23:07 ` zimoun
  1 sibling, 1 reply; 9+ messages in thread
From: Ludovic Courtès @ 2018-02-26 17:57 UTC (permalink / raw)
  To: Danny Milosavljevic; +Cc: 30500

Danny Milosavljevic <dannym@scratchpost.org> skribis:

> * gnu/services/cups.scm (cups-configuration): Add all extensions by default.
> ---
>  gnu/services/cups.scm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gnu/services/cups.scm b/gnu/services/cups.scm
> index 4c62e6a6f..4e7325a74 100644
> --- a/gnu/services/cups.scm
> +++ b/gnu/services/cups.scm
> @@ -465,7 +465,7 @@ programs."))
>     (package cups)
>     "The CUPS package.")
>    (extensions
> -   (package-list (list cups-filters))
> +   (package-list (list cups-filters escpr hplip))

Also ‘foomatic-filters’.

>     "Drivers and other extensions to the CUPS package.")
>    (files-configuration
>     (files-configuration (files-configuration))

I can definitely understand the usability argument.  The counter
argument would be this:

--8<---------------cut here---------------start------------->8---
$ guix size cups-filters | tail -1
total: 270.4 MiB
$ guix size cups-filters escpr hplip foomatic-filters | tail -1
total: 569.5 MiB
--8<---------------cut here---------------end--------------->8---

I think carrying all this could make ‘guix system reconfigure’
heavyweight for many—lots of unnecessary downloads/rebuilds, etc.

What do people think?

I suppose on Debian etc., one has to explicitly install the right
packages, no?

Ludo’.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [bug#30500] [PATCH] services: cups: Add all extensions by default.
  2018-02-26 17:57 ` Ludovic Courtès
@ 2020-10-19 13:51   ` zimoun
  2020-10-19 15:58     ` Tobias Geerinckx-Rice via Guix-patches via
  0 siblings, 1 reply; 9+ messages in thread
From: zimoun @ 2020-10-19 13:51 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: Danny Milosavljevic, 30500

Dear,

What is the status of the bug #30500 [1]?  It is tagged 'moreinfo' and
now a bit old.  It is about the addition of the two packages 'escpr' and
'hplip' to the service 'cups'.

1: <http://issues.guix.gnu.org/issue/30500>


On Mon, 26 Feb 2018 at 18:57, ludo@gnu.org (Ludovic Courtès) wrote:
> Danny Milosavljevic <dannym@scratchpost.org> skribis:
>
>> * gnu/services/cups.scm (cups-configuration): Add all extensions by default.
>> ---
>>  gnu/services/cups.scm | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/gnu/services/cups.scm b/gnu/services/cups.scm
>> index 4c62e6a6f..4e7325a74 100644
>> --- a/gnu/services/cups.scm
>> +++ b/gnu/services/cups.scm
>> @@ -465,7 +465,7 @@ programs."))
>>     (package cups)
>>     "The CUPS package.")
>>    (extensions
>> -   (package-list (list cups-filters))
>> +   (package-list (list cups-filters escpr hplip))
>
> Also ‘foomatic-filters’.
>
>>     "Drivers and other extensions to the CUPS package.")
>>    (files-configuration
>>     (files-configuration (files-configuration))
>
> I can definitely understand the usability argument.  The counter
> argument would be this:
>
> $ guix size cups-filters | tail -1
> total: 270.4 MiB
> $ guix size cups-filters escpr hplip foomatic-filters | tail -1
> total: 569.5 MiB
>
> I think carrying all this could make ‘guix system reconfigure’
> heavyweight for many—lots of unnecessary downloads/rebuilds, etc.

What people think?


All the best,
simon




^ permalink raw reply	[flat|nested] 9+ messages in thread

* [bug#30500] [PATCH] services: cups: Add all extensions by default.
  2020-10-19 13:51   ` zimoun
@ 2020-10-19 15:58     ` Tobias Geerinckx-Rice via Guix-patches via
  2020-10-28 17:24       ` zimoun
  0 siblings, 1 reply; 9+ messages in thread
From: Tobias Geerinckx-Rice via Guix-patches via @ 2020-10-19 15:58 UTC (permalink / raw)
  To: zimoun; +Cc: dannym, ludo, 30500

[-- Attachment #1: Type: text/plain, Size: 1279 bytes --]

zimoun 写道:
>> $ guix size cups-filters | tail -1
>> total: 270.4 MiB
>> $ guix size cups-filters escpr hplip foomatic-filters | tail -1
>> total: 569.5 MiB

It's since improved.  Probably thanks to hplip-minimal, whilst the 
newer Samsung SpliX package adds a mere 0.2 MiB:

  λ guix size cups | tail -n 1
  total: 279.5 MiB
  λ guix size cups-filters escpr hplip-minimal foomatic-filters 
  splix | tail -n 1
  total: 405.4 MiB (+45%)

>> I think carrying all this could make ‘guix system reconfigure’
>> heavyweight for many—lots of unnecessary downloads/rebuilds, 
>> etc.

‘Lots’ is way overblown.  This is it:

+/gnu/store/44xzcm69lmy71ydrnmv4plzxc26rk0dc-splix-2.0.0-315
+/gnu/store/amahw2r0b7fjqphisv8c0f6w77qac3c0-hplip-minimal-3.20.9
+/gnu/store/jqqf3xzs4sjdvnvddpk3pgx8g2rn9db3-foomatic-filters-4.0.17
+/gnu/store/w3rqls7rxri89xmi02yw8irycnf5zia1-escpr-1.7.7
+/gnu/store/9bfxyfqx12mnxwh715y23djnp239qh1b-libusb-1.0.23
+/gnu/store/57xj5gcy1jbl9ai2lnrqnpr0dald9i65-coreutils-8.32
+/gnu/store/8zvc5mvk0xm3ygrxsgpyy5ilxb5rzjry-perl-5.30.2

With the last 2 (3?) almost certainly already installed, this is 
not unreasonable for ‘cups-service-type actually prints, even if 
you visit grandma’.

Visit grandma,

T G-R

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [bug#30500] [PATCH] services: cups: Add all extensions by default.
  2020-10-19 15:58     ` Tobias Geerinckx-Rice via Guix-patches via
@ 2020-10-28 17:24       ` zimoun
  0 siblings, 0 replies; 9+ messages in thread
From: zimoun @ 2020-10-28 17:24 UTC (permalink / raw)
  To: Tobias Geerinckx-Rice; +Cc: dannym, ludo, 30500

Hi,

On Mon, 19 Oct 2020 at 17:58, Tobias Geerinckx-Rice <me@tobias.gr> wrote:

>  λ guix size cups | tail -n 1
>  total: 279.5 MiB
>  λ guix size cups-filters escpr hplip-minimal foomatic-filters   splix | tail
> -n 1
>  total: 405.4 MiB (+45%)
>
>>> I think carrying all this could make ‘guix system reconfigure’
>>> heavyweight for many—lots of unnecessary downloads/rebuilds, etc.
>
> ‘Lots’ is way overblown.  This is it:
>
> +/gnu/store/44xzcm69lmy71ydrnmv4plzxc26rk0dc-splix-2.0.0-315
> +/gnu/store/amahw2r0b7fjqphisv8c0f6w77qac3c0-hplip-minimal-3.20.9
> +/gnu/store/jqqf3xzs4sjdvnvddpk3pgx8g2rn9db3-foomatic-filters-4.0.17
> +/gnu/store/w3rqls7rxri89xmi02yw8irycnf5zia1-escpr-1.7.7
> +/gnu/store/9bfxyfqx12mnxwh715y23djnp239qh1b-libusb-1.0.23
> +/gnu/store/57xj5gcy1jbl9ai2lnrqnpr0dald9i65-coreutils-8.32
> +/gnu/store/8zvc5mvk0xm3ygrxsgpyy5ilxb5rzjry-perl-5.30.2
>
> With the last 2 (3?) almost certainly already installed, this is not
> unreasonable for ‘cups-service-type actually prints, even if you visit
> grandma’.

Grandma’ is lost, on one hand +45% and on the other hand not
unreasonable. :-)

Does it make sense to apply the patch?  From my point of view, yes.


Cheers,
simon




^ permalink raw reply	[flat|nested] 9+ messages in thread

* [bug#30500] [PATCH] services: cups: Add all extensions by default.
  2018-02-17 14:54 [bug#30500] [PATCH] services: cups: Add all extensions by default Danny Milosavljevic
  2018-02-26 17:57 ` Ludovic Courtès
@ 2020-11-17 23:07 ` zimoun
  2020-11-18  8:28   ` Efraim Flashner
  2020-11-18  9:00   ` bug#30500: " Danny Milosavljevic
  1 sibling, 2 replies; 9+ messages in thread
From: zimoun @ 2020-11-17 23:07 UTC (permalink / raw)
  To: Danny Milosavljevic; +Cc: 30500, Ludovic Courtès, Tobias Geerinckx-Rice

Hi,

Does it make sense to apply the patch and close this old bug?

From my point of view, yes for the two. ;-)


All the best,
simon

On Sat, 17 Feb 2018 at 15:54, Danny Milosavljevic <dannym@scratchpost.org> wrote:
> * gnu/services/cups.scm (cups-configuration): Add all extensions by default.
> ---
>  gnu/services/cups.scm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gnu/services/cups.scm b/gnu/services/cups.scm
> index 4c62e6a6f..4e7325a74 100644
> --- a/gnu/services/cups.scm
> +++ b/gnu/services/cups.scm
> @@ -465,7 +465,7 @@ programs."))
>     (package cups)
>     "The CUPS package.")
>    (extensions
> -   (package-list (list cups-filters))
> +   (package-list (list cups-filters escpr hplip))
>     "Drivers and other extensions to the CUPS package.")
>    (files-configuration
>     (files-configuration (files-configuration))




^ permalink raw reply	[flat|nested] 9+ messages in thread

* [bug#30500] [PATCH] services: cups: Add all extensions by default.
  2020-11-17 23:07 ` zimoun
@ 2020-11-18  8:28   ` Efraim Flashner
  2020-11-18  8:48     ` zimoun
  2020-11-18  9:00   ` bug#30500: " Danny Milosavljevic
  1 sibling, 1 reply; 9+ messages in thread
From: Efraim Flashner @ 2020-11-18  8:28 UTC (permalink / raw)
  To: zimoun
  Cc: Danny Milosavljevic, Ludovic Courtès, Tobias Geerinckx-Rice, 30500

[-- Attachment #1: Type: text/plain, Size: 1551 bytes --]

On Wed, Nov 18, 2020 at 12:07:47AM +0100, zimoun wrote:
> Hi,
> 
> Does it make sense to apply the patch and close this old bug?
> 
> From my point of view, yes for the two. ;-)
> 

I no longer have the original bug report in my main mail folder, that's
how old it is :). Lets add a couple more, printing sucks a lot as it
already is. I don't think it's any worse than, say, adding
glibc-locales@2.29 by default. Just make sure the documentation is
updated accordingly.

I vote yes

> 
> All the best,
> simon
> 
> On Sat, 17 Feb 2018 at 15:54, Danny Milosavljevic <dannym@scratchpost.org> wrote:
> > * gnu/services/cups.scm (cups-configuration): Add all extensions by default.
> > ---
> >  gnu/services/cups.scm | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/gnu/services/cups.scm b/gnu/services/cups.scm
> > index 4c62e6a6f..4e7325a74 100644
> > --- a/gnu/services/cups.scm
> > +++ b/gnu/services/cups.scm
> > @@ -465,7 +465,7 @@ programs."))
> >     (package cups)
> >     "The CUPS package.")
> >    (extensions
> > -   (package-list (list cups-filters))
> > +   (package-list (list cups-filters escpr hplip))
> >     "Drivers and other extensions to the CUPS package.")
> >    (files-configuration
> >     (files-configuration (files-configuration))
> 
> 
> 

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [bug#30500] [PATCH] services: cups: Add all extensions by default.
  2020-11-18  8:28   ` Efraim Flashner
@ 2020-11-18  8:48     ` zimoun
  0 siblings, 0 replies; 9+ messages in thread
From: zimoun @ 2020-11-18  8:48 UTC (permalink / raw)
  To: Efraim Flashner
  Cc: Danny Milosavljevic, Ludovic Courtès, Tobias Geerinckx-Rice, 30500

Hi,

On Wed, 18 Nov 2020 at 10:28, Efraim Flashner <efraim@flashner.co.il> wrote:

> I no longer have the original bug report in my main mail folder, that's
> how old it is :). Lets add a couple more, printing sucks a lot as it
> already is. I don't think it's any worse than, say, adding
> glibc-locales@2.29 by default. Just make sure the documentation is
> updated accordingly.
>
> I vote yes

I could rebase the patch and add documentation.  But I am not using
printing or services (foreign distro) so I would be able to test it.

Please beat me at this. :-)


Cheers,
simon




^ permalink raw reply	[flat|nested] 9+ messages in thread

* bug#30500: [PATCH] services: cups: Add all extensions by default.
  2020-11-17 23:07 ` zimoun
  2020-11-18  8:28   ` Efraim Flashner
@ 2020-11-18  9:00   ` Danny Milosavljevic
  1 sibling, 0 replies; 9+ messages in thread
From: Danny Milosavljevic @ 2020-11-18  9:00 UTC (permalink / raw)
  To: zimoun; +Cc: Tobias Geerinckx-Rice, Ludovic Courtès, 30500-done

[-- Attachment #1: Type: text/plain, Size: 120 bytes --]

Pushed a T G-R variant of this cups-services patch to guix master as
commit 8490fa0253fa8ee5613a89851273e007494ea79b.

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2020-11-18  9:13 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-17 14:54 [bug#30500] [PATCH] services: cups: Add all extensions by default Danny Milosavljevic
2018-02-26 17:57 ` Ludovic Courtès
2020-10-19 13:51   ` zimoun
2020-10-19 15:58     ` Tobias Geerinckx-Rice via Guix-patches via
2020-10-28 17:24       ` zimoun
2020-11-17 23:07 ` zimoun
2020-11-18  8:28   ` Efraim Flashner
2020-11-18  8:48     ` zimoun
2020-11-18  9:00   ` bug#30500: " Danny Milosavljevic

unofficial mirror of guix-patches@gnu.org 

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://yhetil.org/guix-patches/1 guix-patches/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 guix-patches guix-patches/ https://yhetil.org/guix-patches \
		guix-patches@gnu.org
	public-inbox-index guix-patches

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://news.yhetil.org/yhetil.gnu.guix.patches


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git