unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Efraim Flashner <efraim@flashner.co.il>
To: Leo Prikler <leo.prikler@student.tugraz.at>
Cc: 44640@debbugs.gnu.org
Subject: [bug#44640] [PATCH 2/3] gnu: Add python-globber.
Date: Tue, 17 Nov 2020 12:48:14 +0200	[thread overview]
Message-ID: <20201117104814.GU987@E5400> (raw)
In-Reply-To: <20201114170047.949-2-leo.prikler@student.tugraz.at>

[-- Attachment #1: Type: text/plain, Size: 2156 bytes --]

Not a full review (currently building other packages...)

On Sat, Nov 14, 2020 at 06:00:47PM +0100, Leo Prikler wrote:
> * gnu/packages/python-xyz.scm (python-globber): New variable.
> ---
>  gnu/packages/python-xyz.scm | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
> 
> diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
> index 57371f05c7..7b9ab21671 100644
> --- a/gnu/packages/python-xyz.scm
> +++ b/gnu/packages/python-xyz.scm
> @@ -18271,6 +18271,31 @@ Features include, but are not limited to:
>  @end itemize")
>      (license license:expat)))
>  
> +(define-public python-globber
> +  (package
> +    (name "python-globber")
> +    (version "0.2.1")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (pypi-uri "globber" version))
> +       (sha256
> +        (base32
> +         "0w7gaqpfc9j9l6hgm0cl7hrlf3lr0w7ifns035cksa1r16mhlwlr"))))
> +    (build-system python-build-system)
> +    (arguments
> +     `(#:tests? #f)) ; missing from distribution

Can we build from a git checkout then? It's better to have the tests and
run them.

> +    (home-page "https://github.com/asharov/globber")
> +    (synopsis
> +     "Library for string matching with glob patterns")

Can you put this on the previous line? It triggers something inside me
to have it on its own line when it's not approaching 80 characters :/

> +    (description
> +     "Globber is a Python library for matching file names against glob patterns.
> +In contrast to other glob-matching libraries, it matches arbitrary strings and
> +doesn't require the matched names to be existing files.  In addition, it
> +supports the globstar @code{**} operator to match an arbitrary number of
> +path components.")
> +    (license license:asl2.0)))
> +
>  (define-public python-fusepy
>    (package
>      (name "python-fusepy")
> -- 
> 2.29.2
> 
> 
> 
> 

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2020-11-17 10:49 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-14 16:56 [bug#44640] [PATCH 0/3] Add python-git-hammer Leo Prikler
2020-11-14 17:00 ` [bug#44640] [PATCH 1/3] gnu: Add python-beautifultable Leo Prikler
2020-11-14 17:00   ` [bug#44640] [PATCH 2/3] gnu: Add python-globber Leo Prikler
2020-11-17 10:48     ` Efraim Flashner [this message]
2020-11-14 17:00   ` [bug#44640] [PATCH 3/3] gnu: Add python-git-hammer Leo Prikler
2020-11-17 10:50     ` Efraim Flashner
2020-11-17 11:01       ` Leo Prikler
2020-11-17 12:36         ` Leo Prikler
2020-11-18  8:40           ` bug#44640: " Efraim Flashner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201117104814.GU987@E5400 \
    --to=efraim@flashner.co.il \
    --cc=44640@debbugs.gnu.org \
    --cc=leo.prikler@student.tugraz.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).