From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id iAqBCux3sV+dHAAA0tVLHw (envelope-from ) for ; Sun, 15 Nov 2020 18:48:12 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id WGNNBux3sV+kaAAAbx9fmQ (envelope-from ) for ; Sun, 15 Nov 2020 18:48:12 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0DD889403CA for ; Sun, 15 Nov 2020 18:48:11 +0000 (UTC) Received: from localhost ([::1]:43792 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1keN4L-0007ED-4P for larch@yhetil.org; Sun, 15 Nov 2020 13:48:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:43198) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1keN4E-0007E5-MM for guix-patches@gnu.org; Sun, 15 Nov 2020 13:48:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:42624) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1keN4E-0004Oq-DN for guix-patches@gnu.org; Sun, 15 Nov 2020 13:48:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1keN4E-0002EE-AP for guix-patches@gnu.org; Sun, 15 Nov 2020 13:48:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#44663] [PATCH] ui: Launch $PAGER through the shell. Resent-From: Tobias Geerinckx-Rice Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 15 Nov 2020 18:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 44663 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 44663@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16054660818555 (code B ref -1); Sun, 15 Nov 2020 18:48:02 +0000 Received: (at submit) by debbugs.gnu.org; 15 Nov 2020 18:48:01 +0000 Received: from localhost ([127.0.0.1]:54170 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1keN4C-0002Du-PA for submit@debbugs.gnu.org; Sun, 15 Nov 2020 13:48:01 -0500 Received: from lists.gnu.org ([209.51.188.17]:60792) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1keN4B-0002Dn-L7 for submit@debbugs.gnu.org; Sun, 15 Nov 2020 13:48:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:43196) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1keN4B-0007Ci-3A for guix-patches@gnu.org; Sun, 15 Nov 2020 13:47:59 -0500 Received: from tobias.gr ([2a02:c205:2020:6054::1]:50574) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1keN49-0004Lj-1f for guix-patches@gnu.org; Sun, 15 Nov 2020 13:47:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tobias.gr; s=2018; bh=YUddEm8O4bylBw5ksrbUUacby2UF4HbvGP148ggcGzw=; h=date:subject:to: from; b=E2jvIAN8n8JHo+1RF6w0Flw6sPcZRC8KiTxsGBxCTIXntLiSmoUaTsYIPtiu/0 YTHKCbSAWzJIiEx1LRDBvp7PmQFTKjfAlkG0A4hsQ46jMhw3bFd1c9w01OjSMGzOx7vcW7 0GZycXstlPmsDJSK7EKdTeX1a3uneQqy0rHiqqQjCOXBMy5+qeVbpf2Wocsv/ujuaGUYPX YxZWf3UUrK8sijbj1oikj6GBkPKD6pmL3qKq38seUkrVg2+LsYFGu8LVYut1hFPpOGoc+k zO/ntunz2tnahxElbXhrZFHRQCo6urMZb2oPtX1+O0lfaHiXpjBiUgz40g0hAUkvkllN0A == Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 1a1e3318 (TLSv1.2:ECDHE-ECDSA-AES256-GCM-SHA384:256:NO) for ; Sun, 15 Nov 2020 18:47:57 +0000 (UTC) Date: Sun, 15 Nov 2020 19:47:26 +0100 Message-Id: <20201115184726.29944-1-me@tobias.gr> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a02:c205:2020:6054::1; envelope-from=me@tobias.gr; helo=tobias.gr X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -2.4 (--) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: Tobias Geerinckx-Rice , Tobias Geerinckx-Rice via Guix-patches From: Tobias Geerinckx-Rice via Guix-patches via X-Scanner: ns3122888.ip-94-23-21.eu Authentication-Results: aspmx1.migadu.com; dkim=fail (headers rsa verify failed) header.d=tobias.gr header.s=2018 header.b=E2jvIAN8; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: 3.49 X-TUID: 9Py+OWGBszcO This is the convention elsewhere and sounds like the right thing to do. * guix/ui.scm (call-with-paginated-output-port): Substitute OPEN-PIPE for OPEN-PIPE*. Reported by Daniel Brooks . --- guix/ui.scm | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/guix/ui.scm b/guix/ui.scm index 4e686297e8..2b7d9dd64b 100644 --- a/guix/ui.scm +++ b/guix/ui.scm @@ -72,7 +72,7 @@ #:use-module (ice-9 match) #:use-module (ice-9 format) #:use-module (ice-9 regex) - #:autoload (ice-9 popen) (open-pipe* close-pipe) + #:autoload (ice-9 popen) (open-pipe close-pipe) #:autoload (system base compile) (compile-file) #:autoload (system repl repl) (start-repl) #:autoload (system repl debug) (make-debug stack->vector) @@ -1673,9 +1673,9 @@ zero means that PACKAGE does not match any of REGEXPS." ;; instead of 'r': this strips hyperlinks but allows 'less' to make a ;; good estimate of the line length. (let ((pager (with-environment-variables `(("LESS" ,less-options)) - (open-pipe* OPEN_WRITE - (or (getenv "GUIX_PAGER") (getenv "PAGER") - "less"))))) + (open-pipe (or (getenv "GUIX_PAGER") (getenv "PAGER") + "less") + OPEN_WRITE)))) (dynamic-wind (const #t) (lambda () (proc pager)) -- 2.29.2