From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id iA+OIHwHo18MWQAA0tVLHw (envelope-from ) for ; Wed, 04 Nov 2020 19:56:44 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id qH9NHHwHo18tGwAA1q6Kng (envelope-from ) for ; Wed, 04 Nov 2020 19:56:44 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id AE370940111 for ; Wed, 4 Nov 2020 19:56:43 +0000 (UTC) Received: from localhost ([::1]:51418 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kaOte-0002wu-4n for larch@yhetil.org; Wed, 04 Nov 2020 14:56:42 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38746) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kaOt1-0002qF-5c for guix-patches@gnu.org; Wed, 04 Nov 2020 14:56:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:39117) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kaOt0-00039Y-Qt for guix-patches@gnu.org; Wed, 04 Nov 2020 14:56:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kaOt0-0005hj-Q3 for guix-patches@gnu.org; Wed, 04 Nov 2020 14:56:02 -0500 Subject: bug#44436: [PATCH] Add Cantata Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Wed, 04 Nov 2020 19:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 44436 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Simon Streit Cc: 44436-done@debbugs.gnu.org Mail-Followup-To: 44436@debbugs.gnu.org, leo@famulari.name, lists@netpanic.org Received: via spool by 44436-done@debbugs.gnu.org id=D44436.160451972621846 (code D ref 44436); Wed, 04 Nov 2020 19:56:02 +0000 Received: (at 44436-done) by debbugs.gnu.org; 4 Nov 2020 19:55:26 +0000 Received: from localhost ([127.0.0.1]:50656 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kaOsQ-0005gI-HR for submit@debbugs.gnu.org; Wed, 04 Nov 2020 14:55:26 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:60355) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kaOsN-0005g5-TH for 44436-done@debbugs.gnu.org; Wed, 04 Nov 2020 14:55:25 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id A3FCE5C01A8; Wed, 4 Nov 2020 14:55:18 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Wed, 04 Nov 2020 14:55:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-transfer-encoding:in-reply-to; s=mesmtp; bh=2l+0nV9TokSOuXqlbcUNEa1+dKuLTCq1vwXhWkIPAHw=; b=IINxgVUXJ/im 2wrASOo5a96WF4AJKNGKoQFoK38mY4HaH/ZA3sC3maXr4gVgpCGj+MMzzJXqUVTg nj9gNj3TVQWq7gOR+bQZZdaKSzEadFvlOzcGwjxH5eLdxtR/jJDuMwc9AU7aU/Em bepSM4GGxP5RwawbZsPSFFJJibBK+bQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=2l+0nV9TokSOuXqlbcUNEa1+dKuLTCq1vwXhWkIPA Hw=; b=XsCdczXPHoA7oxSQiHHW+1vafq1SSzSfHLWmZ90ZuqiLY6JNhfFJWs9cG ShpvWJLHRiZRWPoFFnjM8U3KMhqHeoR4GGgaC56CZLxhj5PNP4vFF+29lgmCL0jL vAYmCTuMn1vuw3HHPiIXWFcFdA9VmsKCwlpHGO8GxkMe4lQAfa2awwRQZH4Z3fjf bniDIXCSIZQ0hBivQvbTcPby0anHLSVeXsjF+xbWXDhvaObvDUIqEfuqBkETj5nr YfuzLc5/NVzLgksjopDGDwqf0siyIjvK49iiZkWMobcSGjwwOFKBm2BzKFX0J2fA eHsJu3EPLYYFUPPtMYd0wOYMWWwNA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedruddthedgudefvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhepfffhvffukfhfgggtugfgjgesth ekredttddtjeenucfhrhhomhepnfgvohcuhfgrmhhulhgrrhhiuceolhgvohesfhgrmhhu lhgrrhhirdhnrghmvgeqnecuggftrfgrthhtvghrnhepgeejgeeghedtudfgffdutddvff efffejkeffffevffehgedvvdeutdffkeejjeejnecukfhppeejfedrudeguddruddvjedr udegieenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hlvghosehfrghmuhhlrghrihdrnhgrmhgv X-ME-Proxy: Received: from localhost (c-73-141-127-146.hsd1.pa.comcast.net [73.141.127.146]) by mail.messagingengine.com (Postfix) with ESMTPA id 20CB73064610; Wed, 4 Nov 2020 14:55:18 -0500 (EST) Date: Wed, 4 Nov 2020 14:55:16 -0500 From: Leo Famulari Message-ID: <20201104195516.GA15076@jasmine.lan> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.7 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: ns3122888.ip-94-23-21.eu Authentication-Results: aspmx1.migadu.com; dkim=fail (headers rsa verify failed) header.d=famulari.name header.s=mesmtp header.b=IINxgVUX; dkim=fail (headers rsa verify failed) header.d=messagingengine.com header.s=fm1 header.b=XsCdczXP; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -0.01 X-TUID: B/aVYO1Z/h/Z On Wed, Nov 04, 2020 at 11:24:01AM +0100, Simon Streit wrote: > +(define-public cantata Thanks! I use MPD every day so I'm always glad to have another client available. Pushed as 79e9168aa6ebe3eee83e852ba96f46dda8ec0490 with the changes described below... First, I tried building it, but that failed for two reasons: > + (build-system cmake-build-system) The build system was not available — I needed to add '#:use-module (guix build-system cmake)' to mpd.scm's module imports. > + (license gpl3+))) The license needs to be "prefixed" like the other licenses in this file. That is: '(license license:gpl3+)'. If you look in mpd.scm's module imports, you'll see that we import the license module with a "prefix": #:use-module ((guix licenses) #:prefix license:) This is to work around the fact there are both packages and licenses named 'zlib' and 'expat', and the namespaces would otherwise collide when importing the license module and either of those packages. After that, I looked more closely at the inputs and native-inputs. In general, native-inputs are things that are used *only* while building the package. There were some unused inputs, and some were miscategorized. I fixed that by 1) reading the output of CMake's 'configure' phase, 2) intuition and 3) checking which inputs the built Cantata refers to: ------ $ guix gc --references $(./pre-inst-env guix build cantata) /gnu/store/01b4w3m6mp55y531kyi1g8shh722kwqm-gcc-7.5.0-lib /gnu/store/3bp88g40ay0zca3azdk7wf4nyrwrdjjx-qtsvg-5.14.2 /gnu/store/9z2412yyy95bcq7brfhdjlh8im2lxkpc-ffmpeg-4.3.1 /gnu/store/af00wnjldgbbyzb17bjkkw2mn0b1gr4d-qtbase-5.14.2 /gnu/store/b12szz8wy7wxvfv2jfj5ygqkgqar03ih-taglib-1.12-beta-1 /gnu/store/fa6wj5bxkj5ll1d7292a70knmyl7a0cr-glibc-2.31 /gnu/store/gklxpq6zmalxspwvj9md140skfpayrah-libmtp-1.1.18 /gnu/store/irsg92y6hnz1agsqvl6mwqxz32lkmi8v-cantata-2.4.2 /gnu/store/n1azzzjsq99n05r5xl0hcljvpvw5arxn-qtmultimedia-5.14.2 /gnu/store/ngv0dqjz88cn5553ys8w19ydwc55lvky-mpg123-1.26.3 /gnu/store/pwcp239kjf7lnj5i4lkdzcfcxwcfyk72-bash-minimal-5.0.16 /gnu/store/rykm237xkmq7rl1p0nwass01p090p88x-zlib-1.2.11 /gnu/store/v52179lrpvl6cdqr7li45zd8zafc6156-libebur128-1.2.4 /gnu/store/z1ngxz9rc1vqpbwvvlm8l37fa0q6ga5x-eudev-3.2.9 ------ Anything not listed there is either used only while building, not used at all, or the relevant software is copied into Cantata. Note that libcdio-paranoia is not listed — it is registered by the CMake configure phase, so either something is broken in the build scripts or it has been copied into Cantata. I left it in, just in case it works... somebody with an optical drive will find out. Also, libmusicbrainz is not listed. If libcdio-paranoia is not included, CMake doesn't complain about the missing libmusicbrainz. No matter what, CMake fails to find libmusicbrainz, so I removed it from Cantata's inputs. It's not unusual for older CMake projects that are no longer being actively developed to have this kind of inconsistency with their build scripts. Follow-up patches that address this are quite welcome! Are you able to test those features? Finally, I made some stylistic or grammatical changes to the synopsis, description, and source URI, added a comment about why we skip the tests, and pushed. Thanks again!