unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: Tanguy Le Carrour <tanguy@bioneland.org>
Cc: 44275-done@debbugs.gnu.org
Subject: bug#44275: [PATCH v2] gnu: Add python-pydub.
Date: Fri, 30 Oct 2020 16:40:47 -0400	[thread overview]
Message-ID: <20201030204047.GA10794@jasmine.lan> (raw)
In-Reply-To: <20201029090929.10508-1-tanguy@bioneland.org>

[-- Attachment #1: Type: text/plain, Size: 1376 bytes --]

On Thu, Oct 29, 2020 at 10:09:29AM +0100, Tanguy Le Carrour wrote:
> * gnu/packages/python-xyz.scm (python-pydub): New variable.

Thanks! Pushed as 96767739a1d2222ed802dd5dcfa2bda1df85df77

> +         (add-after 'unpack 'fix-ffmpeg-path
> +           (lambda* (#:key inputs #:allow-other-keys)
> +             (let ((ffmpeg (assoc-ref inputs "ffmpeg")))
> +               (substitute* '("pydub/utils.py")
> +                 (("return \"ffmpeg\"")
> +                  (string-append "return \"" ffmpeg "/bin/ffmpeg\""))
> +                 (("return \"ffplay\"")
> +                  (string-append "return \"" ffmpeg "/bin/ffplay\""))
> +                 (("return \"ffprobe\"")
> +                  (string-append "return \"" ffmpeg "/bin/ffprobe\""))
> +                 (("warn\\(\"Couldn't find ff") "# warn\\(\"Couldn't find ff"))
> +               #t))))))

This solution is more correct than the one I suggested. Thanks!

> +    (home-page "http://pydub.com")

I made this use HTTPS.

> +    (synopsis "Manipulate audio with an simple and easy high level interface")
> +    (description
> +     "@code{pydub} makes it easy to manipulate audio.  It relies on
> +@code{ffmpeg} to open various audio formats.")

And I tweaked these to avoid so-called "marketing language" and to
clarify that pydub is in Python, which I think can be useful when
searching for packages.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2020-10-30 20:41 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-28  8:56 [bug#44275] [PATCH] gnu: Add python-pydub Tanguy Le Carrour
2020-10-28 16:34 ` Leo Famulari
2020-10-29  8:26   ` Tanguy Le Carrour
2020-10-29 14:14     ` Leo Famulari
2020-10-29 14:39       ` Tanguy Le Carrour
2020-10-29 21:50       ` Leo Famulari
2020-10-30  9:19         ` Tanguy Le Carrour
2020-10-30 20:42           ` Leo Famulari
2020-10-29  9:09 ` [bug#44275] [PATCH v2] " Tanguy Le Carrour
2020-10-30 20:40   ` Leo Famulari [this message]
2020-10-30 21:10     ` Tanguy LE CARROUR

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201030204047.GA10794@jasmine.lan \
    --to=leo@famulari.name \
    --cc=44275-done@debbugs.gnu.org \
    --cc=tanguy@bioneland.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).