unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Tanguy Le Carrour <tanguy@bioneland.org>
To: Leo Famulari <leo@famulari.name>
Cc: 44276@debbugs.gnu.org
Subject: [bug#44276] [PATCH] gnu: Add python-simpleaudio.
Date: Thu, 29 Oct 2020 09:30:51 +0100	[thread overview]
Message-ID: <20201029083051.o7o6agdoqraoq2ya@rafflesia> (raw)
In-Reply-To: <20201028164357.GA13269@jasmine.lan>

Hi Leo,


Le 10/28, Leo Famulari a écrit :
> On Wed, Oct 28, 2020 at 10:08:10AM +0100, Tanguy Le Carrour wrote:
> > * gnu/packages/python-xyz.scm (python-simpleaudio): New variable.
> 
> > +    (native-inputs
> > +      `(("alsa-lib" ,alsa-lib)))
> 
> After taking a closer look at the inputs in the pydub package, I noticed
> that alsa-lib is a native-input; native-inputs are typically used only
> while building the package.
> 
> The built package keeps a reference to alsa-lib:
> 
> ------
> $ guix gc --references $(./pre-inst-env guix build --no-grafts python-simpleaudio) | grep alsa-lib
> /gnu/store/zcjdb23gbhl0pcnvvm8rnlprkfl43cv5-alsa-lib-1.2.2
> $ grep -r alsa-lib $(./pre-inst-env guix build --no-grafts python-simpleaudio)         
> Binary file /gnu/store/kaiww0wf6a7kqzrn9la681lmwmp2k26w-python-simpleaudio-1.0.4/lib/python3.8/site-packages/simpleaudio/_simpleaudio.cpython-38-x86_64-linux-gnu.so matches
> ------
> 
> Either the reference is used and should not be the "native alsa-lib" (in
> terms of cross-compiling), or it's not used and we can remove the
> reference after building. I think the first option is more likely.
> Should I change it from a 'native-input' to an 'input'?

Way out of my comfort zone! ^_^'
Even if I think I get your point! `alsa-lib` is indeed used at run time.
So… do as you think is best! :-)

Thank again for your time and advice.

-- 
Tanguy




  reply	other threads:[~2020-10-29  8:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-28  9:08 [bug#44276] [PATCH] gnu: Add python-simpleaudio Tanguy Le Carrour
2020-10-28 16:32 ` Leo Famulari
2020-10-28 16:43 ` Leo Famulari
2020-10-29  8:30   ` Tanguy Le Carrour [this message]
2020-10-29 14:14     ` bug#44276: " Leo Famulari
2020-10-29 14:26       ` [bug#44276] " Tanguy Le Carrour

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201029083051.o7o6agdoqraoq2ya@rafflesia \
    --to=tanguy@bioneland.org \
    --cc=44276@debbugs.gnu.org \
    --cc=leo@famulari.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).