From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id EHVRGsECj19SSwAA0tVLHw (envelope-from ) for ; Tue, 20 Oct 2020 15:31:13 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id wCUsFsECj18icwAAbx9fmQ (envelope-from ) for ; Tue, 20 Oct 2020 15:31:13 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 08B889403EC for ; Tue, 20 Oct 2020 15:31:13 +0000 (UTC) Received: from localhost ([::1]:38964 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kUtbT-0000iZ-St for larch@yhetil.org; Tue, 20 Oct 2020 11:31:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59076) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kUtbK-0000hP-RP for guix-patches@gnu.org; Tue, 20 Oct 2020 11:31:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:34871) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kUtbK-0000PQ-GE for guix-patches@gnu.org; Tue, 20 Oct 2020 11:31:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kUtbK-0002le-Dc for guix-patches@gnu.org; Tue, 20 Oct 2020 11:31:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#44077] [PATCH 1/2] gnu: Add python-poetry-core. Resent-From: Tanguy Le Carrour Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 20 Oct 2020 15:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44077 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Nicolas Goaziou Cc: 44077@debbugs.gnu.org Received: via spool by 44077-submit@debbugs.gnu.org id=B44077.160320784610596 (code B ref 44077); Tue, 20 Oct 2020 15:31:02 +0000 Received: (at 44077) by debbugs.gnu.org; 20 Oct 2020 15:30:46 +0000 Received: from localhost ([127.0.0.1]:46408 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUtb4-0002kq-9K for submit@debbugs.gnu.org; Tue, 20 Oct 2020 11:30:46 -0400 Received: from relay11.mail.gandi.net ([217.70.178.231]:57521) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUtb1-0002kV-U3 for 44077@debbugs.gnu.org; Tue, 20 Oct 2020 11:30:44 -0400 Received: from localhost (176-159-32-89.abo.bbox.fr [176.159.32.89]) (Authenticated sender: tanguy@bioneland.org) by relay11.mail.gandi.net (Postfix) with ESMTPSA id 182F0100006; Tue, 20 Oct 2020 15:30:36 +0000 (UTC) Date: Tue, 20 Oct 2020 17:30:36 +0200 From: Tanguy Le Carrour Message-ID: <20201020153036.bwradn2fitkmfgfy@rafflesia> References: <20201019132649.13548-1-tanguy@bioneland.org> <20201019132912.13941-1-tanguy@bioneland.org> <87zh4h6roz.fsf@nicolasgoaziou.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87zh4h6roz.fsf@nicolasgoaziou.fr> X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.7 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -0.51 X-TUID: SWilc+kUerup Hi, Le 10/20, Nicolas Goaziou a écrit : > Tanguy Le Carrour writes: > > +(define-public python-poetry-core > > + (package > > + (name "python-poetry-core") > > + (version "1.0.0") > > + (source > > + (origin > > + (method url-fetch) > > + (uri (pypi-uri "poetry-core" version)) > > + (sha256 > > + (base32 > > + "1mgv276h1iphn5fqhp2sgkgd5d0c39hs33vgaf157x5ri7rlyrka")))) > > Nitpick: move the string on the same line as `base32'. I have no clue what the rule is, but… most (but not all!?) packages in `gnu/packages/python-xyz.scm` have the string on a new line. I'll leave it on a new line if it's OK with you. > > + (build-system python-build-system) > > + (home-page "https://github.com/python-poetry/poetry-core") > > + (synopsis "Poetry PEP 517 Build Backend") > > Nitpick: I would avoid unnecessary capitalization: > Poetry PEP 517 build back-end Done! > > + (description > > + "A PEP 517 build backend implementation developed for Poetry. This project > > +is intended to be a light weight, fully compliant, self-contained package allowing > > +PEP 517 compatible build frontends to build Poetry managed projects.") > > The first sentence should be complete, i.e., with a subject and a verb. My bad! Updated! Thanks again for your time! -- Tanguy