From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id MPJwF1DEhl+nXwAA0tVLHw (envelope-from ) for ; Wed, 14 Oct 2020 09:26:40 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id oF9RE1DEhl8YOQAAbx9fmQ (envelope-from ) for ; Wed, 14 Oct 2020 09:26:40 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 420C39408EE for ; Wed, 14 Oct 2020 09:26:38 +0000 (UTC) Received: from localhost ([::1]:60466 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kSd3M-0006yJ-Bi for larch@yhetil.org; Wed, 14 Oct 2020 05:26:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46976) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kSd2o-0006xj-Dh for guix-patches@gnu.org; Wed, 14 Oct 2020 05:26:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:38533) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kSd2o-0007M6-3Z for guix-patches@gnu.org; Wed, 14 Oct 2020 05:26:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kSd2o-0000wE-0t for guix-patches@gnu.org; Wed, 14 Oct 2020 05:26:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#43881] [PATCH 2/2] install: Deduplicate packages with %base-package sets. Resent-From: Efraim Flashner Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 14 Oct 2020 09:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43881 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 43881@debbugs.gnu.org Received: via spool by 43881-submit@debbugs.gnu.org id=B43881.16026675253564 (code B ref 43881); Wed, 14 Oct 2020 09:26:01 +0000 Received: (at 43881) by debbugs.gnu.org; 14 Oct 2020 09:25:25 +0000 Received: from localhost ([127.0.0.1]:50079 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kSd2C-0000vQ-Jf for submit@debbugs.gnu.org; Wed, 14 Oct 2020 05:25:24 -0400 Received: from flashner.co.il ([178.62.234.194]:54894) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kSd2B-0000vD-6D for 43881@debbugs.gnu.org; Wed, 14 Oct 2020 05:25:23 -0400 Received: from localhost (unknown [141.226.15.20]) by flashner.co.il (Postfix) with ESMTPSA id 4D0954014A; Wed, 14 Oct 2020 09:25:17 +0000 (UTC) Date: Wed, 14 Oct 2020 12:24:44 +0300 From: Efraim Flashner Message-ID: <20201014092444.GC16635@E5400> References: <20201009134253.26375-1-efraim@flashner.co.il> <20201009134253.26375-2-efraim@flashner.co.il> <87ft6hf9me.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="kVXhAStRUZ/+rrGn" Content-Disposition: inline In-Reply-To: <87ft6hf9me.fsf@gnu.org> X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -2.61 X-TUID: l86/nbliDXqs --kVXhAStRUZ/+rrGn Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Oct 14, 2020 at 11:19:05AM +0200, Ludovic Court=C3=A8s wrote: > Efraim Flashner skribis: >=20 > > * gnu/system.scm (%base-packages-interactive): Add nvi. > > * gnu/system/install.scm (installation-os)[packages]: Remove parted, > > gptfdisk, ddrescue, cryptsetup, mdadm, dosfstools, btrfs-progs, > > f2fs-tools, jfstools, openssh, wireless-tools, iw, > > wpa-supplicant-minimal, iproute, bash-completion, nvi. Replace glibc > > with the canonical-package of glibc. Add %base-packages-disk-utils. > > > > remove wpa-supplicant-minimal > > replace glibc with canonical-pacakge glibc >=20 > These two lines are a leftover? Looks like they're a leftover from squashing two commits. Especially looking at my typo for package. > I think we want to keep =E2=80=98wpa-supplicant-minimal=E2=80=99 and keep= =E2=80=98glibc=E2=80=99, not > the canonical-package variant (it would prevent cross-compilation). We should already have wpa-supplicant available from the wpa-supplicant-service-type. Understood about the canonical-package bit. > Apart from that, if that leaves the package set unchanged, LGTM! >=20 > Ludo=E2=80=99. Thanks for the review. --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --kVXhAStRUZ/+rrGn Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAl+Gw9wACgkQQarn3Mo9 g1Gx7xAAiQD4Cpri1d1WE0d6z4eMrBmFUIkLz12EipOlGsBCi/ZJj72SNB1yomzA rUxqMktwXLlLsqSDL7XkP4HkkYYeRlBEuzIhiCD7pEq+Z4hy0EoIBCA5CTCi0cox loicW20AL7ZnCQOgbOlgp/tsybdsKVtj9pHxllauGGK8DriC/PD07dLafP2nNw7C bF28ahyjThBCvQYVx6qX/jJQ3MGg1slhBLRXcmJYzXAqstE/MLXj6LoN7VaGJwEV NlF89MoVdNJesFKL/y4sH4mwfRXf1gIVZ0RyC1S3Wx9utmZl/IZ4RqEWNUG6B4ZE oHURZKpmwnrqNWL5lVPx+9nOH14idCy480aptQFAwhecNjRpaPxN/5CFcwQR1MtT UiXYAYg4eupMqFh/EClWyfGX7sz0pHQ/R6Jb8a7+Z1M8g9zV1jtgC7z7YzvlbQM2 iaweyouxHFz96J2jEH6eKPEAt/j5jmj6Qp+UA8JTA64HCPoGjRz+tgxf7VqX4uqJ aZrGPVNo68+Jwqr6Xkt+XYTdW4M6PXBClRFrvpLCJLsZwXil4+5WtW0SEB4R4kTG pDf73+TaDKzV/iuCnyUJ17bTu8ms4zpLHVDAohuyyjevvmTJWA7s9bxgdjYDEHyj rAuHvWUmoTaBK4jvAEml9Ncj47GY0FlGxk7CfJStWK8QevyicbY= =hP3l -----END PGP SIGNATURE----- --kVXhAStRUZ/+rrGn--