From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id SC2CCH7Dhl+7YQAA0tVLHw (envelope-from ) for ; Wed, 14 Oct 2020 09:23:10 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id wEVpBH7Dhl8wGwAAB5/wlQ (envelope-from ) for ; Wed, 14 Oct 2020 09:23:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A542C94071A for ; Wed, 14 Oct 2020 09:23:09 +0000 (UTC) Received: from localhost ([::1]:57874 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kSd00-0005jG-Jt for larch@yhetil.org; Wed, 14 Oct 2020 05:23:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46362) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kSczu-0005ic-4N for guix-patches@gnu.org; Wed, 14 Oct 2020 05:23:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:38523) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kSczt-0006qj-Qx for guix-patches@gnu.org; Wed, 14 Oct 2020 05:23:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kSczt-0000rH-Nh for guix-patches@gnu.org; Wed, 14 Oct 2020 05:23:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#43881] [PATCH 1/2] system: Add %base-packages-disk-utils. Resent-From: Efraim Flashner Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 14 Oct 2020 09:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43881 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 43881@debbugs.gnu.org Received: via spool by 43881-submit@debbugs.gnu.org id=B43881.16026673343230 (code B ref 43881); Wed, 14 Oct 2020 09:23:01 +0000 Received: (at 43881) by debbugs.gnu.org; 14 Oct 2020 09:22:14 +0000 Received: from localhost ([127.0.0.1]:50069 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kScz7-0000q1-4U for submit@debbugs.gnu.org; Wed, 14 Oct 2020 05:22:14 -0400 Received: from flashner.co.il ([178.62.234.194]:54866) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kScz5-0000po-EI for 43881@debbugs.gnu.org; Wed, 14 Oct 2020 05:22:12 -0400 Received: from localhost (unknown [141.226.15.20]) by flashner.co.il (Postfix) with ESMTPSA id A39A940300; Wed, 14 Oct 2020 09:22:05 +0000 (UTC) Date: Wed, 14 Oct 2020 12:21:33 +0300 From: Efraim Flashner Message-ID: <20201014092133.GB16635@E5400> References: <20201009133917.26124-1-efraim@flashner.co.il> <20201009134253.26375-1-efraim@flashner.co.il> <87lfg9f9pn.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="s2ZSL+KKDSLx8OML" Content-Disposition: inline In-Reply-To: <87lfg9f9pn.fsf@gnu.org> X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -2.61 X-TUID: i7398ivEGJBk --s2ZSL+KKDSLx8OML Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Oct 14, 2020 at 11:17:08AM +0200, Ludovic Court=C3=A8s wrote: > Hi! >=20 > Efraim Flashner skribis: >=20 > > * gnu/system.scm (%base-packages-disk-utils): New variable. >=20 >=20 > [...] >=20 > > #:use-module (guix diagnostics) > > + #:use-module (gnu packages admin) > > #:use-module (gnu packages base) > > #:use-module (gnu packages bash) > > + #:use-module (gnu packages compression) > > #:use-module (gnu packages cross-base) > > + #:use-module (gnu packages cryptsetup) > > + #:use-module (gnu packages disk) > > + #:use-module (gnu packages file-systems) > > + #:use-module (gnu packages firmware) > > + #:use-module (gnu packages gawk) > > #:use-module (gnu packages guile) > > #:use-module (gnu packages guile-xyz) > > - #:use-module (gnu packages admin) > > #:use-module (gnu packages hurd) > > - #:use-module (gnu packages linux) > > - #:use-module (gnu packages pciutils) > > - #:use-module (gnu packages package-management) > > #:use-module (gnu packages less) > > - #:use-module (gnu packages zile) > > - #:use-module (gnu packages nano) > > - #:use-module (gnu packages gawk) > > + #:use-module (gnu packages linux) > > #:use-module (gnu packages man) > > + #:use-module (gnu packages nano) > > + #:use-module (gnu packages package-management) > > + #:use-module (gnu packages pciutils) > > #:use-module (gnu packages texinfo) > > - #:use-module (gnu packages compression) > > - #:use-module (gnu packages firmware) > > + #:use-module (gnu packages zile) > > #:use-module (gnu services) > > #:use-module (gnu services shepherd) > > #:use-module (gnu services base) >=20 > Does it pull new modules or just reorder them? If the latter, fine with = me! It reorders them and adds cryptsetup, disk and file-systems. > > @@ -159,6 +163,7 @@ > > %base-packages-interactive > > %base-packages-linux > > %base-packages-networking > > + %base-packages-disk-utils > > %base-packages-utils >=20 > Now there=E2=80=99s a precedent but I think we should have written =E2=80= =9Cutilities=E2=80=9D > for consistency with the rest of the code base. >=20 > Maybe you can do that here and then we can deprecate > =E2=80=98%base-packages-utils=E2=80=99 in favor of =E2=80=98%base-package= -utilities=E2=80=99. +1 for utilities over utils > Thanks, > Ludo=E2=80=99. --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --s2ZSL+KKDSLx8OML Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAl+GwxoACgkQQarn3Mo9 g1GNQw/8Ce0YM/Z98WFaHdocFayfsOwEsCUVZGoWXJ4EZmlONk9HHm9GHXgHmOcE SqTYRcxMPffyBml2XyWcqZriuViKD6DS2WaLslDUUhZOxPFlQPxcYZnomai6Zl9Y 6T+gIDEmw7awkiYRe8r+0xzevjCZBsNX8bqB6+zt7pT4fmSDh+x4MOzbWjwtEk65 bdE6aAzTtlWI7f2Rpl9wcYI/dkMJ41mrGPn7hJm4Jd5nlHUpobB+qXA7tzPuZfv5 jwbXeNPDB0wzp1KaYpBWnIyyTmC2VktdBRGkVGPTm/uuk1JB8CKGLCVKvyhoG/PV vDtnZI9bfJuC6Ymo8ZwrpD99RVqA5KH5mv6vg+kVDupxU8Xn4S7hEofDmwEiif+j /1iZMVyaKGXzjbTywc5ZPhyotFx46keFFNSvoycQSRj05G31cYqmp8zLLQSZHU9s 1trWWAX+4pard7lcjQCgZjJ1P3wJJ8BUEqkThyu4aFkkFc3BvGorckjDOk7fOQGk NCppVqBJiuStyvL4m3aWHYlxyIKl+dmvRVhp5pNUi0ql6gixICZAq4pdwOgCQgiJ sXX0QgIhHi5Gw/pGquA3YLLqirxSuSQWLntye2a1deUPq/xBWAomvlPy279+Wkgp IEP0Lnq+vgNAWTYHOIYSo0fwDqIE/GYs9WUmC4Lf3V4Jq2A62eQ= =sZid -----END PGP SIGNATURE----- --s2ZSL+KKDSLx8OML--