On Wed, Oct 14, 2020 at 11:17:08AM +0200, Ludovic Courtès wrote: > Hi! > > Efraim Flashner skribis: > > > * gnu/system.scm (%base-packages-disk-utils): New variable. > > > [...] > > > #:use-module (guix diagnostics) > > + #:use-module (gnu packages admin) > > #:use-module (gnu packages base) > > #:use-module (gnu packages bash) > > + #:use-module (gnu packages compression) > > #:use-module (gnu packages cross-base) > > + #:use-module (gnu packages cryptsetup) > > + #:use-module (gnu packages disk) > > + #:use-module (gnu packages file-systems) > > + #:use-module (gnu packages firmware) > > + #:use-module (gnu packages gawk) > > #:use-module (gnu packages guile) > > #:use-module (gnu packages guile-xyz) > > - #:use-module (gnu packages admin) > > #:use-module (gnu packages hurd) > > - #:use-module (gnu packages linux) > > - #:use-module (gnu packages pciutils) > > - #:use-module (gnu packages package-management) > > #:use-module (gnu packages less) > > - #:use-module (gnu packages zile) > > - #:use-module (gnu packages nano) > > - #:use-module (gnu packages gawk) > > + #:use-module (gnu packages linux) > > #:use-module (gnu packages man) > > + #:use-module (gnu packages nano) > > + #:use-module (gnu packages package-management) > > + #:use-module (gnu packages pciutils) > > #:use-module (gnu packages texinfo) > > - #:use-module (gnu packages compression) > > - #:use-module (gnu packages firmware) > > + #:use-module (gnu packages zile) > > #:use-module (gnu services) > > #:use-module (gnu services shepherd) > > #:use-module (gnu services base) > > Does it pull new modules or just reorder them? If the latter, fine with me! It reorders them and adds cryptsetup, disk and file-systems. > > @@ -159,6 +163,7 @@ > > %base-packages-interactive > > %base-packages-linux > > %base-packages-networking > > + %base-packages-disk-utils > > %base-packages-utils > > Now there’s a precedent but I think we should have written “utilities” > for consistency with the rest of the code base. > > Maybe you can do that here and then we can deprecate > ‘%base-packages-utils’ in favor of ‘%base-package-utilities’. +1 for utilities over utils > Thanks, > Ludo’. -- Efraim Flashner אפרים פלשנר GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted