From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id KPaLHi40hl+COgAA0tVLHw (envelope-from ) for ; Tue, 13 Oct 2020 23:11:42 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id eN90Gi40hl/LQwAAB5/wlQ (envelope-from ) for ; Tue, 13 Oct 2020 23:11:42 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 384339401DE for ; Tue, 13 Oct 2020 23:11:41 +0000 (UTC) Received: from localhost ([::1]:53422 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kSTSE-0006aL-JW for larch@yhetil.org; Tue, 13 Oct 2020 19:11:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38858) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kSTRe-0006GU-O7 for guix-patches@gnu.org; Tue, 13 Oct 2020 19:11:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:37649) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kSTRe-0004GE-Ds for guix-patches@gnu.org; Tue, 13 Oct 2020 19:11:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kSTRe-0006TY-8T for guix-patches@gnu.org; Tue, 13 Oct 2020 19:11:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#41803] [PATCH] Yggdrasil package and accompanying shepherd service (mesh network) References: <20200611155656.7ece9c24@riseup.net> In-Reply-To: <20200611155656.7ece9c24@riseup.net> Resent-From: Julien Lepiller Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 13 Oct 2020 23:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41803 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 41803@debbugs.gnu.org Received: via spool by 41803-submit@debbugs.gnu.org id=B41803.160263060524823 (code B ref 41803); Tue, 13 Oct 2020 23:11:02 +0000 Received: (at 41803) by debbugs.gnu.org; 13 Oct 2020 23:10:05 +0000 Received: from localhost ([127.0.0.1]:49195 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kSTQj-0006SH-CL for submit@debbugs.gnu.org; Tue, 13 Oct 2020 19:10:05 -0400 Received: from lepiller.eu ([89.234.186.109]:46084) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kSTQd-0006Rg-Tf for 41803@debbugs.gnu.org; Tue, 13 Oct 2020 19:10:03 -0400 Received: from lepiller.eu (localhost [127.0.0.1]) by lepiller.eu (OpenSMTPD) with ESMTP id c6a64154 for <41803@debbugs.gnu.org>; Tue, 13 Oct 2020 23:09:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lepiller.eu; h=date:from :to:subject:message-id:mime-version:content-type :content-transfer-encoding; s=dkim; bh=/iDuHF2+0qjEOkUMEVvegzYPO 7tVPEQbZdZmS4fER2Q=; b=S8HqF6Tl2819SSNUMTBhNT1NPKbFigX5IubvFak5h PNUggdhNR3a1urWiT897/bpiAYBmEXgVrWck6y4iREhqfTOhhoybBIC6McqZW+NJ lLd7aKiS3YzVN3WSb2c1NGrv3R+BQawQLoegnH5sCC06gXmB1ztBlg4vRCfM3Jgb 95BYGKMPN3snOFEIK2TI1IALD+kIgqKTFyWSyPVthxR0HSrIRZPBavHTMYtZv6Ee x7c5N3j97jPCxnppBONytLxoMxuCQXrJ6/knGQ/eGSm5XHJqXjL5viR1b/cH4Db4 mPuK3rE/Ldc5TUKqXJ8/kcYkYlJHmu0Jc6QizKcx8AR6g== Received: by lepiller.eu (OpenSMTPD) with ESMTPSA id f2223411 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO) for <41803@debbugs.gnu.org>; Tue, 13 Oct 2020 23:09:54 +0000 (UTC) Date: Wed, 14 Oct 2020 01:09:42 +0200 From: Julien Lepiller Message-ID: <20201014010942.59e16051@tachikoma> X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=lepiller.eu header.s=dkim header.b=S8HqF6Tl; dmarc=fail reason="SPF not aligned (relaxed)" header.from=lepiller.eu (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: 2.09 X-TUID: 1uqy+wd5s7MV Hi, I went ahead and pushed your first four patches with changes. I'll need you to work a bit more before I can push the rest. I've added a copyright line for you in golang.scm. For the rest of the packages, could you split all your patches into one patch per package? For each package, please run "guix lint" and fix any issue (except for archival, you can't do anything about it). This includes: using (file-name (git-file-name name version)) inside the origin record, making sure the synopsis doesn't start with "A", and the description ends with a full stop. I also changed you commit messages: don't include the version number for added packages and add a full stop at the end of messages. For yggdrasil, please grep for dist_PATCH_DATA in the git log, you'll find examples of good commit messages :) For the service, changes to the documentation are usually made in the same patch, so could you please merge your last three patches? I don't know if we can use guile-json directly in a service definition without causing troubles for people who have different versions of guile-json in their profile already. I'll have to ask people who are more knowledgeable than me! To chown the socket, you'll need an activation service type (if the socket survives restarts of yggdrasil), or to change the start action of the shepherd service type. Your changes to the documentation look good, but incomplete. Could you rebase and send updated patches for the rest of this series? Thank you!