unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#43946] [PATCH] doc: Add item to "Submitting Patches" section.
@ 2020-10-12  8:20 zimoun
  2020-10-24  9:01 ` bug#43946: " Oleg Pykhalov
  2021-01-15 13:30 ` Ludovic Courtès
  0 siblings, 2 replies; 8+ messages in thread
From: zimoun @ 2020-10-12  8:20 UTC (permalink / raw)
  To: 43946; +Cc: zimoun

* doc/contributing.texi (Submitting Patches): Add item about 'git-format-patch
--base'.
---
 doc/contributing.texi | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/doc/contributing.texi b/doc/contributing.texi
index af3601442e..5ea3cb1899 100644
--- a/doc/contributing.texi
+++ b/doc/contributing.texi
@@ -932,6 +932,12 @@ Before submitting a patch that adds or modifies a package definition,
 please run through this check list:
 
 @enumerate
+@cindex @code{git format-patch}
+@cindex @code{git-format-patch}
+@item
+We recommend to use the command @code{git format-patch --base} to
+include the commit where your patch applies.
+
 @item
 If the authors of the packaged software provide a cryptographic
 signature for the release tarball, make an effort to verify the

base-commit: e746d30ec15852ec50e4247ea0a07ab2a9a69aa8
-- 
2.28.0





^ permalink raw reply related	[flat|nested] 8+ messages in thread

* bug#43946: [PATCH] doc: Add item to "Submitting Patches" section.
  2020-10-12  8:20 [bug#43946] [PATCH] doc: Add item to "Submitting Patches" section zimoun
@ 2020-10-24  9:01 ` Oleg Pykhalov
  2020-10-24  9:17   ` [bug#43946] " zimoun
  2021-01-15 13:30 ` Ludovic Courtès
  1 sibling, 1 reply; 8+ messages in thread
From: Oleg Pykhalov @ 2020-10-24  9:01 UTC (permalink / raw)
  To: zimoun; +Cc: 43946-done

[-- Attachment #1: Type: text/plain, Size: 969 bytes --]

Hi,

zimoun <zimon.toutoune@gmail.com> writes:

> * doc/contributing.texi (Submitting Patches): Add item about 'git-format-patch
> --base'.
> ---
>  doc/contributing.texi | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/doc/contributing.texi b/doc/contributing.texi
> index af3601442e..5ea3cb1899 100644
> --- a/doc/contributing.texi
> +++ b/doc/contributing.texi
> @@ -932,6 +932,12 @@ Before submitting a patch that adds or modifies a package definition,
>  please run through this check list:
>  
>  @enumerate
> +@cindex @code{git format-patch}
> +@cindex @code{git-format-patch}
> +@item
> +We recommend to use the command @code{git format-patch --base} to
> +include the commit where your patch applies.

“git format-patch” already mentioned in the documentation in the first
paragraph https://guix.gnu.org/manual/en/html_node/Submitting-Patches.html

Do I miss something?  Fill free to reopen the issue ;-)

Oleg.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [bug#43946] [PATCH] doc: Add item to "Submitting Patches" section.
  2020-10-24  9:01 ` bug#43946: " Oleg Pykhalov
@ 2020-10-24  9:17   ` zimoun
  0 siblings, 0 replies; 8+ messages in thread
From: zimoun @ 2020-10-24  9:17 UTC (permalink / raw)
  To: Oleg Pykhalov; +Cc: 43946-done

Dear,

Thank you for the review.

On Sat, 24 Oct 2020 at 11:01, Oleg Pykhalov <go.wigust@gmail.com> wrote:
> zimoun <zimon.toutoune@gmail.com> writes:
>
> > * doc/contributing.texi (Submitting Patches): Add item about 'git-format-patch
> > --base'.
> > ---
> >  doc/contributing.texi | 6 ++++++
> >  1 file changed, 6 insertions(+)
> >
> > diff --git a/doc/contributing.texi b/doc/contributing.texi
> > index af3601442e..5ea3cb1899 100644
> > --- a/doc/contributing.texi
> > +++ b/doc/contributing.texi
> > @@ -932,6 +932,12 @@ Before submitting a patch that adds or modifies a package definition,
> >  please run through this check list:
> >
> >  @enumerate
> > +@cindex @code{git format-patch}
> > +@cindex @code{git-format-patch}
> > +@item
> > +We recommend to use the command @code{git format-patch --base} to
> > +include the commit where your patch applies.
>
> “git format-patch” already mentioned in the documentation in the first
> paragraph https://guix.gnu.org/manual/en/html_node/Submitting-Patches.html

The point of the patch is:
 - the addition of the cindex
 - the addition of the option --base
and AFAITC it is not already in the manual.  If it is the wrong place,
please let me know where it could be better.

All the best,
simon




^ permalink raw reply	[flat|nested] 8+ messages in thread

* [bug#43946] [PATCH] doc: Add item to "Submitting Patches" section.
  2020-10-12  8:20 [bug#43946] [PATCH] doc: Add item to "Submitting Patches" section zimoun
  2020-10-24  9:01 ` bug#43946: " Oleg Pykhalov
@ 2021-01-15 13:30 ` Ludovic Courtès
  2021-01-15 14:00   ` zimoun
  2021-09-21  9:53   ` zimoun
  1 sibling, 2 replies; 8+ messages in thread
From: Ludovic Courtès @ 2021-01-15 13:30 UTC (permalink / raw)
  To: zimoun; +Cc: 43946

Hi Simon!

zimoun <zimon.toutoune@gmail.com> skribis:

> * doc/contributing.texi (Submitting Patches): Add item about 'git-format-patch
> --base'.
> ---
>  doc/contributing.texi | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/doc/contributing.texi b/doc/contributing.texi
> index af3601442e..5ea3cb1899 100644
> --- a/doc/contributing.texi
> +++ b/doc/contributing.texi
> @@ -932,6 +932,12 @@ Before submitting a patch that adds or modifies a package definition,
>  please run through this check list:
>  
>  @enumerate
> +@cindex @code{git format-patch}
> +@cindex @code{git-format-patch}
> +@item
> +We recommend to use the command @code{git format-patch --base} to
> +include the commit where your patch applies.

I’m not entirely convinced TBH, in part because I know I often pile a
couple of WIP branches on top of one another, “knowing what I’m doing”
(actually hoping that I do), and so the base commit would be useless in
this case.

Closing?  :-)

Thanks,
Ludo’.




^ permalink raw reply	[flat|nested] 8+ messages in thread

* [bug#43946] [PATCH] doc: Add item to "Submitting Patches" section.
  2021-01-15 13:30 ` Ludovic Courtès
@ 2021-01-15 14:00   ` zimoun
  2021-03-26  5:40     ` zimoun
  2021-09-21  9:53   ` zimoun
  1 sibling, 1 reply; 8+ messages in thread
From: zimoun @ 2021-01-15 14:00 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: 43946

Hi Ludo,

On Fri, 15 Jan 2021 at 14:30, Ludovic Courtès <ludo@gnu.org> wrote:

> > +We recommend to use the command @code{git format-patch --base} to
> > +include the commit where your patch applies.
>
> I’m not entirely convinced TBH, in part because I know I often pile a
> couple of WIP branches on top of one another, “knowing what I’m doing”
> (actually hoping that I do), and so the base commit would be useless in
> this case.

I am not buying your argument. :-)
It is not because <name> does not use this information that it cannot
be a recommendation, i.e., a suggestion or advice on what seems
helpful.
Other said, it is not because it is "useless in this case" that it is
useless in other cases.

For example, this information about which known commit that patch
applies is helping for the automation of testing patches.  Well, see
[1,2] for instance.  Discussions of such tooling happened in #44625
[3] and Emacs helper [4].


1: <https://git.kernel.org/pub/scm/utils/b4/b4.git/tree/README.rst>
2: <https://docs.kyleam.com/piem/Using-b4-to-apply-patches.html>
3: <http://issues.guix.gnu.org/44625>
4: <https://inbox.kyleam.com/piem/20201115061518.22191-1-kyle@kyleam.com/>

> Closing?  :-)

As you want. :-)
But, I think "qui peut le plus peut le moins".  Even if maybe my
wording is not the good one, I still think that the "base-commit"
where the patch applies should be provided, at least suggested.

Cheers,
simon




^ permalink raw reply	[flat|nested] 8+ messages in thread

* [bug#43946] [PATCH] doc: Add item to "Submitting Patches" section.
  2021-01-15 14:00   ` zimoun
@ 2021-03-26  5:40     ` zimoun
  0 siblings, 0 replies; 8+ messages in thread
From: zimoun @ 2021-03-26  5:40 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: 43946

Hi Ludo,


On Fri, 15 Jan 2021 at 15:00, zimoun <zimon.toutoune@gmail.com> wrote:
> On Fri, 15 Jan 2021 at 14:30, Ludovic Courtès <ludo@gnu.org> wrote:
>
>> > +We recommend to use the command @code{git format-patch --base} to
>> > +include the commit where your patch applies.
>>
>> I’m not entirely convinced TBH, in part because I know I often pile a
>> couple of WIP branches on top of one another, “knowing what I’m doing”
>> (actually hoping that I do), and so the base commit would be useless in
>> this case.

[...]

>> Closing?  :-)
>
> As you want. :-)
> But, I think "qui peut le plus peut le moins".  Even if maybe my
> wording is not the good one, I still think that the "base-commit"
> where the patch applies should be provided, at least suggested.

I still think that recommending to provide the commit on which it is
known that the patch (or patch set) applies is a good recommendation.
Especially when the submission rate is greater than the review rate and
the tree is moving really quickly (yeah!).

It is no extra work for the submitter and really helps for the reviewer.
They applies at base-commit, checks, rebases and resolves conflicts if
they are.  Otherwise, the patch is useless or it needs to be rewritten
by hand (or please indicate me how to do :-)).

BTW, it helps automation tools.

Sometimes, this base-commit is useless for the reviewer workflow but
having it does not interfere.  Having an information does not mean it
must be used.  However, not having an information implies it cannot be
used. ;-)


Cheers,
simon




^ permalink raw reply	[flat|nested] 8+ messages in thread

* [bug#43946] [PATCH] doc: Add item to "Submitting Patches" section.
  2021-01-15 13:30 ` Ludovic Courtès
  2021-01-15 14:00   ` zimoun
@ 2021-09-21  9:53   ` zimoun
  2021-09-22 13:02     ` bug#43946: " Ludovic Courtès
  1 sibling, 1 reply; 8+ messages in thread
From: zimoun @ 2021-09-21  9:53 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: 43946

Hi Ludo,

On Fri, 15 Jan 2021 at 14:30, Ludovic Courtès <ludo@gnu.org> wrote:
> zimoun <zimon.toutoune@gmail.com> skribis:
>
>> * doc/contributing.texi (Submitting Patches): Add item about 'git-format-patch
>> --base'.
>> ---
>>  doc/contributing.texi | 6 ++++++
>>  1 file changed, 6 insertions(+)
>>
>> diff --git a/doc/contributing.texi b/doc/contributing.texi
>> index af3601442e..5ea3cb1899 100644
>> --- a/doc/contributing.texi
>> +++ b/doc/contributing.texi
>> @@ -932,6 +932,12 @@ Before submitting a patch that adds or modifies a package definition,
>>  please run through this check list:
>>  
>>  @enumerate
>> +@cindex @code{git format-patch}
>> +@cindex @code{git-format-patch}
>> +@item
>> +We recommend to use the command @code{git format-patch --base} to
>> +include the commit where your patch applies.
>
> I’m not entirely convinced TBH, in part because I know I often pile a
> couple of WIP branches on top of one another, “knowing what I’m doing”
> (actually hoping that I do), and so the base commit would be useless in
> this case.

Could you explain more?  Here [#,@], I argument:

--8<---------------cut here---------------start------------->8---
It is not because <name> does not use this information that it cannot be
a recommendation, i.e., a suggestion or advice on what seems helpful.
Other said, it is not because it is "useless in this case" that it
isuseless in other cases.

For example, this information about which known commit that patch
applies is helping for the automation of testing patches.  Well,
see [1,2] for instance.  Discussions of such tooling happened in
#44625 [3] and Emacs helper [4].

1: https://git.kernel.org/pub/scm/utils/b4/b4.git/tree/README.rst
2: https://docs.kyleam.com/piem/Using-b4-to-apply-patches.html
3: http://issues.guix.gnu.org/44625
4: https://inbox.kyleam.com/piem/20201115061518.22191-1-kyle@kyleam.com/

[..]

I still think that recommending to provide the commit on which it
isknown that the patch (or patch set) applies is a good recommendation.
Especially when the submission rate is greater than the review rate
andthe tree is moving really quickly (yeah!).

It is no extra work for the submitter and really helps for the
reviewer.  They applies at base-commit, checks, rebases and resolves
conflicts if they are.  Otherwise, the patch is useless or it needs to
be rewritten by hand (or please indicate me how to do :-)).

BTW, it helps automation tools.

Sometimes, this base-commit is useless for the reviewer workflow but
having it does not interfere.  Having an information does not mean it
must be used.  However, not having an information implies it cannot be
used. ;-)
--8<---------------cut here---------------end--------------->8---

#: <http://issues.guix.gnu.org/issue/43946#5>
@: <http://issues.guix.gnu.org/issue/43946#6>


Seeing the number of patches in the patch tracker, most of them does not
apply anymore.  It is not encouraging to review and decrease the queue
when first the reviewer has to guess onto which commit the patch
applies.


Cheers,
simon




^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#43946: [PATCH] doc: Add item to "Submitting Patches" section.
  2021-09-21  9:53   ` zimoun
@ 2021-09-22 13:02     ` Ludovic Courtès
  0 siblings, 0 replies; 8+ messages in thread
From: Ludovic Courtès @ 2021-09-22 13:02 UTC (permalink / raw)
  To: zimoun; +Cc: 43946-done

Hi,

zimoun <zimon.toutoune@gmail.com> skribis:

> Seeing the number of patches in the patch tracker, most of them does not
> apply anymore.  It is not encouraging to review and decrease the queue
> when first the reviewer has to guess onto which commit the patch
> applies.

Yeah in hindsight I think I agree with you.  I went ahead and (finally!)
applied the patch.

Thanks for persevering, and apologies for my stubbornness!  :-)

Ludo’.




^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2021-09-22 13:04 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-12  8:20 [bug#43946] [PATCH] doc: Add item to "Submitting Patches" section zimoun
2020-10-24  9:01 ` bug#43946: " Oleg Pykhalov
2020-10-24  9:17   ` [bug#43946] " zimoun
2021-01-15 13:30 ` Ludovic Courtès
2021-01-15 14:00   ` zimoun
2021-03-26  5:40     ` zimoun
2021-09-21  9:53   ` zimoun
2021-09-22 13:02     ` bug#43946: " Ludovic Courtès

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).