From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id WAf9B7Xegl8YLgAA0tVLHw (envelope-from ) for ; Sun, 11 Oct 2020 10:30:13 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id ODTCA7Xegl/wbAAAB5/wlQ (envelope-from ) for ; Sun, 11 Oct 2020 10:30:13 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A50299402A8 for ; Sun, 11 Oct 2020 10:30:11 +0000 (UTC) Received: from localhost ([::1]:45530 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kRYcD-0002B0-53 for larch@yhetil.org; Sun, 11 Oct 2020 06:30:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57824) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kRYc6-0002Aj-B3 for guix-patches@gnu.org; Sun, 11 Oct 2020 06:30:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:55918) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kRYc6-0003gp-1Q for guix-patches@gnu.org; Sun, 11 Oct 2020 06:30:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kRYc5-0007qD-Rg for guix-patches@gnu.org; Sun, 11 Oct 2020 06:30:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#43840] [PATCH] gnu: Add esbuild. Resent-From: Efraim Flashner Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 11 Oct 2020 10:30:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43840 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ryan Prior Cc: "43840@debbugs.gnu.org" <43840@debbugs.gnu.org> Received: via spool by 43840-submit@debbugs.gnu.org id=B43840.160241217630086 (code B ref 43840); Sun, 11 Oct 2020 10:30:01 +0000 Received: (at 43840) by debbugs.gnu.org; 11 Oct 2020 10:29:36 +0000 Received: from localhost ([127.0.0.1]:39231 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kRYbg-0007pC-8V for submit@debbugs.gnu.org; Sun, 11 Oct 2020 06:29:36 -0400 Received: from flashner.co.il ([178.62.234.194]:46530) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kRYbc-0007ox-4g for 43840@debbugs.gnu.org; Sun, 11 Oct 2020 06:29:34 -0400 Received: from localhost (unknown [141.226.15.20]) by flashner.co.il (Postfix) with ESMTPSA id AC9FB4027B; Sun, 11 Oct 2020 10:29:25 +0000 (UTC) Date: Sun, 11 Oct 2020 13:28:53 +0300 From: Efraim Flashner Message-ID: <20201011102853.GB1301@E5400> References: <20201007023119.22495-1-rprior@protonmail.com> <20201007063431.GH21174@E5400> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="hHWLQfXTYDoKhP50" Content-Disposition: inline In-Reply-To: X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.11 X-TUID: NBegGcRkDkUQ --hHWLQfXTYDoKhP50 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Oct 08, 2020 at 02:08:36AM +0000, Ryan Prior wrote: > Hey Efraim, thank you for your comments! >=20 > On Wednesday, October 7th, 2020 at 6:34 AM, Efraim Flashner wrote: >=20 > > There is an npm directory which is where the compiled binaries are > > placed, there are a couple in the checked out repo. >=20 > The compiled binaries might be placed there by the gnu-build-system, but = the go-build-system does not put binaries there by itself. (Note that their= make target explicitly specifies output directories.) >=20 > I think our build totally ignores this directory, so it shouldn't matter = whether we delete it, but if you think removing the unneeded directory impr= oves the package I'll update the patch with a snippet. It's important to not ship any precompiled binaries so go ahead and remove them in a snippet. > > Is it worth trying to run some of the test suite? I see there are a > > couple of 'make check' type targets in the Makefile at the root of = the > > repository and currently there are none run during the build. >=20 > It would be nice to run their tests, but the test system currently assume= s network access to install some various JavaScript dependencies using npm.= We might patch the test system and vendor in the deps (used only for testi= ng,) what do you think? >=20 I was able to run some of the test suite with the following arguments secti= on: (arguments '(#:import-path "github.com/evanw/esbuild/cmd/esbuild" #:unpack-path "github.com/evanw/esbuild" #:phases (modify-phases %standard-phases (replace 'check (lambda* (#:key tests? unpack-path #:allow-other-keys) (if tests? (with-directory-excursion (string-append "src/" unpack-path) (invoke "make" "test-go")) #t)))))) Unfortunately it also depends on github.com/kylelemons/godebug/diff, but it doesn't look like it has any dependants. With that added as a native-input I think it's ready. > Ryan Thanks --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --hHWLQfXTYDoKhP50 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAl+C3mIACgkQQarn3Mo9 g1GguA/+LSWqZyAvyql0Try/Xq2EIHSSIb42KqBG7lQMJo4JbgeTqFWWvK0kNalC ee3Ks8DvasuEM0WYbk2wWsoC0u+fseYeefZkb8aHIGXeti8iTLUcOaauGTHE96ym BMPqL3QiQhDY2r6ALJKJWCsxMZvO/z+ynpqJkPLSRoYkBJHYkyBh3xekeLL0zjXK hoKfqMirpOcpR9l7iT3rowdjC+DBWq4x8UIC8DjHN6FsxAbpgdTZRXzEIpg1jy9s US+nWFiJ2FTbtP/9C/6HtpolOgusBZZ0JiAkhnA0qC1wBJabm1hGuiAydeBfdK4u nqXMVYl9JHKQiR9H0HWr6P7rbKbnf9ZxoyoWrJioRa4Z27BTjbzJT/7c05a/EW5F SCFTitCivrPLDNmBGghwJxkOHyOnTUNmwpWhH2cxcalh9ZfFFy3MKX7rHiQq1g6R Voz4zM27do2vrdu8/0c+u6SdOjgfARqPRetzDNkSJYW/ehpEIwM0ojyhYtpsa2X7 7l2i6RVkI8+UebA/aw52+hhs8lxTKUJnrxA97YU2BQ0/b7rDrfTql+plkXPoVY1w ucYqCItAqgy9ClxQbusgwcoiDQsMO50OvOCPdG5jRYSgvp75+fu9SANFJyuZeHXw O9+rtLTuGjkX5sytQGyNf//dFAMt/YYrpm2h2XAvfqqH/rZE7SA= =PX+p -----END PGP SIGNATURE----- --hHWLQfXTYDoKhP50--