From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id WtGzK+QpgF9oRwAA0tVLHw (envelope-from ) for ; Fri, 09 Oct 2020 09:14:12 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id kP1KJ+QpgF+dXAAA1q6Kng (envelope-from ) for ; Fri, 09 Oct 2020 09:14:12 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5FFA6940539 for ; Fri, 9 Oct 2020 09:14:12 +0000 (UTC) Received: from localhost ([::1]:35944 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kQoTb-0007ha-6t for larch@yhetil.org; Fri, 09 Oct 2020 05:14:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55826) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kQoTT-0007gj-DL for guix-patches@gnu.org; Fri, 09 Oct 2020 05:14:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:50802) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kQoTT-0001nQ-40 for guix-patches@gnu.org; Fri, 09 Oct 2020 05:14:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kQoTT-00048N-0F for guix-patches@gnu.org; Fri, 09 Oct 2020 05:14:03 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#43679] [PATCH v2 0/5] Add '--with-c-toolchain' Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 09 Oct 2020 09:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43679 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 43679@debbugs.gnu.org Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 43679-submit@debbugs.gnu.org id=B43679.160223478515769 (code B ref 43679); Fri, 09 Oct 2020 09:14:02 +0000 Received: (at 43679) by debbugs.gnu.org; 9 Oct 2020 09:13:05 +0000 Received: from localhost ([127.0.0.1]:34103 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kQoSX-00046C-1J for submit@debbugs.gnu.org; Fri, 09 Oct 2020 05:13:05 -0400 Received: from eggs.gnu.org ([209.51.188.92]:48808) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kQoST-00045P-CR for 43679@debbugs.gnu.org; Fri, 09 Oct 2020 05:13:03 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:57145) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kQoSN-0001jX-RF; Fri, 09 Oct 2020 05:12:55 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=56284 helo=gnu.org) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kQoSL-0001o4-AL; Fri, 09 Oct 2020 05:12:53 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Date: Fri, 9 Oct 2020 11:12:26 +0200 Message-Id: <20201009091231.26287-1-ludo@gnu.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <87mu17yzfn.fsf@inria.fr> References: <87mu17yzfn.fsf@inria.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -0.51 X-TUID: ZGeTP/UUu8cz Hi! This is v2 of this patch, with these changes: 1. ‘with-toolchain’ is replaced by ‘with-c-toolchain’ everywhere, with the understanding that it’s about the C/C++ toolchain in practice. In the end I’m sympathetic with the argument that C/C++ don’t have a monopoly on toolchains. ;-) 2. ‘--with-c-toolchain=PACKAGE=TOOLCHAIN’ rebuilds not just PACKAGE with TOOLCHAIN, but also everything above PACKAGE with TOOLCHAIN (in v1, only PACKAGE was rebuilt with TOOLCHAIN but everything above it had to be rebuilt anyway.) The main motivation here is to reduce the changes that we’re introducing ABI incompatibilities that users would have to work around by passing on ‘--with-c-toolchain’ for each package in the chain. I think it also more closely matches user expectations: when you see things are being rebuilt, you’re likely to think that’s because they’re rebuilt with the new toolchain, not the default one. Feedback welcome! Ludo’. Ludovic Courtès (5): gnu: gcc-toolchain: Add 'GUIX_LOCPATH' to the search paths. gnu: clang-toolchain: Add 'GUIX_LOCPATH' to the search paths. gnu: clang-toolchain: Create 'cc' and 'c++' symlinks. packages: Add 'package-with-c-toolchain'. guix build: Add '--with-c-toolchain'. doc/guix.texi | 70 +++++++++++++++++++++++++++++ gnu/packages/commencement.scm | 8 +++- gnu/packages/llvm.scm | 12 ++++- guix/build-system.scm | 35 ++++++++++++++- guix/packages.scm | 9 ++++ guix/scripts/build.scm | 84 +++++++++++++++++++++++++++++++++++ tests/packages.scm | 20 +++++++++ tests/scripts-build.scm | 82 ++++++++++++++++++++++++++++++++++ 8 files changed, 315 insertions(+), 5 deletions(-) -- 2.28.0