unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#43873] [PATCH 0/3] gnu: Add rust-dialoguer.
@ 2020-10-08 22:45 André Batista
  2020-10-08 22:57 ` [bug#43873] [PATCH 1/3] gnu: Add rust-tempfile-2 André Batista
                   ` (3 more replies)
  0 siblings, 4 replies; 6+ messages in thread
From: André Batista @ 2020-10-08 22:45 UTC (permalink / raw)
  To: 43873


[-- Attachment #1.1: Type: text/plain, Size: 731 bytes --]

Hello,

This patch series adds rust-dialoguer-0.3 which is a dependency for
wasm-pack. Unfortunately, one test is failing for this version and
I couldn't figure how to disable it without the hammer. Attached are
the logs for the test failures. It is missing a trait implementation
before usage, but src/prompts.rs appears to implement it. Maybe it
is the default impl that is lacking.

----

For more information about this error, try `rustc --explain E0277`.
Couldn't compile the test.

failures:
    src/prompts.rs - prompts::Input (line 35)

test result: FAILED. 3 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out

error: test failed, to rerun pass '--doc'
command "cargo" "test" "--release" failed with status 101

----

[-- Attachment #1.2: dsrw5179q6ssf1lhvybm979c1wgb98-rust-dialoguer-0.3.0.drv.bz2 --]
[-- Type: application/octet-stream, Size: 32966 bytes --]

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 841 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [bug#43873] [PATCH 1/3] gnu: Add rust-tempfile-2.
  2020-10-08 22:45 [bug#43873] [PATCH 0/3] gnu: Add rust-dialoguer André Batista
@ 2020-10-08 22:57 ` André Batista
  2020-10-08 22:59 ` [bug#43873] [PATCH 2/3] gnu: Add rust-dialoguer-0.6 André Batista
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 6+ messages in thread
From: André Batista @ 2020-10-08 22:57 UTC (permalink / raw)
  To: 43873


[-- Attachment #1.1: Type: text/plain, Size: 0 bytes --]



[-- Attachment #1.2: 0001-gnu-Add-rust-tempfile-2.patch --]
[-- Type: text/plain, Size: 1549 bytes --]

From 07cc5de055b6e19aef61ed889d4f1aa467db9ac9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20Batista?= <nandre@riseup.net>
Date: Thu, 8 Oct 2020 18:33:28 -0300
Subject: [PATCH] gnu: Add rust-tempfile-2.
To: guix-patches@gnu.org

* gnu/packages/crates-io.scm (rust-tempfile-2): New variable.
---
 gnu/packages/crates-io.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
index 48b70137da..542c397e8b 100644
--- a/gnu/packages/crates-io.scm
+++ b/gnu/packages/crates-io.scm
@@ -24254,6 +24254,29 @@ directories.")
     (license (list license:asl2.0
                    license:expat))))
 
+(define-public rust-tempfile-2
+  (package
+    (inherit rust-tempfile-3)
+    (name "rust-tempfile")
+    (version "2.2.0")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (crate-uri "tempfile" version))
+        (file-name (string-append name "-" version ".crate"))
+         (sha256
+          (base32
+           "1q61byf232rra0vqxp4qp10wwwqsqqd45qjj80ql5f34vgljzkhi"))))
+    (build-system cargo-build-system)
+    (arguments
+     `(#:skip-build? #t
+       #:cargo-inputs
+       (("rust-kernel32-sys" ,rust-kernel32-sys-0.2)
+        ("rust-libc" ,rust-libc-0.2)
+        ("rust-rand" ,rust-rand-0.3)
+        ("rust-redox-syscall" ,rust-redox-syscall-0.1)
+        ("rust-winapi" ,rust-winapi-0.2))))))
+
 (define-public rust-tendril-0.4
   (package
     (name "rust-tendril")
-- 
2.28.0


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 841 bytes --]

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [bug#43873] [PATCH 2/3] gnu: Add rust-dialoguer-0.6.
  2020-10-08 22:45 [bug#43873] [PATCH 0/3] gnu: Add rust-dialoguer André Batista
  2020-10-08 22:57 ` [bug#43873] [PATCH 1/3] gnu: Add rust-tempfile-2 André Batista
@ 2020-10-08 22:59 ` André Batista
  2020-10-08 23:00 ` [bug#43873] [PATCH 3/3] gnu: Add rust-dialoguer-0.3 André Batista
  2020-10-11 10:58 ` bug#43873: [PATCH 0/3] gnu: Add rust-dialoguer Efraim Flashner
  3 siblings, 0 replies; 6+ messages in thread
From: André Batista @ 2020-10-08 22:59 UTC (permalink / raw)
  To: 43873


[-- Attachment #1.1: Type: text/plain, Size: 0 bytes --]



[-- Attachment #1.2: 0001-gnu-Add-rust-dialoguer-0.6.patch --]
[-- Type: text/plain, Size: 1655 bytes --]

From aa042ce1360e7c15653e9021c5b916135d3d9842 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20Batista?= <nandre@riseup.net>
Date: Thu, 8 Oct 2020 18:43:52 -0300
Subject: [PATCH] gnu: Add rust-dialoguer-0.6.
To: guix-patches@gnu.org

* gnu/packages/crates-io.scm (rust-dialoguer-0.6): New variable.
---
 gnu/packages/crates-io.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
index 542c397e8b..7cdf5262fa 100644
--- a/gnu/packages/crates-io.scm
+++ b/gnu/packages/crates-io.scm
@@ -5374,6 +5374,31 @@ traits for both structs and enums.")
 structs and enums.")
   (license license:expat)))
 
+(define-public rust-dialoguer-0.6
+  (package
+    (name "rust-dialoguer")
+    (version "0.6.2")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (crate-uri "dialoguer" version))
+        (file-name
+         (string-append name "-" version ".tar.gz"))
+        (sha256
+         (base32
+          "0f31ahy6myg2vz9xrdmp0vx0m7x427a1wxpgrgwhxd0rgfpqdapl"))))
+    (build-system cargo-build-system)
+    (arguments
+     `(#:cargo-inputs
+       (("rust-console" ,rust-console-0.11)
+        ("rust-lazy-static" ,rust-lazy-static-1)
+        ("rust-tempfile" ,rust-tempfile-3))))
+    (home-page "https://github.com/mitsuhiko/dialoguer")
+    (synopsis "Library for command line prompts")
+    (description
+     "This package provides a library for command line prompts and the like.")
+    (license license:expat)))
+
 (define-public rust-diff-0.1
   (package
     (name "rust-diff")
-- 
2.28.0


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 841 bytes --]

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [bug#43873] [PATCH 3/3] gnu: Add rust-dialoguer-0.3.
  2020-10-08 22:45 [bug#43873] [PATCH 0/3] gnu: Add rust-dialoguer André Batista
  2020-10-08 22:57 ` [bug#43873] [PATCH 1/3] gnu: Add rust-tempfile-2 André Batista
  2020-10-08 22:59 ` [bug#43873] [PATCH 2/3] gnu: Add rust-dialoguer-0.6 André Batista
@ 2020-10-08 23:00 ` André Batista
  2020-10-11 10:58 ` bug#43873: [PATCH 0/3] gnu: Add rust-dialoguer Efraim Flashner
  3 siblings, 0 replies; 6+ messages in thread
From: André Batista @ 2020-10-08 23:00 UTC (permalink / raw)
  To: 43873


[-- Attachment #1.1: Type: text/plain, Size: 0 bytes --]



[-- Attachment #1.2: 0001-gnu-Add-rust-dialoguer-0.3.patch --]
[-- Type: text/plain, Size: 1582 bytes --]

From d670811b5b0f648c4b58f69f21e01bcac6d42795 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20Batista?= <nandre@riseup.net>
Date: Thu, 8 Oct 2020 18:49:44 -0300
Subject: [PATCH] gnu: Add rust-dialoguer-0.3.
To: guix-patches@gnu.org

* gnu/packages/crates-io.scm (rust-dialoguer-0.3): New variable.
---
 gnu/packages/crates-io.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
index 7cdf5262fa..ecbd9dae50 100644
--- a/gnu/packages/crates-io.scm
+++ b/gnu/packages/crates-io.scm
@@ -5399,6 +5399,29 @@ structs and enums.")
      "This package provides a library for command line prompts and the like.")
     (license license:expat)))
 
+(define-public rust-dialoguer-0.3
+  (package
+    (inherit rust-dialoguer-0.6)
+    (name "rust-dialoguer")
+    (version "0.3.0")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (crate-uri "dialoguer" version))
+        (file-name
+         (string-append name "-" version ".tar.gz"))
+        (sha256
+         (base32
+          "1a9gqvqp83gg4jbm286q5ab3l44zyyzlsdaiqmw8x4k80fdc5l8s"))))
+    (build-system cargo-build-system)
+    (arguments
+     `(;; One prompt test is failing on lacking default prompt impl.
+       #:tests? #f
+       #:cargo-inputs
+       (("rust-console" ,rust-console-0.7)
+        ("rust-lazy-static" ,rust-lazy-static-1)
+        ("rust-tempfile" ,rust-tempfile-2))))))
+
 (define-public rust-diff-0.1
   (package
     (name "rust-diff")
-- 
2.28.0


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 841 bytes --]

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* bug#43873: [PATCH 0/3] gnu: Add rust-dialoguer.
  2020-10-08 22:45 [bug#43873] [PATCH 0/3] gnu: Add rust-dialoguer André Batista
                   ` (2 preceding siblings ...)
  2020-10-08 23:00 ` [bug#43873] [PATCH 3/3] gnu: Add rust-dialoguer-0.3 André Batista
@ 2020-10-11 10:58 ` Efraim Flashner
  2020-10-23  1:26   ` [bug#43873] " André Batista
  3 siblings, 1 reply; 6+ messages in thread
From: Efraim Flashner @ 2020-10-11 10:58 UTC (permalink / raw)
  To: André Batista; +Cc: 43873-done

[-- Attachment #1: Type: text/plain, Size: 1557 bytes --]

On Thu, Oct 08, 2020 at 07:45:45PM -0300, André Batista wrote:
> Hello,
> 
> This patch series adds rust-dialoguer-0.3 which is a dependency for
> wasm-pack. Unfortunately, one test is failing for this version and
> I couldn't figure how to disable it without the hammer. Attached are
> the logs for the test failures. It is missing a trait implementation
> before usage, but src/prompts.rs appears to implement it. Maybe it
> is the default impl that is lacking.
> 
> ----
> 
> For more information about this error, try `rustc --explain E0277`.
> Couldn't compile the test.
> 
> failures:
>     src/prompts.rs - prompts::Input (line 35)
> 
> test result: FAILED. 3 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out
> 
> error: test failed, to rerun pass '--doc'
> command "cargo" "test" "--release" failed with status 101
> 
> ----

I'm not sure how you managed to build it, when I tried I got an error
about parking-lot-core@0.5 having the wrong inputs. Luckily it was
looking for <1.0.0 so I put in 0.11 and that one was more happy.

Looking at the .travis.yml it looks like they only test with the --lib
flag, so I removed skip-build and added cargo-test-flags '("--lib").

I was able to build rust-tempfile-2 without any problems, so I took out
the skip-build option.

Patches pushed! Thanks.


-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [bug#43873] [PATCH 0/3] gnu: Add rust-dialoguer.
  2020-10-11 10:58 ` bug#43873: [PATCH 0/3] gnu: Add rust-dialoguer Efraim Flashner
@ 2020-10-23  1:26   ` André Batista
  0 siblings, 0 replies; 6+ messages in thread
From: André Batista @ 2020-10-23  1:26 UTC (permalink / raw)
  To: Efraim Flashner; +Cc: 43873-done

[-- Attachment #1: Type: text/plain, Size: 981 bytes --]

Hello Efraim,

dom 11 out 2020 às 13:58:34 (1602435514), efraim@flashner.co.il enviou:
> I'm not sure how you managed to build it, when I tried I got an error
> about parking-lot-core@0.5 having the wrong inputs. Luckily it was
> looking for <1.0.0 so I put in 0.11 and that one was more happy.

I was building from a different local working tree, where I had defined
other packages, including parking-lot-core, so I guess I did not remember
every change I had made and I did not test on the master tree but on my
local tree.

From now on, I'll be sure to move those definitions one at a time when
trying to build to avoid further problems.

> Looking at the .travis.yml it looks like they only test with the --lib
> flag, so I removed skip-build and added cargo-test-flags '("--lib").
> 
> I was able to build rust-tempfile-2 without any problems, so I took out
> the skip-build option.
> 
> Patches pushed! Thanks.

Nice, thank you for pointing that out.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 841 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2020-10-23  1:28 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-08 22:45 [bug#43873] [PATCH 0/3] gnu: Add rust-dialoguer André Batista
2020-10-08 22:57 ` [bug#43873] [PATCH 1/3] gnu: Add rust-tempfile-2 André Batista
2020-10-08 22:59 ` [bug#43873] [PATCH 2/3] gnu: Add rust-dialoguer-0.6 André Batista
2020-10-08 23:00 ` [bug#43873] [PATCH 3/3] gnu: Add rust-dialoguer-0.3 André Batista
2020-10-11 10:58 ` bug#43873: [PATCH 0/3] gnu: Add rust-dialoguer Efraim Flashner
2020-10-23  1:26   ` [bug#43873] " André Batista

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).