From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 0nMUFS4+fl/tXgAA0tVLHw (envelope-from ) for ; Wed, 07 Oct 2020 22:16:14 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id gF5rEC4+fl8ZagAA1q6Kng (envelope-from ) for ; Wed, 07 Oct 2020 22:16:14 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0AE8E9400EF for ; Wed, 7 Oct 2020 22:16:12 +0000 (UTC) Received: from localhost ([::1]:55134 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kQHjH-00081D-8P for larch@yhetil.org; Wed, 07 Oct 2020 18:16:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33872) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kQHj8-000811-MF for guix-patches@gnu.org; Wed, 07 Oct 2020 18:16:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:46747) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kQHj8-0006ZM-DA for guix-patches@gnu.org; Wed, 07 Oct 2020 18:16:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kQHj8-0005nQ-8V for guix-patches@gnu.org; Wed, 07 Oct 2020 18:16:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#41803] [PATCH] Yggdrasil package and accompanying shepherd service (mesh network) Resent-From: raingloom Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 07 Oct 2020 22:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41803 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 41803@debbugs.gnu.org Received: via spool by 41803-submit@debbugs.gnu.org id=B41803.160210893522246 (code B ref 41803); Wed, 07 Oct 2020 22:16:02 +0000 Received: (at 41803) by debbugs.gnu.org; 7 Oct 2020 22:15:35 +0000 Received: from localhost ([127.0.0.1]:58293 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kQHih-0005mk-CS for submit@debbugs.gnu.org; Wed, 07 Oct 2020 18:15:35 -0400 Received: from mx1.riseup.net ([198.252.153.129]:39772) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kQHie-0005ma-RR for 41803@debbugs.gnu.org; Wed, 07 Oct 2020 18:15:34 -0400 Received: from bell.riseup.net (bell-pn.riseup.net [10.0.1.178]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client CN "*.riseup.net", Issuer "Sectigo RSA Domain Validation Secure Server CA" (not verified)) by mx1.riseup.net (Postfix) with ESMTPS id 4C67v80KQ2zFf2H for <41803@debbugs.gnu.org>; Wed, 7 Oct 2020 15:15:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1602108932; bh=ltnCgSYgbyGNOD2Y6mSI2ZrbDgcF48Ex7G4X/vjnqdU=; h=Date:From:To:Subject:In-Reply-To:References:From; b=XPl1w1C6XNgYAb3v3/U/ID0Gd7wkCMa22EsvRS92mQVaYJy4VPo07kn/zxjf9nh4k Scvetia/6F/Wzr0wYPeR82M6b1XyDsnxmLgB7w9PhZ9RdbZ8OlAwaCAyeicg2voL7q Mxn4ajXAxoNENCM7vJHhUP6uz+QdyLCooHc1+xMM= X-Riseup-User-ID: 097617DDB94BED58BB82771B019F3F980793E833E3DDA3FA852CBF703D679E27 Received: from [127.0.0.1] (localhost [127.0.0.1]) by bell.riseup.net (Postfix) with ESMTPSA id 4C67v73bm3zJnQL for <41803@debbugs.gnu.org>; Wed, 7 Oct 2020 15:15:31 -0700 (PDT) Date: Thu, 8 Oct 2020 00:15:52 +0200 From: raingloom Message-ID: <20201008001552.2d51fbbe@riseup.net> In-Reply-To: <20200713162330.79213853@riseup.net> References: <20200611155656.7ece9c24@riseup.net> <20200712001206.760aee62@tachikoma.lepiller.eu> <20200713162330.79213853@riseup.net> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.7 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=riseup.net header.s=squak header.b=XPl1w1C6; dmarc=fail reason="SPF not aligned (relaxed)" header.from=riseup.net (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: 0.09 X-TUID: jONOyUuRX1Ro On Mon, 13 Jul 2020 16:23:30 +0200 raingloom wrote: > On Sun, 12 Jul 2020 00:12:06 +0200 > Julien Lepiller wrote: > > > > > Hi, > > > > this is more of a quick review. > > > > First patch LGTM. > > > > You should split every package you add in the second patch in > > separate patches. Also the commit message should say "new > > variable", no need to say it's public. > > Done! > > > You left a comment about the license for go-github-com-gologme-log. > > Have you contacted upstream to tell them about that, what was their > > reaction? I think the fact that the readme says bsd implies the > > intention is that it is free software, but better safe than sorry. > > Heck, I forgot to do that, but I have contacted them yesterday and > they fixed it. > > > Otherwise, these packages lgtm. > > > > In the third patch again, the commit message should say "new > > variable". You should not use the past tense either, so "Add it". > > > > Is the licenes lgpl3, or lgpl3+? > > Looks like (custom) lgpl3. The readme says so and I couldn't find > anything to indicate that a later version would also be acceptable. > > > Not a go programmer, so I'm not reading the patch, but I'm trusting > > you that it works :) > > > > For the fourth patch, I don't think you need to list new private > > variables in the commit message, nor new dependencies. Only list > > public variables, as "New variables". > > > > As you noted, could you add something about it to the manual? > > On it, but I've never used texinfo, so this might take a while. Gonna > send it in a later mail. > > > In the system example, should Yggdrasil really be installed in the > > system profile? If so, I think you can add a profile-service-type > > extension to the service so the package is automatically available. > > Then you don't need to specify the package in the os configuration, > > and it ensures you install the same package (declared in the service > > configuration) for the service and in the system. > > Technically it can be used without it, but yggdrasilctl is a useful > tool. I added it with the profile-service-type extension and removed > it from the packages field in the example. > > > Thanks for working on this! > > UwU Bump. Could someone please test this? Others have expressed interest in usin Yggdrasil with Guix, so I really think these patches would be useful. New versions of the packages are already coming out though, so if necessary I could send a new patch series with the updated versions.